New issue
Advanced search Search tips

Issue 847597 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 851505


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

deploy git 2.17.1 binaries

Project Member Reported by wfh@google.com, May 29 2018

Issue description

see

https://blogs.msdn.microsoft.com/devops/2018/05/29/announcing-the-may-2018-git-security-vulnerability/

CVE 2018-11235
CVE 2018-11234

New binaries for git should probably be deployed as a result of this announcement.
 

Comment 1 by jrn@google.com, May 29 2018

 Issue 847601  has been merged into this issue.

Comment 4 by jrn@google.com, May 29 2018

Mind if I remove the Restrict-View-Google label?

Comment 5 by aga...@chromium.org, May 29 2018

I don't mind; I'm not sure if wfh@ had some other reason for having it here. All the info is public, though, so I don't see any reason to keep it restricted.

Comment 6 by jrn@google.com, May 29 2018

Labels: -Restrict-View-Google
Project Member

Comment 7 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/cf4aced37e993525b9e21856c0d1acec682edab1

commit cf4aced37e993525b9e21856c0d1acec682edab1
Author: Aaron Gable <agable@chromium.org>
Date: Tue May 29 21:32:22 2018

Update windows git to 2.17.1

This is for security updates related to
CVE 2018-11235
CVE 2018-11234
https://public-inbox.org/git/xmqqy3g2flb6.fsf@gitster-ct.c.googlers.com/

Bug:  847597 
Change-Id: I3b2d6b7bf9fe2d93bdc375903357f07f4fff8573
Reviewed-on: https://chromium-review.googlesource.com/1077307
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/cf4aced37e993525b9e21856c0d1acec682edab1/bootstrap/win/manifest_bleeding_edge.txt
[modify] https://crrev.com/cf4aced37e993525b9e21856c0d1acec682edab1/bootstrap/win/manifest.txt

Project Member

Comment 8 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e94d06e5a8a12dc70a14ae853e7d5ea7e7975b24

commit e94d06e5a8a12dc70a14ae853e7d5ea7e7975b24
Author: Aaron Gable <agable@chromium.org>
Date: Tue May 29 21:33:46 2018

Update cipd bootstrap git to 2.17.1

This is for security updates related to
CVE 2018-11235
CVE 2018-11234
https://public-inbox.org/git/xmqqy3g2flb6.fsf@gitster-ct.c.googlers.com/

Bug:  847597 
Change-Id: If3a1582326da2c7df8fd1375262bf6e9ccf9773a
Reviewed-on: https://chromium-review.googlesource.com/1077311
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/e94d06e5a8a12dc70a14ae853e7d5ea7e7975b24/scripts/slave/cipd_bootstrap_v2.py

Project Member

Comment 9 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f8aaccc437b65bf4c0ecb717fd6f48d96c8c945

commit 8f8aaccc437b65bf4c0ecb717fd6f48d96c8c945
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 29 23:57:24 2018

Roll src/third_party/depot_tools f16fdf3..cf4aced (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f16fdf3..cf4aced


git log f16fdf3..cf4aced --date=short --no-merges --format='%ad %ae %s'
2018-05-29 agable@chromium.org Update windows git to 2.17.1

Created with:
  gclient setdep -r src/third_party/depot_tools@cf4aced

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:847597 

TBR=agable@chromium.org

Change-Id: Iad93381bc712d4aa2d8a8aa26fd13a93b32537d7
Reviewed-on: https://chromium-review.googlesource.com/1077338
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562657}
[modify] https://crrev.com/8f8aaccc437b65bf4c0ecb717fd6f48d96c8c945/DEPS

Status: Fixed (was: Started)
Summary: deploy git 2.17.1 binaries (was: deploy new git binaries)
Status: Assigned (was: Fixed)
Aaron, I think something didn't go well, I still see this bot_update output:
2.17.0.chromium15 
(e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/129383)
Blocking: 851505

Comment 13 Deleted

Status: Started (was: Assigned)
Finally had the time to come back to this and find the place that wasn't updated.

https://chrome-internal-review.googlesource.com/c/infradata/config/+/642668

Having all of these different places is *incredibly* annoying.
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e42cef510026c8e4d1eca49ee709610633d69ff9

commit e42cef510026c8e4d1eca49ee709610633d69ff9
Author: Eric Boren <borenet@google.com>
Date: Wed Jun 20 11:32:18 2018

Update skia swarming task template to git 2.17.1

R=borenet

Bug:  chromium:847597 
Change-Id: I2f9b6fb0bb42cd5ed6e497fd1fd7b8f605e26515
Reviewed-on: https://skia-review.googlesource.com/135923
Reviewed-by: Eric Boren <borenet@google.com>
Commit-Queue: Eric Boren <borenet@google.com>

[modify] https://crrev.com/e42cef510026c8e4d1eca49ee709610633d69ff9/infra/bots/gen_tasks.go
[modify] https://crrev.com/e42cef510026c8e4d1eca49ee709610633d69ff9/infra/bots/tasks.json

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fc6ddaf15df3de70c5c5b0249dfe265b7c90c7f

commit 1fc6ddaf15df3de70c5c5b0249dfe265b7c90c7f
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jun 20 15:50:44 2018

Roll src/third_party/skia 4359d529121f..53418da8c647 (6 commits)

https://skia.googlesource.com/skia.git/+log/4359d529121f..53418da8c647


git log 4359d529121f..53418da8c647 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 mtklein@chromium.org exclude _none_imagefilters.cpp in Google3
2018-06-20 rmistry@google.com Fix license file in compute/skc/main.c
2018-06-20 rmistry@google.com [Bookmaker] Point to new fiddlecli location
2018-06-20 robertphillips@google.com Fix degenerate case handling in fill_in_2D_gaussian_kernel
2018-06-20 borenet@google.com Update skia swarming task template to git 2.17.1
2018-06-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 4004ae0e033a..a914f7ff310d (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@53418da8c647

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:849016 , chromium:847597 
TBR=kjlubick@chromium.org

Change-Id: I25d536203c78f4d829ab7a0bda506415688d9e87
Reviewed-on: https://chromium-review.googlesource.com/1107937
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568856}
[modify] https://crrev.com/1fc6ddaf15df3de70c5c5b0249dfe265b7c90c7f/DEPS

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/5ac4d3280fec7b67107a202dc2a4ce9ca0ed83a3

commit 5ac4d3280fec7b67107a202dc2a4ce9ca0ed83a3
Author: Aaron Gable <agable@chromium.org>
Date: Wed Jun 20 17:13:12 2018

Status: Fixed (was: Started)
Jobs have been update:
Using git version 2.17.1.chromium15 / Infra wrapper (infra/tools/git/linux-amd64 @ b83e1ae8c931a5261509cc15d443c2d608f65b15)

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/adbb25ea298870769a707443503b397e5d05eb43

commit adbb25ea298870769a707443503b397e5d05eb43
Author: Andrii Shyshkalov <tandrii@google.com>
Date: Thu Jun 21 02:03:54 2018

Comment 21 by jrn@google.com, Jun 21 2018

Status: Started (was: Fixed)
Reopening per comment#20.
Project Member

Comment 22 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/7112455cd3ff7844195fd04c0ac2c88b343c1bd1

commit 7112455cd3ff7844195fd04c0ac2c88b343c1bd1
Author: Robbie Iannucci <iannucci@google.com>
Date: Thu Jun 21 20:58:00 2018

Status: Fixed (was: Started)

Sign in to add a comment