mash: Run exo_unittests with --enable-features=SingleProcessMash |
|||||
Issue descriptionWe've had several cases where changes in exo introduced on-device-only crashes in mash. For example, mash doesn't yet have a cursor client. These are expensive to detect and fix, since they only show up as autotest failures after chrome uprevs on chromeos. Many exo unit tests use AshTestBase (via ExoTestBase) and we know most AshTestBase tests can run with --enable-features=Mash Consider running exo_unittests with mash, perhaps on the mojo FYI bot with a filter file. Thoughts?
,
Aug 15
Now that we no longer run ash_unittests with --Mash, is still worth doing?
,
Aug 16
If we are running ash_unittests with SingleProcessMash, we should run exo_unittests with SingleProcessMash as well.
,
Aug 31
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d9443ca6f13ae2945a886c5b78fe37324f8de88 commit 1d9443ca6f13ae2945a886c5b78fe37324f8de88 Author: James Cook <jamescook@chromium.org> Date: Tue Sep 04 22:35:12 2018 chromeos: Run exo_unittests under SingleProcessMash as FYI exo_unittests uses AshTestBase and exercises code in ash. Ash behaves differently enough under SingleProcessMash that we run ash_unittests with that feature enabled. Do the same with exo_unittests. Put this on the Mojo FYI bot for now. Fix a couple places that used aura::Env::GetInstance() in tests. Bug: 847585 Test: exo_unittests --enable-features=SingleProcessMash Change-Id: I9a2197bc68dcdd6d9d575b9014b872c8bec5ba14 Reviewed-on: https://chromium-review.googlesource.com/1200407 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#588673} [modify] https://crrev.com/1d9443ca6f13ae2945a886c5b78fe37324f8de88/components/exo/BUILD.gn [modify] https://crrev.com/1d9443ca6f13ae2945a886c5b78fe37324f8de88/components/exo/buffer_unittest.cc [modify] https://crrev.com/1d9443ca6f13ae2945a886c5b78fe37324f8de88/components/exo/client_controlled_shell_surface_unittest.cc [modify] https://crrev.com/1d9443ca6f13ae2945a886c5b78fe37324f8de88/components/exo/pointer_unittest.cc [modify] https://crrev.com/1d9443ca6f13ae2945a886c5b78fe37324f8de88/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/1d9443ca6f13ae2945a886c5b78fe37324f8de88/testing/buildbot/filters/BUILD.gn [add] https://crrev.com/1d9443ca6f13ae2945a886c5b78fe37324f8de88/testing/buildbot/filters/chromeos.single_process_mash.fyi.exo_unittests.filter [modify] https://crrev.com/1d9443ca6f13ae2945a886c5b78fe37324f8de88/testing/buildbot/test_suites.pyl
,
Sep 6
+rcui FYI. These are running on the mojo FYI bot and seem stable.
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a commit cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a Author: Ryan Cui <rcui@chromium.org> Date: Fri Sep 07 21:16:02 2018 Move SingleProcessMash tests to main waterfall The tests have been running for a while now and look stable. Move them over to the main waterfall so they start being run by the CQ. Bug: 874090 Bug: 847585 Change-Id: I8b013c568d0abbfb2697d5166dd6edda31bbbf88 Reviewed-on: https://chromium-review.googlesource.com/1212093 Commit-Queue: Ryan Cui <rcui@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#589655} [modify] https://crrev.com/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a/testing/buildbot/chromium.memory.json [modify] https://crrev.com/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a/testing/buildbot/filters/BUILD.gn [rename] https://crrev.com/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a/testing/buildbot/filters/chromeos.single_process_mash.ash_unittests.filter [modify] https://crrev.com/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter [rename] https://crrev.com/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a/testing/buildbot/filters/chromeos.single_process_mash.exo_unittests.filter [delete] https://crrev.com/4372d199af1f0d555d7bcc2241e3fc8d46dd06c2/testing/buildbot/filters/chromeos.single_process_mash.fyi.browser_tests.filter [modify] https://crrev.com/cdd6db93665914e9a55d2a69e1b0e0bdca3ca41a/testing/buildbot/test_suites.pyl
,
Sep 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39254f021e7b580cf2ae546fa1f8644e912b53f9 commit 39254f021e7b580cf2ae546fa1f8644e912b53f9 Author: Dominic Battre <battre@chromium.org> Date: Mon Sep 10 09:08:05 2018 Double timeout of single_process_mash_browser_tests It may make sense to increase the number of shards instead but I am not sufficiently knowledgable of capacity planning to do this change. The reason for increasing the timeout is that this bot times out consistently. TBR=rcui@chromium.org,sky@chromium.org Bug: 874090 BUG: 847585 Change-Id: I14f9d2eccbead7ef403e346deda5442a82d5ea27 Reviewed-on: https://chromium-review.googlesource.com/1215283 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#589864} [add] https://crrev.com/39254f021e7b580cf2ae546fa1f8644e912b53f9/internal_gyp [modify] https://crrev.com/39254f021e7b580cf2ae546fa1f8644e912b53f9/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/39254f021e7b580cf2ae546fa1f8644e912b53f9/testing/buildbot/chromium.memory.json [modify] https://crrev.com/39254f021e7b580cf2ae546fa1f8644e912b53f9/testing/buildbot/test_suites.pyl |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xiy...@chromium.org
, May 29 2018