New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847583 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-VR
Proj-XR



Sign in to add a comment

8.7% regression in xr.webvr.static at 558256:558307

Project Member Reported by mthiesse@chromium.org, May 29 2018

Issue description

Various perf increases and regressions in this range for WebVR rendering time.

Culprit is most likely https://chromium.googlesource.com/chromium/src/+/2aed04e1c9c0f581aba88ab3905c15ee0d9df2cc

Graphs at: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQoZiosAoM

Not sure whether that's overall a win or a loss.
 

Comment 1 by bshe@chromium.org, May 29 2018

I am not sure why the metrics could report a larger number. If anything, it should be less as the time we get from fence should be a time in the past.
@klausw, do you have any suspicion? The fence already exist before my patch. And the regression is about 2ms.

Comment 2 by bshe@chromium.org, May 29 2018

Oh, I remember it wrong. The old report use heuristic to guess the time. And after my patch, we use the accurate time. The heuristic is something like this:
      // Fence was already complete when we checked. It completed sometime
      // between the saved webvr_time_copied_ and now. Use the midpoint of
      // that as an estimate.
      base::TimeDelta lower_limit =
          rendering_frame->time_copied - prev_js_submit;
      base::TimeDelta midpoint = (lower_limit + prev_render) / 2;
      webvr_render_time_.AddSample(midpoint);
So it is probably just because the previous heuristic was report the wrong number. If so, there isn't anything that we should do.

Comment 3 by bshe@chromium.org, May 29 2018

Status: WontFix (was: Assigned)
close this one. Klaus and Michael, if you disagree and think that there is something else, feel free to reopen.
Components: Blink>WebXR

Sign in to add a comment