8.7% regression in xr.webvr.static at 558256:558307 |
|||
Issue descriptionVarious perf increases and regressions in this range for WebVR rendering time. Culprit is most likely https://chromium.googlesource.com/chromium/src/+/2aed04e1c9c0f581aba88ab3905c15ee0d9df2cc Graphs at: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQoZiosAoM Not sure whether that's overall a win or a loss.
,
May 29 2018
Oh, I remember it wrong. The old report use heuristic to guess the time. And after my patch, we use the accurate time. The heuristic is something like this:
// Fence was already complete when we checked. It completed sometime
// between the saved webvr_time_copied_ and now. Use the midpoint of
// that as an estimate.
base::TimeDelta lower_limit =
rendering_frame->time_copied - prev_js_submit;
base::TimeDelta midpoint = (lower_limit + prev_render) / 2;
webvr_render_time_.AddSample(midpoint);
So it is probably just because the previous heuristic was report the wrong number. If so, there isn't anything that we should do.
,
May 29 2018
close this one. Klaus and Michael, if you disagree and think that there is something else, feel free to reopen.
,
Jul 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bshe@chromium.org
, May 29 2018