New issue
Advanced search Search tips

Issue 847581 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 581518



Sign in to add a comment

add REF for jank tracking

Project Member Reported by skobes@chromium.org, May 29 2018

Issue description

JankTracker was added on issue 581518 to track layout jank during page load.  We would like to put it behind a RuntimeEnabledFeatures entry to isolate the performance impact and run Finch experiments.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e805d1d7eb70a4c1a2c0eaf5f99b8898700e2f

commit 70e805d1d7eb70a4c1a2c0eaf5f99b8898700e2f
Author: Steve Kobes <skobes@chromium.org>
Date: Tue May 29 23:21:32 2018

Add JankTracking REF.

Bug:  847581 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If37be17ab484884b4aaef83b1ddc2735a5d17aa0
Reviewed-on: https://chromium-review.googlesource.com/1077009
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562647}
[modify] https://crrev.com/70e805d1d7eb70a4c1a2c0eaf5f99b8898700e2f/third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc
[modify] https://crrev.com/70e805d1d7eb70a4c1a2c0eaf5f99b8898700e2f/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 2 by skobes@chromium.org, May 30 2018

Labels: Merge-Request-68
Project Member

Comment 3 by sheriffbot@chromium.org, May 31 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 4 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 4 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1773cad1de40c9105b8c0c64f6459d0403fa2d2

commit d1773cad1de40c9105b8c0c64f6459d0403fa2d2
Author: Steve Kobes <skobes@chromium.org>
Date: Mon Jun 04 20:09:10 2018

Add JankTracking REF.

TBR=skobes@chromium.org

(cherry picked from commit 70e805d1d7eb70a4c1a2c0eaf5f99b8898700e2f)

Bug:  847581 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: If37be17ab484884b4aaef83b1ddc2735a5d17aa0
Reviewed-on: https://chromium-review.googlesource.com/1077009
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562647}
Reviewed-on: https://chromium-review.googlesource.com/1086001
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#165}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/d1773cad1de40c9105b8c0c64f6459d0403fa2d2/third_party/blink/renderer/core/paint/pre_paint_tree_walk.cc
[modify] https://crrev.com/d1773cad1de40c9105b8c0c64f6459d0403fa2d2/third_party/blink/renderer/platform/runtime_enabled_features.json5

Status: Fixed (was: Assigned)

Sign in to add a comment