New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847578 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Corner case when check for flakiness in recent build is the same as the triggering build

Project Member Reported by lijeffrey@chromium.org, May 29 2018

Issue description

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzU4ODUvY29udGVudF9icm93c2VydGVzdHMvUVd4c0wwbHVjSFYwUkhKcGRtVnVTR2x6ZEc5bmNtRnRRbkp2ZDNObGNsUmxjM1F1VTJOeWIyeHNVR0ZuWlZkcGRHaFViM1ZqYUM4dwwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

In some cases, Findit is so fast that a recent build is still the triggering build, causing an assert when checking recent flakiness when making sure the data point hasn't been generated already (but has, because it triggered the analysis).
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/52a7db30cbfa3f7efe681e38bdc9d623bc2911ea

commit 52a7db30cbfa3f7efe681e38bdc9d623bc2911ea
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Wed May 30 19:24:57 2018

[Findit] Flake Analyzer - Fix check for flakiness in recent build

Observed: Assertion error occuring in DetermineApproximatePassRatePipeline
that checks if a data point exists then there must have been a previous
swarming task's output to have generated that data point.

Root Cause: CreateBugForFlakePipeline doesn't check if the triggering
build's commit position and the check for flakiness in a recent build is
in fact the same build, triggering the assert. Findit was too fast :)

Solution:
Check if a recent build's commit position has already been analyzed (same
as the triggering build's commit position) and if so, file the bug
immediately.

Bug:  847578 
Change-Id: Id91814a3ccbd0a4bcd142d854f8aa06a8765124c
Reviewed-on: https://chromium-review.googlesource.com/1077069
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>

[modify] https://crrev.com/52a7db30cbfa3f7efe681e38bdc9d623bc2911ea/appengine/findit/pipelines/flake_failure/test/create_bug_for_flake_pipeline_test.py
[modify] https://crrev.com/52a7db30cbfa3f7efe681e38bdc9d623bc2911ea/appengine/findit/pipelines/flake_failure/create_bug_for_flake_pipeline.py
[modify] https://crrev.com/52a7db30cbfa3f7efe681e38bdc9d623bc2911ea/appengine/findit/pipelines/flake_failure/determine_approximate_pass_rate_pipeline.py

Status: Fixed (was: Assigned)
Cc: lijeffrey@chromium.org
 Issue 841958  has been merged into this issue.

Sign in to add a comment