New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847572 link

Starred by 1 user
Status: Fixed
Owner:
gogerald@chromium.org
Closed: Jun 2018
Cc:
█ zkoch@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Payments] Allow following redirects when looking for Payment Method Manifest

Project Member Reported by ma...@chromium.org, May 29 2018 
Currently we do not allow redirect when making a HEAD request for the payment method manifest. 

As discussed in https://github.com/w3c/payment-method-manifest/issues/28#issuecomment-385977527, it should probably be allowed. 

Filing this so that we implement.
Project Member

Comment 1 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/932bd30cdff88280459b267d4b10167a17e5a23e

commit 932bd30cdff88280459b267d4b10167a17e5a23e
Author: gogerald <gogerald@google.com>
Date: Thu May 31 01:22:34 2018

[Payments] Allow at most three redirects when downloading payment methods manifests

Bug:  847572 
Change-Id: Ibe089ddb6aff0e0f1b424bf830a4092cb1f2c295
Reviewed-on: https://chromium-review.googlesource.com/1079149
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563106}
[modify] https://crrev.com/932bd30cdff88280459b267d4b10167a17e5a23e/components/payments/core/payment_manifest_downloader.cc
[modify] https://crrev.com/932bd30cdff88280459b267d4b10167a17e5a23e/components/payments/core/payment_manifest_downloader.h
[modify] https://crrev.com/932bd30cdff88280459b267d4b10167a17e5a23e/components/payments/core/payment_manifest_downloader_unittest.cc

Comment 2 by gogerald@chromium.org, May 31 2018

Labels: M-68 Merge-Request-68
Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 1 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d1d4eab3820921d8a5fea60454293738a477f5

commit c1d1d4eab3820921d8a5fea60454293738a477f5
Author: gogerald <gogerald@google.com>
Date: Fri Jun 01 12:18:55 2018

[Payments] Allow at most three redirects when downloading payment methods manifests

Bug:  847572 
Change-Id: Ibe089ddb6aff0e0f1b424bf830a4092cb1f2c295
Reviewed-on: https://chromium-review.googlesource.com/1079149
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563106}(cherry picked from commit 932bd30cdff88280459b267d4b10167a17e5a23e)
Reviewed-on: https://chromium-review.googlesource.com/1082451
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#84}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/c1d1d4eab3820921d8a5fea60454293738a477f5/components/payments/core/payment_manifest_downloader.cc
[modify] https://crrev.com/c1d1d4eab3820921d8a5fea60454293738a477f5/components/payments/core/payment_manifest_downloader.h
[modify] https://crrev.com/c1d1d4eab3820921d8a5fea60454293738a477f5/components/payments/core/payment_manifest_downloader_unittest.cc

Comment 5 by gogerald@chromium.org, Jun 1 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment