cryptohome package failing to build in canary |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of swboyd@google.com cryptohome package failing to build in canary Builders failed on: - auron_paine-release: http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8945322043077336272 - auron_yuna-release: http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8945321999880270304 - link-release: http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8945321990089653776 - lulu-release: http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8945321982143021040 - peppy-release: http://cros-goldeneye/chromeos/healthmonitoring/buildDetails?buildbucketId=8945322011110335744
,
May 29 2018
Not sure whether it's related to my recently landed changes. They should work independently IIUC. I see that the build failures are caused by the ServiceTestNotInitialized.CheckAutoCleanupCallback test failure in all quoted cases. There was some flakiness in this test that was fixed recently ( bug 840108 ), could it be that it appeared again? loyso@: Could you PTAL? Feel free to assign back if you think it's caused by some of my changes.
,
May 30 2018
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f75120b0df07ea6c56650a116af6379c288d8548 commit f75120b0df07ea6c56650a116af6379c288d8548 Author: Alexey Baskakov <loyso@chromium.org> Date: Sat Jun 02 08:32:29 2018 cryptohome: Fix Service CheckAutoCleanupCallback unittest flakiness 1) Do not depend on FreeDiskSpace count, just wait until it's done. 2) Add thread synchronization. This is a follow up for the crash bug 840108 . BUG= chromium:847558 TEST=cryptohome unit tests with ASAN enabled. Change-Id: I9b064ac68c1326b159ee8a8ed99b6fef7a0874b4 Reviewed-on: https://chromium-review.googlesource.com/1078030 Commit-Ready: Alexey Baskakov <loyso@chromium.org> Tested-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Gwendal Grignou <gwendal@chromium.org> [modify] https://crrev.com/f75120b0df07ea6c56650a116af6379c288d8548/cryptohome/service_unittest.cc
,
Jun 3 2018
,
Dec 17
Issue 839510 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by swboyd@chromium.org
, May 29 2018