New issue
Advanced search Search tips

Issue 847549 link

Starred by 1 user
Status: Fixed
Owner:
hinoka@chromium.org
Closed: May 2018
Cc:
tandrii@chromium.org
hinoka@chromium.org
efoo@chromium.org
no...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Deleted files show up as "/dev/null" in build blamelists

Project Member Reported by bpastene@chromium.org, May 29 2018 
Filing via milo's bug button.

See https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.ci/Linux%20Tests/70105 for instance.

Changes #2 and #12 in the blamelist delete some files. Their filenames show up as "/dev/null" which is clearly unhelpful. Can we get that replaced with the file's name?

Comment 1 by hinoka@chromium.org, May 29 2018 

lol

I think it's because a delete file's "new path" is "/dev/null", and not "", so
https://cs.chromium.org/chromium/infra/go/src/go.chromium.org/luci/milo/buildsource/buildbucket/build.go?g=0&l=188
is confused.  I guess we'll just explicitly test for "/dev/null"

Comment 2 by hinoka@chromium.org, May 29 2018

Owner: hinoka@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, May 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/cd22052d7886d7f698fe75dbe5154da8845a3983

commit cd22052d7886d7f698fe75dbe5154da8845a3983
Author: Ryan Tseng <hinoka@google.com>
Date: Tue May 29 19:19:45 2018

[milo] Show deleted filenames in blamelist

Bug:  847549 
Change-Id: I79381a12c1d7cd95acf8211612ec8a8f0da558cb
Reviewed-on: https://chromium-review.googlesource.com/1076971
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/cd22052d7886d7f698fe75dbe5154da8845a3983/milo/buildsource/buildbucket/build.go

Comment 4 by hinoka@chromium.org, May 30 2018

Status: Fixed (was: Started)
Should be fixed

Comment 5 by bpastene@chromium.org, May 30 2018 

yup yup tyvm
►

Sign in to add a comment