Download Infobar : Infobar doesn't surface ever again after open download link is clicked |
|||||||||
Issue descriptionThis happens due to cached TabModelSelector in the controller getting overwritten to an incorrect selector when CustomTabbedActivity is launched. We also have to think about multi-window mode a bit while fixing this issue. Ideally we should have one infobar per chrome tabbed activity.
,
May 30 2018
,
May 30 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
,
May 30 2018
,
May 30 2018
,
May 31 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 31 2018
,
May 31 2018
This happens when you click open for the completed download. Fixed in canary.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a6e961c756c8607f16310be5c5c2abcee526305 commit 3a6e961c756c8607f16310be5c5c2abcee526305 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Jun 01 00:33:17 2018 Download infobar : Fixed bug where infobar disappears after a while This happens due to the TabModelSelector cached by the controller getting overwritten any time when we open a CustomTabActivity. This also doesn't work in multi-window mode. Using the last focused activity gives us better control of the situation in this case. Though it doesnot solve multi-window scenario completely (as we may need to have one controller for each activity), it is definitely better than using tab model selector. TBR=shaktisahu@chromium.org (cherry picked from commit 3ee963d4e6487ff95572bc5929e08ef797e71df8) Bug: 847534 Change-Id: Ieca2c82adea89ee55894284b0eab10fc9068492d Reviewed-on: https://chromium-review.googlesource.com/1074450 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562902} Reviewed-on: https://chromium-review.googlesource.com/1081681 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#78} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/3a6e961c756c8607f16310be5c5c2abcee526305/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/3a6e961c756c8607f16310be5c5c2abcee526305/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java [modify] https://crrev.com/3a6e961c756c8607f16310be5c5c2abcee526305/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java
,
Jun 1 2018
,
Jun 7 2018
Verified in 69.0.3452.0 build |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, May 30 2018