New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847528 link

Starred by 0 users
Status: Fixed
Owner:
amalova@chromium.org
Closed: Sep 11
Cc:
█ bauerb@chromium.org
peconn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

CCT Session Reliability

Project Member Reported by amalova@chromium.org, May 29 2018 
Chrome Version: 69.0.3444.0
OS: Android


- Create a way to restore a handle to the session of the CCT if android decided to kill the client in the background while the CCT was in the foreground
- Create a way to create session retroactively (for cases where session was not created before the intent came in)


What steps will reproduce the problem?
(1) Turn on "Don't keep activities" in the Developer option to force android kill activity in the background
(2) Connect to Chrome Service, create a session and launch CCT with a created session 
(3) When user returns to the client, the client won’t have the session anymore
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/b9c2c017add7014593b9cf8d15b8ecfbd4d96d6d

commit b9c2c017add7014593b9cf8d15b8ecfbd4d96d6d
Author: Anna Malova <amalova@chromium.org>
Date: Thu Aug 23 14:47:26 2018

Allow connecting to existing CCT and update callback.

Add functionality to create a session with specified id which is represented by PendingIntent.
This id can be used to update a callback later.

Add PendingSession which is used as CCT identifier before client connects to CustomTabsService.

Related CL:1077147

Bug:  847528 
Change-Id: I263cd98646f05ca2a605fe41e58a788e9f66aaff
Reviewed-on: https://chromium-review.googlesource.com/1076648
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>

[modify] https://crrev.com/b9c2c017add7014593b9cf8d15b8ecfbd4d96d6d/customtabs/src/android/support/customtabs/CustomTabsSessionToken.java
[modify] https://crrev.com/b9c2c017add7014593b9cf8d15b8ecfbd4d96d6d/customtabs/src/android/support/customtabs/CustomTabsService.java
[modify] https://crrev.com/b9c2c017add7014593b9cf8d15b8ecfbd4d96d6d/customtabs/src/android/support/customtabs/CustomTabsSession.java
[modify] https://crrev.com/b9c2c017add7014593b9cf8d15b8ecfbd4d96d6d/customtabs/src/android/support/customtabs/CustomTabsIntent.java
[modify] https://crrev.com/b9c2c017add7014593b9cf8d15b8ecfbd4d96d6d/customtabs/src/android/support/customtabs/ICustomTabsService.aidl
[modify] https://crrev.com/b9c2c017add7014593b9cf8d15b8ecfbd4d96d6d/customtabs/src/android/support/customtabs/CustomTabsClient.java
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/7ad890c969e7fcae8cd078c1f109f2aadd0793ee

commit 7ad890c969e7fcae8cd078c1f109f2aadd0793ee
Author: amalova <amalova@google.com>
Date: Tue Sep 04 10:27:43 2018

Fix bug which causes NullPointerException in tests.

Bug:  847528 
Change-Id: I9f1eb7dfb2ddfa54567cb2ac601418b0764d6f34
Reviewed-on: https://chromium-review.googlesource.com/1202742
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>

[modify] https://crrev.com/7ad890c969e7fcae8cd078c1f109f2aadd0793ee/customtabs/src/android/support/customtabs/CustomTabsService.java
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/7ad890c969e7fcae8cd078c1f109f2aadd0793ee

commit 7ad890c969e7fcae8cd078c1f109f2aadd0793ee
Author: amalova <amalova@google.com>
Date: Tue Sep 04 10:27:43 2018

Fix bug which causes NullPointerException in tests.

Bug:  847528 
Change-Id: I9f1eb7dfb2ddfa54567cb2ac601418b0764d6f34
Reviewed-on: https://chromium-review.googlesource.com/1202742
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>

[modify] https://crrev.com/7ad890c969e7fcae8cd078c1f109f2aadd0793ee/customtabs/src/android/support/customtabs/CustomTabsService.java
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/7ad890c969e7fcae8cd078c1f109f2aadd0793ee

commit 7ad890c969e7fcae8cd078c1f109f2aadd0793ee
Author: amalova <amalova@google.com>
Date: Tue Sep 04 10:27:43 2018

Fix bug which causes NullPointerException in tests.

Bug:  847528 
Change-Id: I9f1eb7dfb2ddfa54567cb2ac601418b0764d6f34
Reviewed-on: https://chromium-review.googlesource.com/1202742
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>

[modify] https://crrev.com/7ad890c969e7fcae8cd078c1f109f2aadd0793ee/customtabs/src/android/support/customtabs/CustomTabsService.java

Comment 6 by amalova@chromium.org, Sep 11

Status: Fixed (was: Started)
►

Sign in to add a comment