New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847527 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 634542
issue 840372



Sign in to add a comment

Investigate poor round-trip performance of convertToBlob(Webp)

Project Member Reported by zakerinasab@chromium.org, May 29 2018

Issue description

When writing the round-trip layout test for convertToBlob, it turned out that encoding using Webp encoder results in significant error margin in both 8-8-8-8 and float16 canvas pixel formats.
The source of the problem should not be SkWebpEncoder, since the round-trip unit tests do pass. There might be something happening when drawing on the canvas, but still not sure. This requires more investigation.
 
Blocking: 840372
Cc: -junov@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ad8e04455855f7a439f58a0c22b7ff828fa0a84

commit 8ad8e04455855f7a439f58a0c22b7ff828fa0a84
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed Aug 15 00:27:42 2018

Remove higher tolerance in roundtrip ConvertToBlob layout tests for Webp

TBR=fserb@chromium.org

Bug:  847527 
Change-Id: I6effeada64f09fb2d0dc549a0de66a1c783915d1
Reviewed-on: https://chromium-review.googlesource.com/1175000
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583101}
[modify] https://crrev.com/8ad8e04455855f7a439f58a0c22b7ff828fa0a84/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorManaged-convertToBlob-roundtrip.html

Status: Fixed (was: Assigned)

Sign in to add a comment