New issue
Advanced search Search tips

Issue 847523 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: ----



Sign in to add a comment

Autofill suggestions looks bad on iPad with split keyboard

Project Member Reported by javierrobles@chromium.org, May 29 2018

Issue description

Chrome Version (from "Settings > About Google Chrome"): 66.0.3359.122
Device Type: (iPad 2, iPhone 4, etc) iPad Air 2
URLs (if applicable): NA


Behavior in Safari (if applicable): NA


Steps to reproduce:
(1) Split keyboard
(2) Visit a form that shows the autofill suggestions bar
(3) Observe

Expected result:


Actual result:
See attached image

 
pasted image 0.png
210 KB View Download
Cc: olivierrobin@chromium.org mahmadi@chromium.org
Components: UI>Browser>Autofill
Owner: javierrobles@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c38b9304e15dbf4e6e08dcf6ce74fc18949b27c

commit 9c38b9304e15dbf4e6e08dcf6ce74fc18949b27c
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Wed Jul 11 11:51:18 2018

Fix iPad's Split Keyboard whit an autofill accessory.

This CL fixes a cosmetic issue where the autofill bar was side to side
while the keyboard wasn't. The code mimics what Cocoa does when an
UITextField has an InputAccessoryView.

Before: https://goo.gl/fzjqtq
After: https://goo.gl/RU7ZkU

Bug:  847523 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7277c456d2ce307c1d29484340a4bc96abc3491a
Reviewed-on: https://chromium-review.googlesource.com/1122400
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574128}
[modify] https://crrev.com/9c38b9304e15dbf4e6e08dcf6ce74fc18949b27c/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm

Status: Fixed (was: Assigned)

Sign in to add a comment