New issue
Advanced search Search tips

Issue 847516 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task



Sign in to add a comment

Move and factorize bubble tip presentation code

Project Member Reported by gambard@chromium.org, May 29 2018

Issue description

The presentation code for presenting the in product help is in BVC and has lot of copy-pasted code.

It should have a better architecture.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/845e9f7026baa5d17a54a5f7b13c7c4812ef350c

commit 845e9f7026baa5d17a54a5f7b13c7c4812ef350c
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Jun 01 07:00:44 2018

Move the Bubble presentation code out of BVC

This CL moves and factorizes the code used to present the bubble tips
out of BVC to a separate class.

Bug:  847516 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2c0ec0dc6da5539d77760835655f53c4e987efc5
Reviewed-on: https://chromium-review.googlesource.com/1078734
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563556}
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/browser_view_controller.h
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/bubble/BUILD.gn
[add] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/bubble/bubble_presenter.h
[add] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/bubble/bubble_presenter.mm
[add] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/bubble/bubble_presenter_delegate.h
[delete] https://crrev.com/ff399b8a28025eb1545f1df53069df11939e140d/ios/chrome/browser/ui/bubble/bubble_view_anchor_point_provider.h
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/tabs/tab_strip_controller.h
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/tabs/tab_strip_legacy_coordinator.h
[modify] https://crrev.com/845e9f7026baa5d17a54a5f7b13c7c4812ef350c/ios/chrome/browser/ui/tabs/tab_strip_legacy_coordinator.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1bde2576a7c90e28c44e70c8560f37f0b462423

commit e1bde2576a7c90e28c44e70c8560f37f0b462423
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Jun 04 13:52:34 2018

Follow up for the bubble presenter refactoring

This CL is a follow up of the bubble presenter refactoring
crrev.com/c/1078734.

Bug:  847516 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6b91d9ffd10ec04333e2be7959e84e5752a123fd
Reviewed-on: https://chromium-review.googlesource.com/1082479
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564080}
[modify] https://crrev.com/e1bde2576a7c90e28c44e70c8560f37f0b462423/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/e1bde2576a7c90e28c44e70c8560f37f0b462423/ios/chrome/browser/ui/bubble/bubble_presenter.h
[modify] https://crrev.com/e1bde2576a7c90e28c44e70c8560f37f0b462423/ios/chrome/browser/ui/bubble/bubble_presenter.mm

Status: Fixed (was: Assigned)

Sign in to add a comment