Move and factorize bubble tip presentation code |
||
Issue descriptionThe presentation code for presenting the in product help is in BVC and has lot of copy-pasted code. It should have a better architecture.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1bde2576a7c90e28c44e70c8560f37f0b462423 commit e1bde2576a7c90e28c44e70c8560f37f0b462423 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Jun 04 13:52:34 2018 Follow up for the bubble presenter refactoring This CL is a follow up of the bubble presenter refactoring crrev.com/c/1078734. Bug: 847516 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6b91d9ffd10ec04333e2be7959e84e5752a123fd Reviewed-on: https://chromium-review.googlesource.com/1082479 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#564080} [modify] https://crrev.com/e1bde2576a7c90e28c44e70c8560f37f0b462423/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/e1bde2576a7c90e28c44e70c8560f37f0b462423/ios/chrome/browser/ui/bubble/bubble_presenter.h [modify] https://crrev.com/e1bde2576a7c90e28c44e70c8560f37f0b462423/ios/chrome/browser/ui/bubble/bubble_presenter.mm
,
Jun 4 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2018