Dropdown border on Mac not according to style for the native implementation |
||||||
Issue description
Chrome Version: M68
OS: MacOS
What steps will reproduce the problem?
(1) Enable flags:
#top-chrome-md = Refresh
#secondary-ui-md = Enabled
#enable-autofill-native-dropdown-views = Enabled
#mac-views-autofill-popup = Enabled
(2) Navigate to https://rsolomakhin.github.io/autofill/
(3) Click on any field with an autofill suggestion
What is the expected result?
The border shouldn't have a black edge and should look fainter.
What happens instead?
The border looks much more pronounced and there is a black edge on it.
,
May 29 2018
,
May 30 2018
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adc63ce587fc8d0abaf4c59a7da26a6e0be839e8 commit adc63ce587fc8d0abaf4c59a7da26a6e0be839e8 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Thu May 31 17:07:37 2018 [af] Fix border shadow on Mac This prevents the native border to be applied on the widget, so only the border style provided by views will be applied. This has no effect on Windows, but on Mac we get exactly what we need. Screenshots (Googlers only): https://drive.google.com/open?id=17hQlLXo5dk8XMwKU90wLgwigIVOhxPbn Bug: 847473 Change-Id: I5dccdadbae2405b259e3cad30857c0fb413a0338 Reviewed-on: https://chromium-review.googlesource.com/1076312 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562609}(cherry picked from commit 58c02f4c99010290e5982cb53889459dc59e8cdf) Reviewed-on: https://chromium-review.googlesource.com/1081027 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#63} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/adc63ce587fc8d0abaf4c59a7da26a6e0be839e8/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
,
Jun 5 2018
Tried checking the issue on 68.0.3440.0 and on 68.0.3440.15 using Mac 10.13.1 with the exact steps mentioned in comment#0. @Fabio Tirelo: As we are not very sure about the expected and actual behaviour, Attaching the screenshot of both with and without fix. Hence requesting you to help us in verifying the fix. (...right side of image) -with fix (...left side of image) - with out fix Thanks!
,
Jul 14
vamshi.kommuri@: somehow I missed this message. Please notice that the bug corresponds to the Autofill dropdown shadow. The issue you reported is related to the input field. Please report the issue to the blink team.
,
Jul 16
ftirelo@, thank you for the update. vamshi.kommuri@, please report a new bug with label 'Blink>Input' as per c#6. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, May 29 2018