New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847454 link

Starred by 1 user

Issue metadata

Status: Unconfirmed
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

[FR] Unifying context menu from web page and new tab

Project Member Reported by mar...@mwiacek.com, May 29 2018

Issue description

Current:

1. open new tab and open context menu
2. open any web site and open context menu

Menu from step 1 and 2 look differently - they're created using different fonts and different visual elements

Proposed:

Context menu from step 1 will be created using the same method like in step 2

Note:

I've made investigation, can prepare patch and need only UX approval to proceed.
 

Comment 1 by mar...@mwiacek.com, May 29 2018

Cc: austinknight@chromium.org hannahs@chromium.org
hannahs@ and austinknight@, could you provide your input to this?

Comment 2 by mar...@mwiacek.com, May 29 2018

Components: UI>Browser>NewTabPage UI>Browser>Mobile

Comment 3 by mar...@mwiacek.com, May 29 2018

Summary: [FR] Unifying context menu from web page and new tab (was: [FR] Unifying context menu)
Labels: Needs-triage-Mobile
Labels: Triaged-Mobile M-69
As per original comment, this looks to be a feature request. Hence adding related labels.

Thanks!!

Comment 6 by hannahs@google.com, Jun 4 2018

W're currently working on a new design that may address this issue here: https://bugs.chromium.org/p/chromium/issues/detail?id=655359

Will follow up soon as we have clear next steps!

Comment 7 by mar...@mwiacek.com, Jun 4 2018

thx, I have submitted about 34 issues about context menu (including various notes about design too and also ready code which is suspended now): https://bugs.chromium.org/p/chromium/issues/list?can=2&q=mwiacek+context&colspec=ID+Pri+M+Stars+ReleaseBlock+Component+Status+Owner+Summary+OS+Modified&x=m&y=releaseblock&cells=ids

I will appreciate if you will use this work too.

Comment 8 by mar...@mwiacek.com, Jun 5 2018

I've added some PoC for this change: https://chromium-review.googlesource.com/c/chromium/src/+/1087466 (it's not ready, but because of lack of next steps I have to suspend it :( )
Cc: lzbylut@chromium.org
lzbylut@, could you look on it please and let me know if you could help with this?

I strongly believe, that adding such context menu on NTP like in regular webpage will give only profit.
Hi Marcin, 

Are you sure that the issue as reported is still true?

I took these two screenshots - one after long pressing on a Most Visited tile on the NTP and another one after long pressing on a link in wikipedia.

I can't see a clear difference between how these two context menus are constructed or displayed - different fonts and visual elements as you say.

Can you add images about what you're seeing?
Screenshot_20190114-153359.png
201 KB View Download
Screenshot_20190114-153424.png
162 KB View Download
Also, can you have a look at the 'enable custom context menu' flag and the context menu it enables on a web page (ntp is still unchanged). This feature is currently on hold, but it likely reflects the larger context menu design direction that hannah referenced in comment 6.
About context menu redesign I hear from months - honestly speaking it's like urban legend now (everybody is speaking, nobody has seen), bug fixes are stopped because of it (yes, I started with proposing them...) and (what's the most scaring) I have heard that current nice split for pages will be removed after it (but I cannot check it because doc is not public).

Anyway, I'm using custom context menu and it has more options, for share link it has got icon, there is header, etc.

I don't see reason why we can't have the same look and shared code for these two.
Screenshot_20190115-013355_Chrome Canary.jpg
675 KB View Download
Screenshot_20190115-013415_Chrome Canary.jpg
677 KB View Download
I may have misunderstood your initial report. I thought you were saying that the context menu on the NTP is different from the context menu on a wepgage in the Default experience of Chrome. To me they look the same.

If you are proposing to apply the changes of the 'enable custom context menu' flag to the NTP context menu, I feel that is totally ok. I would love to have the same look and code for the context menus on the NTP and on webpages. 

What do you need to make that happen and how can we help?

Comment 14 Deleted

Comment 15 Deleted

Hi Lukasz,

Thank you very much for your feedback.

I was just thinking about using generic context menu code for displaying NTP menu and nothing more (I don't make separation between "old" or "new" menu - after implementing proposal visual look will depend on flags or experiments for context menu).

I don't want to add or remove anything, menu will have characteristic elements from context menu like header, tabs if any, etc.

We need to answer on few questions:

1. do we want to implement this as experiment?

2. how should we proceed with statistics? Should we move current code or should we create something new?

I was think about preparing just few patches:

1. adding code from existing NTP context menu options to web-page context menu code (it will probably create new entries + move code + share code where possible)

2. (if we will have experiment) creating code switching between old and new menu

3. making cleanup

4. deciding what menu options we want to have (steps 1-3 will just move existing menu options like Remove, Learn more, etc. and when code will be OK we could decide if we want to have for example "Share link")

To work on it:

1. I will be more than happy to complete https://chromium-review.googlesource.com/c/chromium/src/+/1215323 (it's the same area and I believe that it makes sense to do it first)

2. there will be required help with completing paper work - UX approval or everything else we need and I'm maybe not aware about (note: I want to follow rules and I don't want to waste time for example when your team will decide not to do this with external person)

3. Especially after some looking into code I could prepare more formal technical doc

4. Coding - I can do it, I will need somebody who could review it in effective way

5. Somebody should help me with experiments (I mean - I don't have probably all accesses)

Shortly speaking - to implement this I need some confirmation, that we want to do it + I need help with all tasks, which must be done internally, 

coding & research I can do on myself.

wdyt?

Comment 17 by lzbylut@google.com, Jan 16 (6 days ago)

Cc: jpor@chromium.org
Thank you for your comments. Before you spend more time on this task, please allow me to communicate with our design team to get a sense of the priority of making changes in this area. 

I wan to make sure we are spending our time well, especially since the experience in the default Stable version of Chrome (with all flags set to default) is currently the same between the New Tab Page and the webpage context menus. 

Sign in to add a comment