New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847436 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue skia:8019

Blocking:
issue 634542
issue 840372



Sign in to add a comment

Improve ColorCorrectionTestUtils::MatchSkImages()

Project Member Reported by zakerinasab@chromium.org, May 29 2018

Issue description

When  crbug.com/skia/8019  is fixed, in ColorCorrectionTestUtils::MatchSkImages():

- Check the color type of the images
- Use SkPixmap instead of doing a readback to memory.
 
The Skia bug was closed since this is an intended behavior. Skia does not keep a cached link to the decoded image, since the decoded image does not have some of the info set correctly, and it fails on peekPixmap. The solution to this is to create a raster version of the decoded image and access the pixmap then.

See this fiddle: https://fiddle.skia.org/c/6bc9f45f821533f128003add293c14f8
*peekPixmap* --> *peekPixels*
Blocking: 840372
Project Member

Comment 4 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18c9afdfdca9ba786f0feed6c14074cc468984b9

commit 18c9afdfdca9ba786f0feed6c14074cc468984b9
Author: Reza.Zakerinasab <zakerinasab@chromium.org>
Date: Wed May 30 21:04:11 2018

Implement HTMLCanvaElement::convertToBlob()

HTMLCanvaElement::convertToBlob() is a new promise-based toBlob
API that allows to specify the color space and the pixel format
of the target blob.

Bug:  840372 , 847436 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I77c8b98ada3a5f9fbef38ad1b86d9ef15fdea570
Reviewed-on: https://chromium-review.googlesource.com/1048169
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562990}
[add] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-colorManaged-convertToBlob-roundtrip.html
[delete] https://crrev.com/5d3781923cdbfff3a168ab1284888c01923d1543/third_party/WebKit/LayoutTests/platform/win/virtual/color_space/fast/canvas/color-space/toDataURL-color-managed-round-trip-expected.png
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/core_idl_files.gni
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.h
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator_test.cc
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/html_canvas_element.idl
[add] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/html/canvas/image_encode_options.idl
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/inspector/inspector_audits_agent.cc
[delete] https://crrev.com/5d3781923cdbfff3a168ab1284888c01923d1543/third_party/blink/renderer/core/offscreencanvas/image_encode_options.idl
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.h
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/platform/graphics/canvas_color_params.cc
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/platform/graphics/canvas_color_params.h
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/platform/graphics/color_correction_test_utils.cc
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/platform/graphics/color_correction_test_utils.h
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/platform/graphics/image_data_buffer.cc
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/third_party/blink/renderer/platform/graphics/image_data_buffer.h
[modify] https://crrev.com/18c9afdfdca9ba786f0feed6c14074cc468984b9/tools/metrics/histograms/enums.xml

Status: Fixed (was: Assigned)

Sign in to add a comment