New issue
Advanced search Search tips

Issue 847432 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-08-02
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Update collection icons

Project Member Reported by pschaffner@chromium.org, May 29 2018

Issue description

They should have the same visual weight/style as the actions.
 
Components: Design

Comment 2 by marq@chromium.org, Jun 27 2018

Labels: Q2
Labels: -Pri-3 M-69 Pri-1
NextAction: 2018-08-02
Pete: please try to get these done today. Thanks!
The NextAction date has arrived: 2018-08-02
Owner: martijnb@chromium.org
Assigning to Martijn since I won't be able to get to this before being OOO.

Martijn: I basically want to try making the collection icons look more like the actions in terms of weight/scale/etc. Now that they are in the middle of the list, it feels stranger to have them feel unique/heavier.

Thanks!
IMG_6AF47475F1DD-1.jpeg
1.1 MB View Download
Cc: pschaffner@chromium.org mard...@chromium.org martijnb@chromium.org
Owner: gambard@chromium.org
New assets here:

https://drive.google.com/corp/drive/u/0/folders/1UJWA2VvF_xjTl2iUtumNCNfx8GsYHit9
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938

commit 2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Aug 03 15:24:04 2018

[iOS] Change ToolsMenu icons

This CL changes the icons for the collections entry of the popup menu
to have them more consistent with the other icons.

Bug:  847432 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If1caed157cc50cc9c55c7c61cd2a87403d0ea009
Reviewed-on: https://chromium-review.googlesource.com/1162227
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580555}
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks@2x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks@3x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history@2x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history@3x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list@2x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list@3x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs@2x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs@3x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings@2x.png
[modify] https://crrev.com/2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings@3x.png

Labels: Merge-TBD
Status: Fixed (was: Assigned)
Cc: kariahda@chromium.org
Labels: -Merge-TBD Merge-Request-69
Status: Verified (was: Fixed)
Verified in Canary.
+kariahda@ for merge request.
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 7

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: Less than 24 days to go before AppStore submit on M69
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-69 Merge-Approved-69
Approved. Please merge asap.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 7

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cac3c92c98602b795b02567f050689e92924a769

commit cac3c92c98602b795b02567f050689e92924a769
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Aug 07 15:13:14 2018

[iOS] Change ToolsMenu icons

This CL changes the icons for the collections entry of the popup menu
to have them more consistent with the other icons.

Bug:  847432 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If1caed157cc50cc9c55c7c61cd2a87403d0ea009
Reviewed-on: https://chromium-review.googlesource.com/1162227
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580555}(cherry picked from commit 2b5bc6be12cb73d5bde0fe57cf4a3dbecb0b6938)
Reviewed-on: https://chromium-review.googlesource.com/1165462
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#465}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks@2x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_bookmarks.imageset/popup_menu_bookmarks@3x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history@2x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_history.imageset/popup_menu_history@3x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list@2x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_reading_list.imageset/popup_menu_reading_list@3x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs@2x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_recent_tabs.imageset/popup_menu_recent_tabs@3x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings@2x.png
[modify] https://crrev.com/cac3c92c98602b795b02567f050689e92924a769/ios/chrome/browser/ui/popup_menu/resources/popup_menu_settings.imageset/popup_menu_settings@3x.png

Verified in 69.0.3497.31 Beta,  iPhone X iOS 11.4.1, iPhone 6 iOS 10.3.3, iPad Air  iOS11.4

Sign in to add a comment