New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847414 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Webpage screenshot can be watched, even if it was opened in incognito mode and its tab and Google Chrome are already closed!

Reported by fed...@gmail.com, May 29 2018

Issue description

Chrome Version (from "Settings > About Google Chrome"): 66.0.3359.122
Device Type: iPhone 7 PLUS 128GB Black
URLs (if applicable): any fullscreen video e.g. https://www.youtube.com/watch?v=G3NXNnoGr3Y


Behavior in Safari (if applicable): in Sarafy browser on iOS the bug is not applicable (a blank white screenshot appear instead)


Steps to reproduce:
(1) Screen auto-rotation should be enabled
(2) Turn the device to portrait view
(3) Open Google Chrome
(4) Add new incognito tab
(5) Open webpage with a video e.g. https://www.youtube.com/watch?v=G3NXNnoGr3Y
(6) Play video in fullscreen mode 
(7) Turn the device to landscape view
(8) Hide the app (tap the Home button once)
(9) Turn the device to portrait view 
(10) Open the app (IMPORTANT: tap the icon; if double tap the Home button and choose the app from the list of running apps - the bug won't appear)
(11) Close the incognito tab
(12) Close the app completely (double-tap the Home button and swipe)
(13) Open the app
(14) Hide the app (tap the Home button once)
(15) Turn the device to landscape view
(16) Open the list of all running apps (double tap the Home button)
(17) You can see a preview screenshot of already closed incognito tab

Expected result: A blank preview screenshot should be presented as in Safari


Actual result: You can see a preview screenshot of already closed incognito tab


The bug will also appear if you switch all landscape/portrait instructions. In such case the buggy screenshot will be in portrait mode.

This bug can be very confusing in some cases ;) Please keep our privacy even from those who have an access to our devices. I hope to get i reward for this bug :)

 

Comment 1 by e...@chromium.org, May 29 2018

Components: UI>Browser

Comment 2 by mmenke@chromium.org, May 29 2018

Components: Privacy>Incognito
Labels: -Pri-3 Pri-2
Probably related to  issue 679663 .

That bug's owner, lpromero@, left the team. iOS folks, can you please triage?

Comment 4 by fed...@gmail.com, May 30 2018

For a typical webpage there is no bug now.
Current problem only occurs when fullscreen video was opened.
Owner: justincohen@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: srikanthg@chromium.org
Labels: ReleaseBlock-Stable M-70
srikanthg@ can you confirm?
I can reproduce this with latest M69 on iPhone7 plus device.
Cc: -srikanthg@chromium.org mard...@chromium.org
Labels: Type-Bug
This is reproducible on all devices.

New set of steps for easy repro: (form Justin)

1. Launch Google Chrome
2. Open Incognito tab
3. Open youtube.com and play any video in fullscreen mode
4. Background the app.
5. Double click Home button to bring up App Switcher.

Actual Result: Video snapshot is displayed.

Expected Result: Chrome splash screen should be displayed masking the contents of the incognito.

Doesn't reproduce on Safari. Reproduces on Firefox private tabs as well.

Tested on iPhone7plus, iOS10.3.3 and iPhoneX iOS12.0

Its currently marked for RBS M70, please prioritize. 


Cc: justincohen@chromium.org
Owner: ghendel@chromium.org
ghendel/mardini@ WDYT for priority/milestone?
Cc: rhalavati@chromium.org
Could somebody answer when and how I will recieve a reward according to Chrome Reward Program?
Cc: awhalley@chromium.org
I think as you have not used the template for security bugs, this is not monitored by the VRP team (and I very much suspect that it would be considered a security bug as it's mostly privacy related).

awhalley@,
Could you please check?
Labels: -ReleaseBlock-Stable -M-70 M-71
Confirmed that this is a bug and should be a P2. 
Changing the label to M71 (would be good to have a fix soon) and assigning to justincohen@ who can reassign if this should go to someone else.

Cc: ghendel@chromium.org
Owner: justincohen@chromium.org
Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cbae5d129b4ae71337cd24d1fb5ebfcdb5c70e4

commit 7cbae5d129b4ae71337cd24d1fb5ebfcdb5c70e4
Author: Justin Cohen <justincohen@google.com>
Date: Mon Nov 05 15:28:23 2018

Use the shared application window for the incognito overlay.

Allows the incognito overlay to appear for system overlays like
fullscreen videos.

Bug:  847414 
Change-Id: I0594535d0e2a1667c77faf01da88d502f19aa67f
Reviewed-on: https://chromium-review.googlesource.com/c/1316598
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605337}
[modify] https://crrev.com/7cbae5d129b4ae71337cd24d1fb5ebfcdb5c70e4/ios/chrome/app/application_delegate/app_state.mm
[modify] https://crrev.com/7cbae5d129b4ae71337cd24d1fb5ebfcdb5c70e4/ios/chrome/app/application_delegate/app_state_unittest.mm

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Reopening 
Version: Chrome Beta 71.0.3578.49
Device: iPhone 8
iOS: 12.1

Video snapshot is displayed
https://drive.google.com/open?id=1FgzCK8Xxd0iq1UYMv4djmi3V6pB0Fs6U
Status: Fixed (was: Assigned)
This is fixed on M72.  I do not think this needs to be cherry-picked to M71.

Sign in to add a comment