New issue
Advanced search Search tips

Issue 847408 link

Starred by 2 users
Status: Verified
Owner:
javierrobles@chromium.org
Closed: Aug 28
Cc:
javierrobles@chromium.org
olivierrobin@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Accessory bar disappears after closing "All passwords" view

Project Member Reported by javierrobles@chromium.org, May 29 2018 
Chrome Version (from "Settings > About Google Chrome"): 66.0.3359.122
Device Type: (iPad 2, iPhone 4, etc) iPhone X, iPhone SE
URLs (if applicable): accounts.google.com


Behavior in Safari (if applicable): NA


Steps to reproduce:
(1) Make sure there is a password saved
(2) Start log in process on google.com
(3) Enter email, submit
(4) Touch "Show All" in the passwords view above the keyboard
(5) Close the view that appeared
(6) Observe


Expected result:
Accessory view is there

Actual result:
Accessory view is not there, a gray empty bar is in its place.
36526.jpg
479 KB View Download
Simulator Screen Shot - iPhone SE - 2018-05-29 at 12.27.59.png
80.1 KB View Download

Comment 1 by javierrobles@chromium.org, Jun 29 2018

Components: -UI>Browser>Autofill>UI UI>Browser>Autofill

Comment 2 by pkl@chromium.org, Jul 2

Cc: olivierrobin@chromium.org javierrobles@chromium.org
Owner: mahmadi@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 3 by javierrobles@chromium.org, Jul 12

Owner: javierrobles@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96

commit c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Fri Aug 10 04:32:28 2018

[iOS][AF] Create FormInputAccessoryMediator

This CL moves all the logic from the FormInputAccessoryViewController
that is not directly related to managing its view to a new mediator.
Creates a consumer for the communication the the view controller.
Updates tests to use this mediator instead.
Removes the dependency on the CRWWebViewProxy.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b0f6c595f069ea45e04c9dacdc4437dbfe9041a
Bug: 661622, 727716,  845472 ,  847408 
Reviewed-on: https://chromium-review.googlesource.com/1130522
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582056}
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/BUILD.gn
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/autofill_controller_unittest.mm
[add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_consumer.h
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_controller.h
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_controller.mm
[add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_handler.h
[add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_handler.mm
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_accessory_view_provider.h
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_input_egtest.mm
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_suggestion_controller.mm
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/passwords/BUILD.gn
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/passwords/password_controller_unittest.mm
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/ui/autofill/BUILD.gn
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/ui/autofill/form_input_accessory_coordinator.mm
[add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.h
[add] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/web/public/web_state/ui/crw_web_view_proxy.h
[modify] https://crrev.com/c381b07f9e1095f0b5e26c5b92b52e7c0bda5c96/ios/web/web_state/ui/crw_web_view_proxy_impl.mm
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecf5d27bfbed8c930825a50720cea2c7719f0e48

commit ecf5d27bfbed8c930825a50720cea2c7719f0e48
Author: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Date: Tue Aug 28 10:32:03 2018

[iOS][AF] FIX:Accessory bar dissapears on iPhone

Do not reset accessory on iPhone when web state is hidden. This reset
was clearing the input accessory, and when returning it was not being
set again due no form activity detected.

Bug:  847408 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I5fabf42691476a7313db76bf5110b04cbf28a25e
Reviewed-on: https://chromium-review.googlesource.com/1186725
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586641}
[modify] https://crrev.com/ecf5d27bfbed8c930825a50720cea2c7719f0e48/ios/chrome/browser/ui/autofill/form_input_accessory_mediator.mm

Comment 6 by javierrobles@chromium.org, Aug 28

Status: Fixed (was: Started)

Comment 7 by rakurati@chromium.org, Sep 5

Status: Verified (was: Fixed)
Verified in 70.0.3538.6 Beta in iPhone 7(iOS 11.4.1), iPhone 6s plus(iOS 12 beta 12)

Followed the steps mentioned in comment#0, password suggestions are now displayed after dismissing the passwords UI.

Link to video:
https://drive.google.com/file/d/12MxUOLs7IQ94QHqFsxiO8lXunKjIlXl6/view?usp=sharing
►

Sign in to add a comment