Issue metadata
Sign in to add a comment
|
"virtual/pwa-full-code-cache/http/tests/devtools/service-workers/service-workers-force-update-on-page-load.js" is flaky |
||||||||||||||||||||||
Issue description"virtual/pwa-full-code-cache/http/tests/devtools/service-workers/service-workers-force-update-on-page-load.js" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNydwsSBUZsYWtlImx2aXJ0dWFsL3B3YS1mdWxsLWNvZGUtY2FjaGUvaHR0cC90ZXN0cy9kZXZ0b29scy9zZXJ2aWNlLXdvcmtlcnMvc2VydmljZS13b3JrZXJzLWZvcmNlLXVwZGF0ZS1vbi1wYWdlLWxvYWQuanMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 30 2018
Test appears to flake on linux-chromium-rel-ng and mac-chromium-rel-ng. I'm going to add a timeout expectation for Mac and Linux.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec4a7ef3e6f27a4a89d15f5c902e710eca0cb3e8 commit ec4a7ef3e6f27a4a89d15f5c902e710eca0cb3e8 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed May 30 19:50:30 2018 Add timeout expectation for service-workers-force-update-on-page-load.js Bug: 847373 Change-Id: I6a370c3be5b84343fec9a6be6b4c8d1fa305f8ac No-Try: true Tbr: chenwilliam@chromium.org, horo@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1076867 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#562965} [modify] https://crrev.com/ec4a7ef3e6f27a4a89d15f5c902e710eca0cb3e8/third_party/WebKit/LayoutTests/TestExpectations
,
May 30 2018
horo@: Could you PTAL at this?
,
Jun 5 2018
shimazu@ Could you please handle this?
,
Jun 5 2018
Since pwa-full-code-cache is enabled by default, we can just remove this virtual test suite as it's testing the same thing as the default.
,
Jun 5 2018
We should remove the virtual test suite but the test is failing on default too. Filed 849665
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52ab7ec9b6d3531ac11cde6f414ee8b434082a9c commit 52ab7ec9b6d3531ac11cde6f414ee8b434082a9c Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Jun 05 15:20:30 2018 Remove virtual/pwa-full-code-cache test suite. pwa-full-code-cache is already enabled by default, so the virtual test suite is redundant with the default test suite. Note that the expectation file for service-worker-v8-cache.js differs from the default. But both have TestExpectations for Pass Failure so the expectations are essentially unused. Bug: 788621, 789111, 480769 , 847373 Change-Id: I8c9d79ed104437a98edd6eba68ac3bef01e7f1a4 TBR: horo Reviewed-on: https://chromium-review.googlesource.com/1086956 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#564507} [modify] https://crrev.com/52ab7ec9b6d3531ac11cde6f414ee8b434082a9c/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=HeapIncrementalMarkingStress [modify] https://crrev.com/52ab7ec9b6d3531ac11cde6f414ee8b434082a9c/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/52ab7ec9b6d3531ac11cde6f414ee8b434082a9c/third_party/WebKit/LayoutTests/SlowTests [modify] https://crrev.com/52ab7ec9b6d3531ac11cde6f414ee8b434082a9c/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/52ab7ec9b6d3531ac11cde6f414ee8b434082a9c/third_party/WebKit/LayoutTests/VirtualTestSuites [delete] https://crrev.com/829188c003b9048a6cd1c2bc4a1f4f68c8e940c3/third_party/WebKit/LayoutTests/virtual/pwa-full-code-cache/http/tests/devtools/service-workers/README.txt [delete] https://crrev.com/829188c003b9048a6cd1c2bc4a1f4f68c8e940c3/third_party/WebKit/LayoutTests/virtual/pwa-full-code-cache/http/tests/devtools/service-workers/service-worker-v8-cache-expected.txt |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by adithyas@chromium.org
, May 29 2018Owner: adithyas@chromium.org
Status: Assigned (was: Untriaged)