New issue
Advanced search Search tips

Issue 847360 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Performance Monitor always shows near 0% cpu usage

Reported by dort...@gmail.com, May 29 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Steps to reproduce the problem:
1. Go to https://build-kaisgsucpc.now.sh/?interval=10
2. Open Performance Monitor
3. View the performance monitor graph vs numeric counter

What is the expected behavior?
The performance monitor cpu usage numeric counter should match the cpu usage graph

What went wrong?
At some release after Chrome 65 the numeric counter of CPU usage in "Performance Monitor" stopped working. The graph still displays correct numbers.

Did this work before? Yes Chrome 65

Chrome version: 66.0.3359.181  Channel: stable
OS Version: OS X 10.13.4
Flash Version:
 
Screen Shot 2018-05-29 at 12.53.21 PM.png
393 KB View Download
Owner: alph@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 2 by alph@chromium.org, May 30 2018

Labels: M-68
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74ade5dc7eb14045a6d3d020f328adbda941a96c

commit 74ade5dc7eb14045a6d3d020f328adbda941a96c
Author: Alexei Filippov <alph@chromium.org>
Date: Fri Jun 01 22:16:13 2018

DevTools: Fix performance monitor CPU usage always zero.

BUG= 847360 

Change-Id: I8c61e146e979ec8be364c9b688256ecbbdd43efb
Reviewed-on: https://chromium-review.googlesource.com/1080173
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563827}
[modify] https://crrev.com/74ade5dc7eb14045a6d3d020f328adbda941a96c/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics.js
[modify] https://crrev.com/74ade5dc7eb14045a6d3d020f328adbda941a96c/third_party/blink/renderer/core/inspector/inspector_performance_agent.cc

Comment 4 by alph@chromium.org, Jun 9 2018

Labels: Merge-Request-68
Status: Fixed (was: Assigned)

Comment 5 by alph@chromium.org, Jun 9 2018

Labels: OS-Linux OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Jun 9 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-68 Merge-Approved-68
Approving merge to M68. Branch:3440
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 11 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fdea13607bc65958aa3cbd4165b9609ed58f7da

commit 0fdea13607bc65958aa3cbd4165b9609ed58f7da
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Jun 11 20:48:28 2018

DevTools: Fix performance monitor CPU usage always zero.

BUG= 847360 
TBR=alph@chromium.org

(cherry picked from commit 74ade5dc7eb14045a6d3d020f328adbda941a96c)

Change-Id: I8c61e146e979ec8be364c9b688256ecbbdd43efb
Reviewed-on: https://chromium-review.googlesource.com/1080173
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563827}
Reviewed-on: https://chromium-review.googlesource.com/1096118
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#288}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/0fdea13607bc65958aa3cbd4165b9609ed58f7da/third_party/WebKit/LayoutTests/inspector-protocol/performance/perf-metrics.js
[modify] https://crrev.com/0fdea13607bc65958aa3cbd4165b9609ed58f7da/third_party/blink/renderer/core/inspector/inspector_performance_agent.cc

Labels: TE-Verified-M68 TE-Verified-68.0.3440.25
Able to reproduce this issue on Windows 10, Mac OS 10.13.5 and Ubuntu 14.04 on the reported version 66.0.3359.181 and the issue is fixed on the latest Beta 68.0.3440.25 as per the original comment.
The performance monitor cpu usage numeric counter is matching the cpu usage graph
Attached is the screen shot for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
847360-M68.PNG
121 KB View Download

Sign in to add a comment