Regression : Unwanted vertical scroll bar is seen on 'Edit site' overlay in 'chrome://settings/content/cookies'
Reported by
pranjali...@etouch.net,
May 29 2018
|
||||||||||||||
Issue descriptionChrome version : 69.0.3444.0 (Official Build) 7bc84734b0b2463f749245f34c6eb8aa7aae6b00-refs/branch-heads/3444@{#1}(32/64-bit) OS : Windows(7,8,8.1,10) ,Linux(14.04 LTS) and Mac(10.12.6 , 10.13.1 , 10.13.5) OS Steps to reproduce: 1. Launch chrome and navigate to 'chrome://settings/content/cookies'. 2. click on 'Add' button under 'Block' ,enter site details and click on Add button. 3. Now click on 'More actions' icon of added site and select edit option and observe scrollbar on overlay. Actual Result: Unwanted vertical scroll bar is seen on 'Edit site' overlay in 'chrome://settings/content/cookies' Expected Result: Vertical scroll bar should not be seen on 'Edit site' overlay in 'chrome://settings/content/cookies' This is regression issue, broken in ‘M 68’ and below is the bisect info : Good build: 68.0.3438.0 (Revision: 560884). Bad build: 68.0.3439.0 (Revision: 561388). You are probably looking for a change made after 561364 (known good), but no later than 561365 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/2d085ab3bdfac01d330584c3447ca00f84417811..29bc0a300e670bb159425a47a5ad7bade2cdf386 Suspect : https://chromium.googlesource.com/chromium/src/+/29bc0a300e670bb159425a47a5ad7bade2cdf386 @aee- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You.
,
May 29 2018
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73fd1774fc6f2eab61651b2dba09f935b6df62af commit 73fd1774fc6f2eab61651b2dba09f935b6df62af Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed May 30 01:50:37 2018 Settings: set fixed height for edit dialog body to avoid having a vertical scrollbar Bug: 847352 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic342856a31d3ca48274a3288bea45bf2c2000652 Reviewed-on: https://chromium-review.googlesource.com/1076898 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#562690} [modify] https://crrev.com/73fd1774fc6f2eab61651b2dba09f935b6df62af/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
,
May 30 2018
,
May 30 2018
Can you take a look at the comment at https://chromium-review.googlesource.com/c/chromium/src/+/1076898#message-179f212b715cd895ede73959b5086b7bd0fe61d4 ? I am not 100% sure that the original cause is fully addressed.
,
May 30 2018
Update : Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS with latest Canary build #69.0.3445.0 and the issue is Fixed.Kindly refer the attached screen cast for reference.
,
May 30 2018
Summarizing offline discussions: The issue happens also on startup-url-dialog, with the only difference that the error (which has position: absolute) only exists in the DOM when invalid input exists. See attachment. Suggestion: 1) Revert the original CL (this will make cherry-picking the final fix to M68 easier). 2) Add sufficient bottom padding, to the paper-input (in all relevant dialogs), so that the space necessary to render the absolutely positioned error is reserved, which should eliminate the scrollbars. Eventually when cr-input is used everywhere, the problem would go away, since cr-input's error message is in the flow (not using position: absolute).
,
May 30 2018
,
May 31 2018
,
May 31 2018
Issue 847750 has been merged into this issue.
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a41f8628396e8130d377e99e2c5296141c7a4430 commit a41f8628396e8130d377e99e2c5296141c7a4430 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu May 31 21:53:16 2018 Revert "Settings: set fixed height for edit dialog body to avoid having a vertical scrollbar" This reverts commit 73fd1774fc6f2eab61651b2dba09f935b6df62af. Reason for revert: this fix will be replaced by https://chromium-review.googlesource.com/c/chromium/src/+/1080208 Original change's description: > Settings: set fixed height for edit dialog body to avoid having a vertical scrollbar > > Bug: 847352 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ic342856a31d3ca48274a3288bea45bf2c2000652 > Reviewed-on: https://chromium-review.googlesource.com/1076898 > Reviewed-by: Scott Chen <scottchen@chromium.org> > Commit-Queue: Esmael El-Moslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#562690} TBR=scottchen@chromium.org,aee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 847352 Change-Id: I198978769566a422629f7b70ec807b5f2811d2d3 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1081067 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#563385} [modify] https://crrev.com/a41f8628396e8130d377e99e2c5296141c7a4430/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/681b16bff82f3512c953a2ef044f228bcf2770cb commit 681b16bff82f3512c953a2ef044f228bcf2770cb Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Jun 01 05:17:37 2018 WebUI: cr-dialog, general fix for the body vertical scrollbars with paper-input Bug: 847352 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8dc6f7bba2c5e265e8c60c85bfcdc44bad36e480 Reviewed-on: https://chromium-review.googlesource.com/1080208 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#563541} [modify] https://crrev.com/681b16bff82f3512c953a2ef044f228bcf2770cb/chrome/browser/resources/md_bookmarks/edit_dialog.html [modify] https://crrev.com/681b16bff82f3512c953a2ef044f228bcf2770cb/chrome/browser/resources/md_bookmarks/edit_dialog.js [modify] https://crrev.com/681b16bff82f3512c953a2ef044f228bcf2770cb/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/681b16bff82f3512c953a2ef044f228bcf2770cb/ui/webui/resources/cr_elements/shared_style_css.html
,
Jun 1 2018
,
Jun 1 2018
I would like to merge the CL in comment 13 to M-68.
,
Jun 2 2018
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 4 2018
Approved - branch:3440
,
Jun 4 2018
Issue 847173 has been merged into this issue.
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/170d58acc0dce7680eac7636f1a8d95501c12f1c commit 170d58acc0dce7680eac7636f1a8d95501c12f1c Author: Esmael El-Moslimany <aee@chromium.org> Date: Mon Jun 04 20:04:04 2018 WebUI: cr-dialog, general fix for the body vertical scrollbars with paper-input Bug: 847352 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8dc6f7bba2c5e265e8c60c85bfcdc44bad36e480 Reviewed-on: https://chromium-review.googlesource.com/1080208 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563541}(cherry picked from commit 681b16bff82f3512c953a2ef044f228bcf2770cb) Reviewed-on: https://chromium-review.googlesource.com/1085727 Cr-Commit-Position: refs/branch-heads/3440@{#163} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/170d58acc0dce7680eac7636f1a8d95501c12f1c/chrome/browser/resources/md_bookmarks/edit_dialog.html [modify] https://crrev.com/170d58acc0dce7680eac7636f1a8d95501c12f1c/chrome/browser/resources/md_bookmarks/edit_dialog.js [modify] https://crrev.com/170d58acc0dce7680eac7636f1a8d95501c12f1c/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html [modify] https://crrev.com/170d58acc0dce7680eac7636f1a8d95501c12f1c/ui/webui/resources/cr_elements/shared_style_css.html
,
Jun 5 2018
Update : Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.6) OS with latest build #68.0.3440.15 and the issue is Fixed.Kindly refer the attached screen cast for reference. Thank You... |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dpa...@chromium.org
, May 29 2018