Regression : Unable to cancel audit after clicking on 'Cancel' button in devtools.
Reported by
rp...@etouch.net,
May 29 2018
|
||||||||
Issue descriptionChrome version: 69.0.3444.0 (Official Build) Revision 7bc84734b0b2463f749245f34c6eb8aa7aae6b00-refs/branch-heads/3444@{#1}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.5) What steps will reproduce the problem? 1. Launch chrome,navigate to NTP and open devtools 2. Now go to 'Audits' section and click on 'Customize and control devtools' and then dock devtools window to bottom. 3. Now slightly drag devtools window to bottom (refer screen cast) and click on 'Run Audits' button and then click on 'Cancel' button,observe Actual: Unable to cancel audit after clicking on 'Cancel' button Expected: Should be able to cancel audit after clicking on 'Cancel' button This is regression issue, broken in ‘M 68’ and below is the bisect info : Good build: 68.0.3438.0 (Revision: 560884). Bad build: 68.0.3439.0 (Revision: 561388). You are probably looking for a change made after 561331 (known good), but no later than 561332 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/965042c5f89bb5ff1e776c5a1533b9632e5cd91b..d59f3187f7909c54af5b971d92415461a24faeb5 Suspect : https://chromium.googlesource.com/chromium/src/+/d59f3187f7909c54af5b971d92415461a24faeb5 From the CL above, assigning the issue to the concern owner @phulce- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fce93a6536e0fd46e21ffb5f3635f1e544696ef commit 3fce93a6536e0fd46e21ffb5f3635f1e544696ef Author: Patrick Hulce <phulce@chromium.org> Date: Tue May 29 18:54:54 2018 DevTools: Audits2 use built-in dialog overlay BUG= 845406 , 847350 , 846607 Change-Id: Id3ed220dcaf00cfbed5ba7b02e27412eab09b219 Reviewed-on: https://chromium-review.googlesource.com/1076325 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#562528} [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/Audits2StatusView.js [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css [modify] https://crrev.com/3fce93a6536e0fd46e21ffb5f3635f1e544696ef/third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css
,
May 30 2018
Update : Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS with latest Canary Chrome version : 69.0.3445.0 and the issue is Fixed.Kindly refer the attached screen cast for reference.
,
May 30 2018
,
May 30 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
,
May 31 2018
Seems like we should get this for M68 as well. Can you confirm if this is ready for be merged to M68?
,
May 31 2018
Yes, it's been in Canary and doesn't seem to be any issues. Small and safe fix.
,
May 31 2018
Approved: branch:3440
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65df80761261cdba02aafe8c8f20535ebec0daa1 commit 65df80761261cdba02aafe8c8f20535ebec0daa1 Author: Patrick Hulce <phulce@chromium.org> Date: Thu May 31 20:40:30 2018 DevTools: Audits2 use built-in dialog overlay BUG= 845406 , 847350 , 846607 Change-Id: Id3ed220dcaf00cfbed5ba7b02e27412eab09b219 Reviewed-on: https://chromium-review.googlesource.com/1076325 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562528}(cherry picked from commit 3fce93a6536e0fd46e21ffb5f3635f1e544696ef) Reviewed-on: https://chromium-review.googlesource.com/1081069 Reviewed-by: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#65} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2StartView.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/Audits2StatusView.js [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/audits2Dialog.css [modify] https://crrev.com/65df80761261cdba02aafe8c8f20535ebec0daa1/third_party/blink/renderer/devtools/front_end/audits2/audits2StartView.css
,
Jun 5 2018
Update : Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.6) OS with latest Canary Chrome version : 68.0.3440.15 and the issue is Fixed.Kindly refer the attached screen cast for reference.
,
Jun 5 2018
Correction in comment #10 : Tested the above issue on latest Dev Chrome version : 68.0.3440.15 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by nyerramilli@chromium.org
, May 29 2018Labels: ReleaseBlock-Stable