New issue
Advanced search Search tips

Issue 847348 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Angle compiler parses floats incorrectly if locale is different from en_US

Project Member Reported by rog...@vewd.com, May 29 2018

Issue description

Chrome Version: 69.0.3445.0, locally built content_shell
OS: Linux

What steps will reproduce the problem?
(1) Run: LC_NUMERIC="en_DK.UTF-8" ./content_shell --in-process-gpu --enable-gpu-rasterization --disable-gpu-shader-disk-cache --disable-gpu-program-cache chrome:gpu

What is the expected result?
Text is rendered OK.

What happens instead?
Text is not rendered at all or as blocks.


*Additional information:*
This regressed with https://crbug.com/803034 (https://chromium-review.googlesource.com/937964).

It looks like strtod discards everything after the comma, so 0.25 ends up being 0 for example.

The bug only reproduce if I run with --in-process-gpu since then it will use the locale from the environment, if I run with a separate gpu process it seems that the locale is set up as Angle expects it to.

The disable-*-cache flags is to not accidentally pick up a working cached shader from disk.

While --in-process-gpu is maybe not the most important use case it is afaik used by some Android variants and Angle may be used where the locale is not always as expected.
 
Owner: geoffl...@chromium.org
I think this is a duplicate of  issue angleproject:2493  .
Status: Assigned (was: Untriaged)
Status: Fixed (was: Assigned)

Sign in to add a comment