New issue
Advanced search Search tips

Issue 847336 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Allow mutating navigation requests

Project Member Reported by yhirano@chromium.org, May 29 2018

Issue description

Labels: Hotlist-Interop
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fb5f98ffb279885f80232d46b0b3e2e4dd8a58a

commit 6fb5f98ffb279885f80232d46b0b3e2e4dd8a58a
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed May 30 05:05:52 2018

[Fetch API] Allow creating a request from a navigation request

We've disallowed creating a request with a non-empty RequestInit from
a navigation request, but the spec changed some time ago([1]). This
change follows the spec change: When any of |init|'s member is present
and request's mode is "navigate", then set the mode to "same-origin".

1: https://github.com/whatwg/fetch/pull/377

Bug:  847336 
Change-Id: I9296dba52519c1cbc84b01db6581ae6da8f15ec9
Reviewed-on: https://chromium-review.googlesource.com/1075917
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562739}
[modify] https://crrev.com/6fb5f98ffb279885f80232d46b0b3e2e4dd8a58a/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-reset-attributes.https-expected.txt
[modify] https://crrev.com/6fb5f98ffb279885f80232d46b0b3e2e4dd8a58a/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html
[modify] https://crrev.com/6fb5f98ffb279885f80232d46b0b3e2e4dd8a58a/third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/request-end-to-end-worker.js
[modify] https://crrev.com/6fb5f98ffb279885f80232d46b0b3e2e4dd8a58a/third_party/blink/renderer/core/fetch/request.cc

Status: Fixed (was: Assigned)

Sign in to add a comment