NetS13nServiceWorker: skip ServiceWorkerSubresourceLoader if no fetch handler exists |
||||
Issue descriptionCurrently ServiceWorkerControlleeRequestHandler attaches the subresource loader even if the service worker doesn't have a fetch event handler. As a result, subresource requests launch the service worker and lose the benefit of no fetch optimization. In order to leverage that, we need to propagate fetch existence to a client and choose if requests can be handled by the controller service worker.
,
Jun 8 2018
,
Jun 11 2018
,
Jun 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cd4d80c7b8308b3c2942c832b4a86252f9fc8ce commit 6cd4d80c7b8308b3c2942c832b4a86252f9fc8ce Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Jun 14 02:06:12 2018 S13nSW: Skip service worker when no fetch handler When a controller doesn't have fetch event handlers we should not route requests to ServiceWorkerSubresourceLoader for no fetch optimization. Bypass ServiceWorkerSubresourceLoader when there is no ControllerServiceWorker. This works because ControllerServiceWorker is set only when the controller has fetch event handlers. Bug: 847322 Change-Id: I6e76a415b5b3c9156bce8676a79312c09307595c Reviewed-on: https://chromium-review.googlesource.com/1096584 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567090} [modify] https://crrev.com/6cd4d80c7b8308b3c2942c832b4a86252f9fc8ce/content/renderer/service_worker/service_worker_provider_context.cc [modify] https://crrev.com/6cd4d80c7b8308b3c2942c832b4a86252f9fc8ce/content/renderer/service_worker/service_worker_provider_context_unittest.cc
,
Jun 14 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by falken@chromium.org
, May 29 2018Labels: Proj-Servicification-Canary