Rename confusing names. Details in the doc: https://docs.google.com/document/d/1A458poqQsW8fD-Zur601-eokpxPA6zkUzTiquo2eI9E/edit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e commit d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e Author: Kouhei Ueno <kouhei@chromium.org> Date: Tue May 29 05:23:54 2018 Rename SignedExchangeHeaderParser to SignedExchangeSignatureHeaderField See the below doc for the overall picture: https://docs.google.com/document/d/1A458poqQsW8fD-Zur601-eokpxPA6zkUzTiquo2eI9E/edit Bug: 847315 Change-Id: I36858f1cf273504e003c191d391fc8d9dce58f8f Reviewed-on: https://chromium-review.googlesource.com/1075839 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#562343} [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/BUILD.gn [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/web_package/signed_exchange_handler.cc [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/web_package/signed_exchange_header.cc [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/web_package/signed_exchange_header.h [rename] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/web_package/signed_exchange_signature_header_field.cc [rename] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/web_package/signed_exchange_signature_header_field.h [rename] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/web_package/signed_exchange_signature_header_field_unittest.cc [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/web_package/signed_exchange_signature_verifier.cc [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/test/BUILD.gn [rename] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/test/data/fuzzer_corpus/signed_exchange_signature_header_field_data/1.txt [rename] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/test/data/fuzzer_corpus/signed_exchange_signature_header_field_data/2.txt [rename] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/test/data/fuzzer_corpus/signed_exchange_signature_header_field_data/3.txt [modify] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/test/fuzzer/BUILD.gn [rename] https://crrev.com/d7cb6d11c049963c9c5b5ca39f78a81dff8b8e2e/content/test/fuzzer/signed_exchange_signature_header_field_fuzzer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3419f0d3170b5df2dd656fd09aa39b42f8ed471 commit f3419f0d3170b5df2dd656fd09aa39b42f8ed471 Author: Kouhei Ueno <kouhei@chromium.org> Date: Tue May 29 05:57:28 2018 Rename SignedExchangeHeader to SignedExchangeEnvelope. Previous name SignedExchangeHeader is confusing as it implies the reference to the HTTP headers of the exchange, but it is not. The "application/signed-exchange" format is commonly referred to envelope, so this CL changes it to use the name instead. Overview in the doc: https://docs.google.com/document/d/1A458poqQsW8fD-Zur601-eokpxPA6zkUzTiquo2eI9E/edit Bug: 847315 Change-Id: Ieb8e741af8f599456810910dece77c1e6531b568 Reviewed-on: https://chromium-review.googlesource.com/1075873 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#562348} [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/BUILD.gn [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/devtools/protocol/network_handler.h [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/devtools/render_frame_devtools_agent_host.h [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_devtools_proxy.cc [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_devtools_proxy.h [rename] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_envelope.cc [rename] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_envelope.h [rename] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_envelope_unittest.cc [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_handler.cc [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_handler.h [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_signature_verifier.cc [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_signature_verifier.h [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/test/BUILD.gn [modify] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/test/fuzzer/BUILD.gn [add] https://crrev.com/f3419f0d3170b5df2dd656fd09aa39b42f8ed471/content/test/fuzzer/signed_exchange_envelope_fuzzer.cc [delete] https://crrev.com/deb91bb2d0ef0182334d48b6fc27f5af07034665/content/test/fuzzer/signed_exchange_header_fuzzer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9af34b4853164a8025c9a34cc0aa120203af75d1 commit 9af34b4853164a8025c9a34cc0aa120203af75d1 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Thu Jun 07 07:43:14 2018 Rename variables of SignedExchangeEnvelope This class has been renamed from SignedExchangeHeader, so this patch renames its variables from 'header' to 'envelope' so that they match the class name. Pure refactoring, no behavior change. Bug: 847315 Change-Id: Idfd56e575de3ddadc5a82ae17ef85ebc2c1fafd9 Reviewed-on: https://chromium-review.googlesource.com/1090413 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#565207} [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/devtools/render_frame_devtools_agent_host.cc [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/web_package/signed_exchange_devtools_proxy.cc [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/web_package/signed_exchange_devtools_proxy.h [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/web_package/signed_exchange_envelope_unittest.cc [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/web_package/signed_exchange_handler.cc [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/web_package/signed_exchange_handler.h [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/web_package/signed_exchange_signature_verifier.cc [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/web_package/signed_exchange_signature_verifier.h [modify] https://crrev.com/9af34b4853164a8025c9a34cc0aa120203af75d1/content/browser/web_package/signed_exchange_signature_verifier_unittest.cc
Comment 1 by bugdroid1@chromium.org
, May 29 2018