New issue
Advanced search Search tips

Issue 847307 link

Starred by 3 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Jun 2018
Cc:
thestig@chromium.org
phanindra.mandapaka@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

When printing as PDF, SVGs in multi-page thead/tfoot's only render on their first and last pages respectively

Reported by jcsab...@gmail.com, May 29 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36

Steps to reproduce the problem:
Example HTML: https://gist.github.com/johnsabath/014ab9578809ba37c116f6a4405e1a95

1. (See Example HTML) Create an HTML table and add an SVG element to the tfoot or thead, then add enough tbody rows to cause the table to require multiple pages when exported to a PDF
2. Print the page as a PDF

What is the expected behavior?
The SVGs should render on each page's thead and tfoot.

What went wrong?
In "beta_channel_v67.pdf" the SVG elements in the thead only render on the first page, and SVG elements in the tfoot only render on the last page.

In "stable_channel_v66.pdf" the SVG elements render as expected on all pages.

Did this work before? Yes Version 66.0.3359.181

Chrome version: 66.0.3359.181  Channel: stable
OS Version: OS X 10.12.6
Flash Version:
stable_channel_v66.pdf
62.8 KB Download
beta_channel_v67.pdf
62.5 KB Download

Comment 1 by jcsab...@gmail.com, May 29 2018 

My apologies for the meta information with the problematic chrome version...

Problematic Version:
Chrome version: v67.0.3396.56  Channel: beta

Working Version:
Chrome version: 66.0.3359.181  Channel: stable

Comment 2 by krajshree@chromium.org, May 29 2018

Labels: Needs-Bisect Needs-Triage-M67

Comment 3 by phanindra.mandapaka@chromium.org, May 29 2018

Cc: phanindra.mandapaka@chromium.org
Components: Internals>Printing
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET RegressedIn-67 M-67 Target-67 FoundIn-67 Target-68 FoundIn-69 Target-69 FoundIn-68 hasbisect OS-Linux OS-Windows Pri-1
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce issue on reported chrome version 67.0.3396.56 & on latest chrome 69.0.3443.0 using Windows 10,Ubuntu 14.04 and Mac 10.13.3. Hence providing bisect information below.

Bisect Info:
================
Good build: 67.0.3371.0
Bad build: 67.0.3372.0

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/72b68bc867adc415dcd0ef70ba88ca27fb75ea6e..209644b1c73164f277f6a94e0a37d22ac1daeda2

suspect: 
https://chromium.googlesource.com/chromium/src/+/3a3c78a924a686ed0d3f90d765b00cdd78453e11

 Reviewed-on: https://chromium-review.googlesource.com/923572

@wangxianzhu: Please confirm the issue and help in re-assigning if it is not related to your change.

Thanks!

Comment 4 by gov...@chromium.org, May 29 2018

Cc: thestig@chromium.org
We've Stable build #67.0.3396.62 ready for release this morning. Pls let us know this is indeed a M67 stable blocker. Thank you.

Comment 5 by wangxianzhu@chromium.org, May 29 2018

Components: Blink>Paint
Labels: -M-67 -Target-67 M-68
Let's target this to M-68. Will evaluate if the fix could be a candidate of next M-67 respin.
Project Member

Comment 6 by bugdroid1@chromium.org, May 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ed270af2dfc4dc15c8306978c6774031a0ad1db

commit 4ed270af2dfc4dc15c8306978c6774031a0ad1db
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu May 31 03:19:07 2018

[SPv175+] Fix printing of objects with paint offset translation in repeating table sections

- create fragments for repeating table sections instead of the old
  SPv1 repeating painting path. The old path changes paint offset
  which didn't work for descendants with paint offset translations.

- Let SVG find the proper fragment to paint.

Bug:  847307 
Change-Id: Iae4509885885a784afeed2c34fb932201549d630
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1079454
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563138}
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/printing/avoid-setting-header-offset-on-header-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/printing/avoid-setting-header-offset-on-header-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/printing/thead-tfoot-containing-svg-repeat-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/printing/thead-tfoot-containing-svg-repeat-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/printing/avoid-setting-header-offset-on-header-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/printing/avoid-setting-header-offset-on-header-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/linux/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac-mac10.12/printing/avoid-setting-header-offset-on-header-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/layout_ng_experimental/printing/avoid-setting-header-offset-on-header-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/printing/avoid-setting-header-offset-on-header-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/printing/avoid-setting-header-offset-on-header-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/printing/thead-tfoot-containing-svg-repeat-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/printing/thead-tfoot-containing-svg-repeat-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/printing/avoid-setting-header-offset-on-header-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/mac/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/printing/avoid-setting-header-offset-on-header-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/printing/avoid-setting-header-offset-on-header-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/printing/thead-tfoot-containing-svg-repeat-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/printing/thead-tfoot-containing-svg-repeat-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/printing/avoid-setting-header-offset-on-header-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-expected.txt
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.png
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/platform/win/virtual/layout_ng_experimental/printing/thead-tfoot-containing-svg-repeat-extra-pages-expected.txt
[delete] https://crrev.com/858211c2dfafafdee23d0d0ed8ac09f87ec0ce6d/third_party/WebKit/LayoutTests/printing/avoid-setting-header-offset-on-header-expected.html
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/printing/thead-tfoot-containing-svg-repeat-extra-pages.html
[add] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/WebKit/LayoutTests/printing/thead-tfoot-containing-svg-repeat.html
[modify] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/blink/renderer/core/layout/layout_table_section.cc
[modify] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/blink/renderer/core/paint/adjust_paint_offset_scope.cc
[modify] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/blink/renderer/core/paint/paint_property_tree_builder.h
[modify] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/blink/renderer/core/paint/svg_paint_context.cc
[modify] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/blink/renderer/core/paint/svg_paint_context.h
[modify] https://crrev.com/4ed270af2dfc4dc15c8306978c6774031a0ad1db/third_party/blink/renderer/core/paint/table_section_painter.cc

Comment 8 by wangxianzhu@chromium.org, Jun 5 2018

Labels: Merge-Request-68

Comment 9 by abdulsyed@google.com, Jun 5 2018

Labels: -Merge-Request-68 Merge-Approved-68
Approving merge for M68. Branch:3440

Comment 10 by wangxianzhu@chromium.org, Jun 6 2018

Labels: -Merge-Approved-68 merge-merged-3440
Status: Fixed (was: Assigned)
Merged into 3440 (why no email notifications?)
https://chromium-review.googlesource.com/c/chromium/src/+/1087823
https://chromium-review.googlesource.com/c/chromium/src/+/1087825

Comment 11 by phanindra.mandapaka@chromium.org, Jun 7 2018

Labels: TE-Verified-M68 TE-Verified-68.0.3440.17
Able to reproduce the issue on chrome version  66.0.3359.181 (build without fix)
Verified the fix on Windows 10, Mac 10.13.3 and Ubuntu 14.04 using Chrome version #68.0.3440.17.
Attaching screenshot for reference.
Observed that ""SVGs rendering on each page's thead and tfoot.""
The fix is working as expected, adding Verified labels

Thanks...!
847307.mp4
2.8 MB View Download
►

Sign in to add a comment