New issue
Advanced search Search tips

Issue 847284 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue 841830



Sign in to add a comment

22.3 KiB regression in resource_sizes (MonochromePublic.apk) at 562223:562223

Project Member Reported by huangs@google.com, May 28 2018

Issue description

Caused by “First line of commit message”

Commit: c8a7216a351ff121d661f5fa87b1c0e79fbd3935

Link to size graph: https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ0evarQoM

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on the graph: 22 kB of native code.

It looks like this increase was probably unexpected or might be avoidable.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.

 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 28 2018

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=847284

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e86e8d180548e7036055574d5ca19a61000fc87cf80f29735c903eaa619e2578


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 28 2018

Owner: mlippautz@chromium.org
Status: Assigned (was: Untriaged)
Assigning to mlippautz@chromium.org because this is the only CL in range:
[wrapper-tracing] Dispatch through Trace instead of TraceWrappers

Dispatch through T::Trace instead of T::TraceWrappers for wrapper
tracing.

Bug:  chromium:841830 
Change-Id: Idacc09961d68a5ffedb66b4196097c9a79259c4b
Reviewed-on: https://chromium-review.googlesource.com/1071368
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562223}

Comment 3 by huangs@google.com, May 28 2018

Cc: agrieve@chromium.org
Command to run:
tools/binary_size/diagnose_bloat.py --cloud c8a7216a351ff121d661f5fa87b1c0e79fbd3935

*However*, there's a bug in Supersize making the number not add up (found the cause and will fix tomorrow). Examining the binary shows that many symbols that were previously aliased (i.e., compiled into the same binary) now became independent functions. The many bytes then add up to 22 KiB bloat. Can this be fixed by tweaking templates somehow?
Blocking: 841830
Components: Blink>MemoryAllocator>GarbageCollection
Thanks! We currently have two methods that describe the pointers of an object for Oilpan. This CL merges calls into a single one, so more size is expected. 

Maybe we can tweak templates a bit but the real fix is removing the now obsolete method across the whole code base. I've drafted this in https://chromium-review.googlesource.com/c/chromium/src/+/1074987 but probably need to split it among a few CLs because it touches so many files that merge conflicts are unavoidable without closing the tree.

Will address this bug and run the diagnose bloat script for each of those CLs.
Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3

commit 7ec34252d0c95897b2f2f1c92216639b4cd0ebe3
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 05:01:05 2018

[wrapper-tracing] Remove TraceWrappers from core/svg/

Binary size improvement: -288B

Bug:  chromium:841830 ,  chromium:847284 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Iedc9e6b1a3bc61aff0bb773fe2fdfc46cdece5d8
Reviewed-on: https://chromium-review.googlesource.com/1075834
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562339}
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/properties/svg_animated_property.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/properties/svg_list_property_tear_off_helper.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/properties/svg_property_tear_off.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_angle.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_angle.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_boolean.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_enumeration_base.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_integer.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_integer.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_length.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_length.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_length_list.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_number.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_number.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_number_list.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_preserve_aspect_ratio.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_rect.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_string.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_string.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_animated_transform_list.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_matrix_tear_off.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_matrix_tear_off.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_script_element.cc
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/core/svg/svg_script_element.h
[modify] https://crrev.com/7ec34252d0c95897b2f2f1c92216639b4cd0ebe3/third_party/blink/renderer/platform/bindings/trace_wrapper_base.h

Project Member

Comment 6 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa42974329a179b1986dab4dddc398902f8ef9ba

commit fa42974329a179b1986dab4dddc398902f8ef9ba
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 06:44:09 2018

[wrapper-tracing] Remove TraceWrappers from core/html/

Binary size improvement: -4KiB

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: Ic59ceccaed0f9a9bd2151ea530b7f8eb8bc505f2
Reviewed-on: https://chromium-review.googlesource.com/1075871
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562353}
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/canvas/html_canvas_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_definition.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_reaction_stack.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_registry.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/custom/custom_element_registry.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_anchor_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_anchor_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_link_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_link_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_script_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_script_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_template_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/html_template_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/imports/html_import_tree_root.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/imports/html_import_tree_root.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/imports/html_imports_controller.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/imports/html_imports_controller.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/media/html_media_element.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/media/html_media_element.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/parser/html_document_parser.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/parser/html_document_parser.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track_cue_list.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track_cue_list.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track_list.cc
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/text_track_list.h
[modify] https://crrev.com/fa42974329a179b1986dab4dddc398902f8ef9ba/third_party/blink/renderer/core/html/track/track_list_base.h

Project Member

Comment 7 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf1785109d0dd93694aa33182eda78b18aec77f6

commit bf1785109d0dd93694aa33182eda78b18aec77f6
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 07:44:49 2018

[wrapper-tracing] Remove TraceWrappers from core/css/

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: I9cb741229dd486713834bc2e6e27f3ed88903d89
Reviewed-on: https://chromium-review.googlesource.com/1075882
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562363}
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/css_rule.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/css_rule.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/css_style_sheet.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/css_style_sheet.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/font_face_set_document.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/font_face_set_document.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_engine.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_engine.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_rule_css_style_declaration.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_rule_css_style_declaration.h
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_sheet_collection.cc
[modify] https://crrev.com/bf1785109d0dd93694aa33182eda78b18aec77f6/third_party/blink/renderer/core/css/style_sheet_collection.h

Project Member

Comment 8 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/274beea116d9822b81f94c1113569e9515ee3c52

commit 274beea116d9822b81f94c1113569e9515ee3c52
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 08:01:31 2018

[wrapper-tracing] Remove TraceWrappers from modules/

Binary size improvement: -4KiB

Bug:  chromium:841830 ,  chromium:847284 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I8aebe5179f5710a284ddc4631446a2e3cdbe8786
Reviewed-on: https://chromium-review.googlesource.com/1075868
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562365}
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animation_worklet_global_scope.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animator.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animator.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animator_definition.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/animationworklet/animator_definition.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/csspaint/css_paint_definition.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/csspaint/css_paint_definition.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/csspaint/paint_worklet_global_scope.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/filesystem/local_file_system.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/filesystem/local_file_system.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geo_notifier.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geo_notifier.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geolocation.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geolocation.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geolocation_watchers.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/geolocation_watchers.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/navigator_geolocation.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/geolocation/navigator_geolocation.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/idb_database.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/idb_database.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/idb_observer.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/idb_observer.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/indexed_db_client.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/indexeddb/indexed_db_client.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/locks/lock_manager.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/locks/lock_manager.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/locks/navigator_locks.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/mediasession/media_session.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/mediasession/media_session.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/nfc/navigator_nfc.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/nfc/navigator_nfc.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/nfc/nfc.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/nfc/nfc.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/remoteplayback/availability_callback_wrapper.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/remoteplayback/availability_callback_wrapper.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/remoteplayback/remote_playback.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/remoteplayback/remote_playback.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/serviceworkers/service_worker_container_client.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/vr/vr_display.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/vr/vr_display.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webaudio/audio_worklet_global_scope.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webaudio/audio_worklet_processor_definition.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webaudio/audio_worklet_processor_definition.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl2_rendering_context_base.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_context_group.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_context_group.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_context_object.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_context_object.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_framebuffer.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_framebuffer.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_program.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_program.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_shared_object.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_shared_object.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_transform_feedback.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_transform_feedback.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_vertex_array_object_base.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webgl/webgl_vertex_array_object_base.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webmidi/midi_port.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/webmidi/midi_port.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_canvas_input_provider.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_canvas_input_provider.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_frame_request_callback_collection.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_session.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_session.h
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_webgl_layer.cc
[modify] https://crrev.com/274beea116d9822b81f94c1113569e9515ee3c52/third_party/blink/renderer/modules/xr/xr_webgl_layer.h

Project Member

Comment 9 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b7b0f5f0082df7cd0957f920660ac3266bd431b

commit 3b7b0f5f0082df7cd0957f920660ac3266bd431b
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 09:29:40 2018

[wrapper-tracing] Remove TraceWrappers from core/dom/

Binary size improvement: -4KiB

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: Ic0b4e1ddd8e4104973c45d634b6c37a2db880bcc
Reviewed-on: https://chromium-review.googlesource.com/1075911
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562377}
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-merged-nodes-expected.txt
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-event-listener-expected.txt
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-multiple-retainers-expected.txt
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/attr.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/attr.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/container_node.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/container_node.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/document_parser.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/element.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/element.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/element_rare_data.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/element_rare_data.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/custom_event.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/custom_event.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_listener.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_listener_map.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_listener_map.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_target.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/events/event_target.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/frame_request_callback_collection.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/frame_request_callback_collection.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_observer.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_observer.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_observer_registration.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_observer_registration.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/mutation_record.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_iterator.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_iterator.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_iterator_base.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_iterator_base.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_lists_node_data.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_lists_node_data.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_rare_data.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/node_rare_data.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/scripted_animation_controller.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/scripted_animation_controller.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/scripted_idle_task_controller.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/scripted_idle_task_controller.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/shadow_root.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/shadow_root_v0.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/static_node_list.h
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/tree_walker.cc
[modify] https://crrev.com/3b7b0f5f0082df7cd0957f920660ac3266bd431b/third_party/blink/renderer/core/dom/tree_walker.h

Project Member

Comment 10 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865

commit ba8c3904ecbe2a2b50f6a9c53f0ea97498460865
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 11:45:30 2018

[wrapper-tracing] Remove TraceWrappers from core/{events,frame,script}/

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: I6d10de185826f6147a4477ac95891e0ae62315dd
Reviewed-on: https://chromium-review.googlesource.com/1075954
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562388}
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/error_event.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/error_event.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/pop_state_event.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/pop_state_event.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/promise_rejection_event.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/promise_rejection_event.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/events/registered_event_listener.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/dom_window.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/dom_window.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/local_dom_window.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/local_dom_window.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/navigator.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/frame/navigator.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/html_parser_script_runner.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/html_parser_script_runner.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/modulator.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/modulator_impl_base.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/modulator_impl_base.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_map.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_map.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_pending_script.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_pending_script.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_script.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/module_script.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/pending_script.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/script_loader.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/script_loader.h
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/script_runner.cc
[modify] https://crrev.com/ba8c3904ecbe2a2b50f6a9c53f0ea97498460865/third_party/blink/renderer/core/script/script_runner.h

Project Member

Comment 11 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5474d2f467e8eca77930f52e8bfe4505a9e01431

commit 5474d2f467e8eca77930f52e8bfe4505a9e01431
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 14:40:32 2018

[wrapper-tracing] Remove TraceWrappers leftovers from core/

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: Id3d317c2ce8d3d001aa96fc747b69372d85132d3
Reviewed-on: https://chromium-review.googlesource.com/1075958
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562421}
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/imagebitmap/image_bitmap_factories.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/element_intersection_observer_data.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/element_intersection_observer_data.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer_controller.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/intersection_observer/intersection_observer_delegate.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/layout/custom/css_layout_definition.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/layout/custom/css_layout_definition.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/layout/custom/layout_worklet_global_scope.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/loader/modulescript/module_tree_linker.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/loader/modulescript/module_tree_linker_registry.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/mojo/mojo_watcher.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/mojo/mojo_watcher.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/resize_observer/resize_observer.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/resize_observer/resize_observer.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/testing/death_aware_script_wrappable.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/dom_window_performance.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/dom_window_performance.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance_mark.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance_mark.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance_observer.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/performance_observer.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/window_performance.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/worker_global_scope_performance.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/timing/worker_global_scope_performance.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_animation_frame_provider.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_global_scope.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_global_scope.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_navigator.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_navigator.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worker_or_worklet_global_scope.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worklet_global_scope.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/workers/worklet_global_scope.h
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
[modify] https://crrev.com/5474d2f467e8eca77930f52e8bfe4505a9e01431/third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h

Project Member

Comment 12 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d

commit b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue May 29 14:51:25 2018

[wrapper-tracing] Remove TraceWrappers from bindings/

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: I175b8401dac02efbb93b332a6e916195ab099cb1
Reviewed-on: https://chromium-review.googlesource.com/1075960
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562423}
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.cc
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/script_custom_element_definition.h
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/v8_abstract_event_listener.cc
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/v8_abstract_event_listener.h
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/v8_intersection_observer_delegate.cc
[modify] https://crrev.com/b3ad5caafa95f945c6cd8dcfd24cdb6e0bb4151d/third_party/blink/renderer/bindings/core/v8/v8_intersection_observer_delegate.h

Project Member

Comment 13 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61c4b64e531cb4ed1408029767488c2810733c1e

commit 61c4b64e531cb4ed1408029767488c2810733c1e
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed May 30 03:00:14 2018

[wrapper-tracing] Remove TraceWrappers from platform/{bindings,heap}/

Removes TraceWrappers handling from platform code as all uses now dispatch
through T::Trace.

Binary size improvement: -38KiB

Bug:  chromium:841830 ,  chromium:847284 
Change-Id: Iec82306835828cd8cba7569d8afe33e09250d419
Reviewed-on: https://chromium-review.googlesource.com/1077112
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562709}
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/bindings/core/v8/script_wrappable_marking_visitor_test.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/bindings/core/v8/script_wrappable_visitor_test.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/bindings/core/v8/v8_embedder_graph_builder.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/core/dom/frame_request_callback_collection.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/callback_function_base.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/callback_function_base.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/callback_interface_base.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/callback_interface_base.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/dom_data_store.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/dom_wrapper_world.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/dom_wrapper_world.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable_marking_visitor.h
[delete] https://crrev.com/10cc9570a11e9428b1db8c9acf9108a8198f143e/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable_visitor.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/script_wrappable_visitor_verifier.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/trace_wrapper_base.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/trace_wrapper_member.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/trace_wrapper_v8_reference.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/bindings/trace_wrapper_v8_string.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/blink_gc.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/garbage_collected.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/incremental_marking_test.cc
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/marking_verifier.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/marking_visitor.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/trace_traits.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/heap/visitor.h
[modify] https://crrev.com/61c4b64e531cb4ed1408029767488c2810733c1e/third_party/blink/renderer/platform/supplementable.h

Status: Fixed (was: Assigned)
Should be more than just fixed now. In total, we probably removed ~50KiB after adding 22KiB.

Sign in to add a comment