New issue
Advanced search Search tips

Issue 847283 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in LoadCryptInfo

Project Member Reported by ClusterFuzz, May 28 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5554650674364416

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  LoadCryptInfo
  CPDF_SecurityHandler::LoadDict
  CPDF_SecurityHandler::OnInit
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=479170:479259

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5554650674364416

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, May 28 2018

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, May 28 2018

Labels: Test-Predator-Auto-Owner
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/957480c17682008ae2a14723868fcdcab89b6577 (Allow zero length streams when parsing.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, May 28 2018

Cc: dsinclair@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Probably should ignore negative |nKeyBits| values.
Owner: ----
Status: Untriaged (was: Assigned)
Setting PDF bugs assigned to me back to untriaged so they can get re-assigned as needed.
Owner: hnakashima@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2a15473eb75516d8ce6dc11c9f89a80a5f80c94

commit f2a15473eb75516d8ce6dc11c9f89a80a5f80c94
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Thu Sep 06 20:51:06 2018

Roll src/third_party/pdfium ad370480282d..59d21660a3d9 (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/ad370480282d..59d21660a3d9


git log ad370480282d..59d21660a3d9 --date=short --no-merges --format='%ad %ae %s'
2018-09-06 hnakashima@chromium.org Fix integer overflow in LoadCryptInfo.


Created with:
  gclient setdep -r src/third_party/pdfium@59d21660a3d9

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:847283 
TBR=dsinclair@chromium.org

Change-Id: I29b63f62d289f5c1647d782933bec6ee1b8186ef
Reviewed-on: https://chromium-review.googlesource.com/1211043
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589287}
[modify] https://crrev.com/f2a15473eb75516d8ce6dc11c9f89a80a5f80c94/DEPS

Project Member

Comment 11 by ClusterFuzz, Sep 7

ClusterFuzz has detected this issue as fixed in range 589283:589296.

Detailed report: https://clusterfuzz.com/testcase?key=5554650674364416

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  LoadCryptInfo
  CPDF_SecurityHandler::LoadDict
  CPDF_SecurityHandler::OnInit
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=479170:479259
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=589283:589296

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5554650674364416

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 12 by ClusterFuzz, Sep 7

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5554650674364416 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment