wifi: autotest: pylint warning cleanup && dead test removal |
|||
Issue descriptionTracking bug for warning cleanups after 5/28/2018.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3ab0262efacbbd8752d92ad676bce77538d71a83 commit 3ab0262efacbbd8752d92ad676bce77538d71a83 Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed May 30 08:02:24 2018 network_WiFi_VerifyAttenuator: Fix pylint unused-variable warning Use _ for loop index variable, as pylint knows to ignore it. BUG=chromium:847272 TEST=None Change-Id: I1d065faa17a5ccb9170801562fca350a0c2e0018 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075772 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/3ab0262efacbbd8752d92ad676bce77538d71a83/server/site_tests/network_WiFi_VerifyAttenuator/network_WiFi_VerifyAttenuator.py
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5debd48403173dadaceadecbbde259482ba78d7f commit 5debd48403173dadaceadecbbde259482ba78d7f Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed May 30 08:02:25 2018 network_WiFi_ChannelScanDwellTime: Fix pylint warnings Trivial changes to fix the following pylint output: ************* Module network_WiFi_ChannelScanDwellTime C:164, 0: Line too long (81/80) (line-too-long) W: 35,35: Unused variable 'x' (unused-variable) W:116, 8: Unused variable 'dwell_time' (unused-variable) BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_ChannelScanDwellTime \ --autotest_dir=./ --fast" Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Change-Id: Id46711dee12a8c71ac8b5dc796f28f567f6e2a57 Reviewed-on: https://chromium-review.googlesource.com/1075773 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/5debd48403173dadaceadecbbde259482ba78d7f/server/site_tests/network_WiFi_ChannelScanDwellTime/network_WiFi_ChannelScanDwellTime.py
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4cbe82bb58258a7a553dc4e971f882b72dfac0fd commit 4cbe82bb58258a7a553dc4e971f882b72dfac0fd Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed May 30 08:02:26 2018 network_WiFi_VerifyRouter: Fix pylint warning Use _ for loop index variable, as pylint knows to ignore it. BUG=chromium:847272 TEST=None Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Change-Id: I59162211d2e661f61af932876bdce5b072db057b Reviewed-on: https://chromium-review.googlesource.com/1075774 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/4cbe82bb58258a7a553dc4e971f882b72dfac0fd/server/site_tests/network_WiFi_VerifyRouter/network_WiFi_VerifyRouter.py
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/012f8fbafae3589657ae625b90fb6b2e7e146fa5 commit 012f8fbafae3589657ae625b90fb6b2e7e146fa5 Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed May 30 08:02:26 2018 network_WiFi_DisableEnable: Fix 'unused var' warning The 'with' statement structure in Python is: with expression [as variable]: with-block Note that the 'as variable' part is option, and in this case, causes pylint to crib. Fix it. ************* Module network_WiFi_DisableEnable W: 37,59: Unused variable 'idc' (unused-variable) BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_DisableEnable --autotest_dir=./ --fast" Change-Id: Id9a54c5a312034e685e0716a2011734fa4b82c40 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075775 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/012f8fbafae3589657ae625b90fb6b2e7e146fa5/server/site_tests/network_WiFi_DisableEnable/network_WiFi_DisableEnable.py
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/548e1525ce4e21a62975b1481f7f6ced9e6fb8cc commit 548e1525ce4e21a62975b1481f7f6ced9e6fb8cc Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed May 30 19:50:58 2018 network_WiFiCaps: Fix trivial pylint warning Fix the below with a quick rename: ************* Module network_WiFiCaps W: 36, 8: Redefining built-in 'dir' (redefined-builtin) BUG=chromium:847272 TEST=None. This is a client-side test that for some autotest infra quirk, fails when run locally on a developer machine. `test_that -b eve "${DUT_HOSTNAME}" network_WiFiCaps \ --autotest_dir=./ --fast` gives the following error before and after this change: ERROR: Command <make BINDIR=/usr/local/autotest/deps/iwcap install> failed, rc=127, Command returned non-zero exit status Change-Id: I54b36c32e35ee51b38b71e85ae40ae394ecae76f Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075776 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/548e1525ce4e21a62975b1481f7f6ced9e6fb8cc/client/site_tests/network_WiFiCaps/network_WiFiCaps.py
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d8c4f298bf02270449cbb47f7c788eaf287788dc commit d8c4f298bf02270449cbb47f7c788eaf287788dc Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Jun 03 08:29:53 2018 network_WiFi_DisconnectClearsIP: Fix trivial pylint warning pylint knows to ignore _ as an unused variable, use that for loop indices. BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_ChannelScanDwellTime --autotest_dir=./ --fast" Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Change-Id: Ia9b5c0c2f6888c6d558e34dfe69ebf4f81413e8b Reviewed-on: https://chromium-review.googlesource.com/1075778 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/d8c4f298bf02270449cbb47f7c788eaf287788dc/server/site_tests/network_WiFi_DisconnectClearsIP/network_WiFi_DisconnectClearsIP.py
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/8b6f1b7ed362c3fa3a0072db1b0a16f02444dd1d commit 8b6f1b7ed362c3fa3a0072db1b0a16f02444dd1d Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Jun 03 08:29:53 2018 network_WiFi_LowInitialBitrates: Fix trivial pylint warning The assert_connect_wifi check in this test is sufficient. We don't need to confirm that the client got an IP. Get rid of this meaningless statement. ************* Module network_WiFi_LowInitialBitrates W:103,12: Unused variable 'client_ip' (unused-variable) BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_DisconnectClearsIP \ --autotest_dir=./ --fast` Change-Id: I1a9c5d61337df2ee3f3b5b681be999832d36a8ab Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075779 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/8b6f1b7ed362c3fa3a0072db1b0a16f02444dd1d/server/site_tests/network_WiFi_LowInitialBitrates/network_WiFi_LowInitialBitrates.py
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/96e86fc20e6e3923d17f21a7da35c2c828b29f69 commit 96e86fc20e6e3923d17f21a7da35c2c828b29f69 Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Jun 03 08:29:54 2018 network_WiFi_HiddenRemains: 'import what you use' Fix the following pylint warnings by adding an import. ************* Module network_WiFi_HiddenRemains E: 35,18: Undefined variable 'error' (undefined-variable) E: 41,18: Undefined variable 'error' (undefined-variable) BUG=chromium:847272 TEST=`test_that -b eve "{$DUT_HOSTNAME}" network_WiFi_HiddenRemains \ --autotest_dir=./ --fast` Change-Id: Ie70e158462a212d45c31575ba65a6d67641c4273 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075780 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/96e86fc20e6e3923d17f21a7da35c2c828b29f69/server/site_tests/network_WiFi_HiddenRemains/network_WiFi_HiddenRemains.py
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c96b7db2791150affb4f54b4ce09cc8bd4342b33 commit c96b7db2791150affb4f54b4ce09cc8bd4342b33 Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Jun 03 08:29:54 2018 network_WiFi_ChaosConfigSniffer: Replace mutable argument list with None This fixes: ************* Module network_WiFi_ChaosConfigSniffer W: 19, 4: Dangerous default value [] as argument (dangerous-default-value) From the python docs: (https://docs.python.org/3/tutorial/controlflow.html#default-argument-values) The default value is evaluated only once. This makes a difference when the default is a mutable object such as a list, dictionary, or instances of most classes. A function with a mutable argument accumulates the arguments passed to it on subsequent calls. BUG=chromium:847272 TEST=None, this test doesn't run on my workstation even without the change. Change-Id: I0847fe3ec46b4fb19dda0051b9846263e83d9361 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075781 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/c96b7db2791150affb4f54b4ce09cc8bd4342b33/server/site_tests/network_WiFi_ChaosConfigSniffer/network_WiFi_ChaosConfigSniffer.py
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f501d55158adfe0814a8fc9d544be04403ce5ed5 commit f501d55158adfe0814a8fc9d544be04403ce5ed5 Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Jun 03 08:29:55 2018 network_WiFi_Powersave: 'import what you use' Fix the following pylint warnings by adding an import. ************* Module network_WiFi_Powersave E: 25,18: Undefined variable 'error' (undefined-variable) BUG=chromium:847272 TEST=`test_that -b eve "{$DUT_HOSTNAME}" network_WiFi_Powersave \ --autotest_dir=./ --fast` Change-Id: Id3d627b794afdf1c4d6607bb5fe6c9406475db8a Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075782 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/f501d55158adfe0814a8fc9d544be04403ce5ed5/server/site_tests/network_WiFi_Powersave/network_WiFi_Powersave.py
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e2ce848a3daec3538a48f84bdf64a19196c3e6d6 commit e2ce848a3daec3538a48f84bdf64a19196c3e6d6 Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Jun 03 08:29:56 2018 network_WiFi_CSADisconnect: Fix unused-variable warning Fix the following pylint warnings: ************* Module network_WiFi_CSADisconnect W: 61,28: Unused variable 'elapsed_seconds' (unused-variable) W: 61,21: Unused variable 'state' (unused-variable) W: 50,12: Unused variable 'attempt' (unused-variable) W: 61,12: Unused variable 'success' (unused-variable) BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_CSADisconnect --autotest_dir=./ --fast" Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Change-Id: I408f2e946fe41818691295e8da1b23c2cf2c623e Reviewed-on: https://chromium-review.googlesource.com/1075783 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/e2ce848a3daec3538a48f84bdf64a19196c3e6d6/server/site_tests/network_WiFi_CSADisconnect/network_WiFi_CSADisconnect.py
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/71218a8747c2e7b0ddd84e48924b848138f1dece commit 71218a8747c2e7b0ddd84e48924b848138f1dece Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Jun 03 08:29:56 2018 network_WiFi_SuspendStress: Fix 'bare-except' pylint warning Fix by logging what exception we hit. ************* Module network_WiFi_SuspendStress W: 49, 8: No exception type(s) specified (bare-except) BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_SuspendStress.5HT40 --autotest_dir=./ --fast` Change-Id: If4f88c1dddb88699794265e8c458430090117a64 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075784 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/71218a8747c2e7b0ddd84e48924b848138f1dece/server/site_tests/network_WiFi_SuspendStress/network_WiFi_SuspendStress.py
,
Jun 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1f01bab0a40c0a603933df85d4c501a877176916 commit 1f01bab0a40c0a603933df85d4c501a877176916 Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Jun 03 08:29:57 2018 network_WiFi_SetOptionalDhcpProperties: Fix pylint warnings Fix the following trivial pylint warnings: ************* Module network_WiFi_SetOptionalDhcpProperties C: 67, 0: Line too long (83/80) (line-too-long) W: 34, 8: Unused variable 'dut_src_display_filter' (unused-variable) BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_SetOptionalDhcpProperties --autotest_dir=./ --fast" Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Change-Id: I36d2dedb4823e5cd4eec6ec78a4fc929053ff7d6 Reviewed-on: https://chromium-review.googlesource.com/1075785 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/1f01bab0a40c0a603933df85d4c501a877176916/server/site_tests/network_WiFi_SetOptionalDhcpProperties/network_WiFi_SetOptionalDhcpProperties.py
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7de8f6b9b588d45b0004d153b6f40cdc83168262 commit 7de8f6b9b588d45b0004d153b6f40cdc83168262 Author: Kirtika Ruchandani <kirtika@google.com> Date: Tue Jun 05 00:23:22 2018 network_WiFi_DisconnectReason: Trivial pylint fixes Fix the following pylint warnings: ************* Module network_WiFi_DisconnectReason C: 36, 0: Line too long (81/80) (line-too-long) C: 67, 0: Line too long (83/80) (line-too-long) W: 26, 4: Dangerous default value [] as argument (dangerous-default-value) W: 56,20: Unused variable 'attempt' (unused-variable) BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_DisconnectReason.ap_gone \ --autotest_dir=./ --fast` Change-Id: I2ccd8ed4789831738bbdb52b10e0d5d488d05017 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075777 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/7de8f6b9b588d45b0004d153b6f40cdc83168262/server/site_tests/network_WiFi_DisconnectReason/control.switch_ap [modify] https://crrev.com/7de8f6b9b588d45b0004d153b6f40cdc83168262/server/site_tests/network_WiFi_DisconnectReason/control.ap_send_chan_switch [modify] https://crrev.com/7de8f6b9b588d45b0004d153b6f40cdc83168262/server/site_tests/network_WiFi_DisconnectReason/network_WiFi_DisconnectReason.py
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/87b58e644351ba8ad77584a0754c03f2b8a0389f commit 87b58e644351ba8ad77584a0754c03f2b8a0389f Author: Kirtika Ruchandani <kirtika@google.com> Date: Tue Jun 05 00:23:21 2018 network_WiFi_UpdateRouter: Remove deprecated/useless pragma Not sure what pylint warning this comment was suppressing, it does not do anything today. ************* Module network_WiFi_UpdateRouter I: 57, 0: Pragma "disable-msg" is deprecated, use "disable" instead (deprecated-pragma) BUG=chromium:847272 TEST=`test_that -b eve "${DUT_HOSTNAME}" network_WiFi_UpdateRouter \ --autotest_dir=./ --fast` Change-Id: Ib7cce6813328ce3ce0edbdaee2e6a3e6d30ef976 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1075786 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/87b58e644351ba8ad77584a0754c03f2b8a0389f/server/site_tests/network_WiFi_UpdateRouter/network_WiFi_UpdateRouter.py
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
,
Aug 26
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/17f3a3805d7f8ab0ed07f01fa3cd0fffe97aff40 commit 17f3a3805d7f8ab0ed07f01fa3cd0fffe97aff40 Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed Aug 29 18:15:37 2018 autotest: wifi: Fix 'unused-var' pylint warnings pylint knows how to ignore _ and __ as unused variables. Use those for loop indexes and for return values that are not checked. BUG=chromium:847272 TEST=Run all changed tests on eve: - network_WiFi_Perf.ht40 - network_WiFi_RandomMACAddress - network_WiFi_Regulatory - network_WiFi_RateControl - network_WiFi_RoamOnLowPower is a defunct test (crbug.com/877746) Change-Id: Idf26c2d2fd510728353e347d1ddb0bccb2438ada Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1184361 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Harpreet Grewal <harpreet@chromium.org> [modify] https://crrev.com/17f3a3805d7f8ab0ed07f01fa3cd0fffe97aff40/server/site_tests/network_WiFi_RateControl/network_WiFi_RateControl.py [modify] https://crrev.com/17f3a3805d7f8ab0ed07f01fa3cd0fffe97aff40/server/site_tests/network_WiFi_Regulatory/network_WiFi_Regulatory.py [modify] https://crrev.com/17f3a3805d7f8ab0ed07f01fa3cd0fffe97aff40/server/cros/network/random_mac_address_test_base.py [modify] https://crrev.com/17f3a3805d7f8ab0ed07f01fa3cd0fffe97aff40/client/common_lib/utils.py [modify] https://crrev.com/17f3a3805d7f8ab0ed07f01fa3cd0fffe97aff40/server/cros/network/netperf_runner.py [modify] https://crrev.com/17f3a3805d7f8ab0ed07f01fa3cd0fffe97aff40/server/site_tests/network_WiFi_RoamOnLowPower/network_WiFi_RoamOnLowPower.py
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f798f5e65ef6fe3629abd0de35009faa5c52ed62 commit f798f5e65ef6fe3629abd0de35009faa5c52ed62 Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed Aug 29 18:16:11 2018 utils: Replace mutable list argument with None This fixes the following pylint warning: Dangerous default value [] as argument (dangerous-default-value) Dangerous default value RESTRICTED_SUBNETS (__builtin__.list) as argument (dangerous-default-value) From the python docs: (https://docs.python.org/3/tutorial/controlflow.html#default-argument-values) The default value is evaluated only once. This makes a difference when the default is a mutable object such as a list, dictionary, or instances of most classes. A function with a mutable argument accumulates the arguments passed to it on subsequent calls. BUG=chromium:847272 TEST=None Change-Id: I4c0b954226b5f055fd42fcd5998890fbc61952d0 Reviewed-on: https://chromium-review.googlesource.com/1184363 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/f798f5e65ef6fe3629abd0de35009faa5c52ed62/client/common_lib/utils.py
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/42eabe6ff813573f68ed5f92a68cbb69d935ca19 commit 42eabe6ff813573f68ed5f92a68cbb69d935ca19 Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed Aug 29 18:15:55 2018 utils: Disable wildcard-import pylint warning is_moblab() seems to be the only function this file is using from lsbrelease_utils.py. However, changing its usage to lsbrelease_utils.is_moblab to avoid the wildcard import fails because of how lsbrelease_utils is structured. Disable this pylint warning for now. BUG=chromium:847272 TEST=None needed. Ran ./client/common_lib/utils_unittest.py, checked output is the same before and after this change. Change-Id: I4d1aeab5c9a4d8b2021c2a1845f11279b2b49009 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1188999 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/42eabe6ff813573f68ed5f92a68cbb69d935ca19/client/common_lib/utils.py
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/de83396b9d9778b2b9c5d11538863f5d00a66e24 commit de83396b9d9778b2b9c5d11538863f5d00a66e24 Author: Kirtika Ruchandani <kirtika@google.com> Date: Wed Aug 29 18:15:46 2018 utils: Fix unnecessary-pass pylint warning The purpose of the pass statement is to allow empty blocks where they would otherwise be syntactically invalid. If the block already contains other statements then the pass statement is unnecessary. BUG=chromium:847272 TEST=Ran client/common_lib/utils_unittest.py Change-Id: Icdb590bba6b2c52f3b16db3d9a0be40d6eb5e76c Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1189000 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/de83396b9d9778b2b9c5d11538863f5d00a66e24/client/common_lib/utils.py
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/5c2b4c4012b214a39439f1458b514b29cde47c7d commit 5c2b4c4012b214a39439f1458b514b29cde47c7d Author: Kirtika Ruchandani <kirtika@google.com> Date: Thu Aug 30 16:53:16 2018 utils: Fix trivial pylint warning (multiple-statements) This fixes the noise from: C:1074,29: More than one statement on a single line (multiple-statements) BUG=chromium:847272 TEST=Ran client/common_lib/utils_unittest.py Change-Id: I538558927057e1fde94c84672599a0f445fe59c3 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1189001 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/5c2b4c4012b214a39439f1458b514b29cde47c7d/client/common_lib/utils.py
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2af5b2d050722d88962b2c6d857c478931159cee commit 2af5b2d050722d88962b2c6d857c478931159cee Author: Kirtika Ruchandani <kirtika@google.com> Date: Thu Aug 30 16:53:15 2018 utils: Disable pylint false positive: 'raising-bad-type' pylint has a known bug where it cannot follow control flow so it raises the following warning, even when 'None' will never be raised: E:2759,16: Raising NoneType while only classes or instances are allowed (raising-bad-type) Disable this. BUG=chromium:847272 TEST=Ran client/common_lib/utils_unittest.py Change-Id: I93bfec818f9c9507195734221c8b28743ad2dcdc Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1189462 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/2af5b2d050722d88962b2c6d857c478931159cee/client/common_lib/utils.py
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ebd0a383fde1001b1d0fa1f4227bb336ef2d623d commit ebd0a383fde1001b1d0fa1f4227bb336ef2d623d Author: Kirtika Ruchandani <kirtika@google.com> Date: Fri Aug 31 12:23:00 2018 autotest: wifi: Remove network_WlanHasIP Obsolete test not run in any suite, get rid of it. CQ-DEPEND=CL:1189427 BUG=chromium:847272 TEST=None Change-Id: I84854fd1c58cda789385877b4819db0f2f7050ba Reviewed-on: https://chromium-review.googlesource.com/1189141 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Alex Khouderchah <akhouderchah@chromium.org> [delete] https://crrev.com/3689684cafa43e257b7a064024ee27fd49cc1249/client/site_tests/network_WlanHasIP/network_WlanHasIP.py [delete] https://crrev.com/3689684cafa43e257b7a064024ee27fd49cc1249/client/site_tests/network_WlanHasIP/control
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6ad5e81eaa8419941975144a2b70c89ecb58c55e commit 6ad5e81eaa8419941975144a2b70c89ecb58c55e Author: Kirtika Ruchandani <kirtika@google.com> Date: Fri Aug 31 12:23:00 2018 autotest-tests-shill: Remove network_WlanHasIP Obsolete test not run in any suite, get rid of it. CQ-DEPEND=CL:1189141 BUG=chromium:847272 TEST=None Change-Id: Ibedba2d88607a8b253c3bf95f353981c8aa14675 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1189427 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org> [modify] https://crrev.com/6ad5e81eaa8419941975144a2b70c89ecb58c55e/chromeos-base/autotest-tests-shill/autotest-tests-shill-0.0.1-r3179.ebuild
,
Dec 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/82a18c47ef7edb57d1160922ca6e05f2bc290cc0 commit 82a18c47ef7edb57d1160922ca6e05f2bc290cc0 Author: Kirtika Ruchandani <kirtika@google.com> Date: Sun Dec 02 05:19:15 2018 utils: Fix redefined-builtin pylint warning ************* Module files.client.common_lib.utils W:1083,18: Redefining built-in 'input' (redefined-builtin) W:1719, 4: Redefining built-in 'dict' (redefined-builtin) In one case (hash function), the pylint warning is disabled as usage of the builtin name 'hash' is intentional. BUG=chromium:847272 TEST=None Change-Id: Idf92ff6b72a10f917aa88f3fd9d6e5fc0ea8e466 Signed-off-by: Kirtika Ruchandani <kirtika@google.com> Reviewed-on: https://chromium-review.googlesource.com/1184371 Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org> Tested-by: Kirtika Ruchandani <kirtika@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/82a18c47ef7edb57d1160922ca6e05f2bc290cc0/client/common_lib/utils.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 30 2018