Facebook password

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/188a49e42f794472140da7636f3d779a26955c7b

commit 188a49e42f794472140da7636f3d779a26955c7b
Author: Luna Lu <loonybear@chromium.org>
Date: Tue May 29 17:17:58 2018

client side changes to run a field trial for page load metrics sender

Bug: 847269
Change-Id: I9303c0cb0f770d61b25532b8f32d6b8edcd09731
Reviewed-on: https://chromium-review.googlesource.com/1075555
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562475}
[modify] https://crrev.com/188a49e42f794472140da7636f3d779a26955c7b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
[modify] https://crrev.com/188a49e42f794472140da7636f3d779a26955c7b/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h

We would love to start collect data for this by 68.

We'd like to run finch experiments on alternative page load metrics buffer sender timer (1s(default), 100ms, 10ms). This trial should have no user-visible impact.

Admin>LaunchProcess component is for items associated with the process itself, not for items following the process.

Please CC me to discuss if you have specific questions but we shouldn't be tagging bugs we want to launch with that component.

Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/638c7120232efa9a11b64bc703c0f5b55e5784c8

commit 638c7120232efa9a11b64bc703c0f5b55e5784c8
Author: Luna Lu <loonybear@chromium.org>
Date: Thu May 31 15:27:19 2018

Update fieldtrial_testing_config.json to add an experiment for PageLoadMetricsTimerDelay

Bug: 847269
Change-Id: Iaaf308b473a2f20db769f72ca421a99fe658cb36
Reviewed-on: https://chromium-review.googlesource.com/1079203
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563243}
[modify] https://crrev.com/638c7120232efa9a11b64bc703c0f5b55e5784c8/testing/variations/fieldtrial_testing_config.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8597dad96e12029f5afc4fda445149133a6fc3f9

commit 8597dad96e12029f5afc4fda445149133a6fc3f9
Author: Luna Lu <loonybear@chromium.org>
Date: Thu May 31 15:28:28 2018

client side changes to run a field trial for page load metrics sender

Bug: 847269
Change-Id: I9303c0cb0f770d61b25532b8f32d6b8edcd09731
Reviewed-on: https://chromium-review.googlesource.com/1075555
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562475}(cherry picked from commit 188a49e42f794472140da7636f3d779a26955c7b)
Reviewed-on: https://chromium-review.googlesource.com/1079735
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#60}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/8597dad96e12029f5afc4fda445149133a6fc3f9/chrome/renderer/page_load_metrics/page_timing_metrics_sender.cc
[modify] https://crrev.com/8597dad96e12029f5afc4fda445149133a6fc3f9/chrome/renderer/page_load_metrics/page_timing_metrics_sender.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33cf62003771688ee451fbdc31b3ce53fe79c42f

commit 33cf62003771688ee451fbdc31b3ce53fe79c42f
Author: Luna Lu <loonybear@chromium.org>
Date: Thu May 31 15:29:01 2018

Update fieldtrial_testing_config.json to add an experiment for PageLoadMetricsTimerDelay

Bug: 847269
Change-Id: Iaaf308b473a2f20db769f72ca421a99fe658cb36
Reviewed-on: https://chromium-review.googlesource.com/1079203
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563243}(cherry picked from commit 638c7120232efa9a11b64bc703c0f5b55e5784c8)
Reviewed-on: https://chromium-review.googlesource.com/1079736
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#61}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/33cf62003771688ee451fbdc31b3ce53fe79c42f/testing/variations/fieldtrial_testing_config.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9a4fb2d565aedeadd2692a8a74c7eddedf0ed2a

commit c9a4fb2d565aedeadd2692a8a74c7eddedf0ed2a
Author: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Date: Thu May 31 20:13:58 2018

Revert "Update fieldtrial_testing_config.json to add an experiment for PageLoadMetricsTimerDelay"

This reverts commit 638c7120232efa9a11b64bc703c0f5b55e5784c8.

Reason for revert: Failing  PrerenderBrowserTest.FirstContentfulPaintTimingNoCommit on the bots:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/72339

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/72340

Original change's description:
> Update fieldtrial_testing_config.json to add an experiment for PageLoadMetricsTimerDelay
> 
> Bug: 847269
> Change-Id: Iaaf308b473a2f20db769f72ca421a99fe658cb36
> Reviewed-on: https://chromium-review.googlesource.com/1079203
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
> Commit-Queue: Luna Lu <loonybear@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563243}

TBR=rkaplow@chromium.org,bmcquade@chromium.org,loonybear@chromium.org

Change-Id: Ib1bc2c7a47d69223143eb8e8ebe08c6322e92e2e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 847269
Reviewed-on: https://chromium-review.googlesource.com/1081347
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563362}
[modify] https://crrev.com/c9a4fb2d565aedeadd2692a8a74c7eddedf0ed2a/testing/variations/fieldtrial_testing_config.json

Looks like reducing the timer delay may have exposed a race condition in the test that failed:
PrerenderBrowserTest.FirstContentfulPaintTimingNoCommit

Luna could you try to run this test w/ the field trial active, and see if you can repro the failure?

You can force enable a field trial from the command line by providing the --force-fieldtrials flag, and specify field trial params via the --force-fieldtrial-params flag, as documented here: https://g3doc.corp.google.com/analysis/uma/g3doc/finch/experiment-params.md?cl=head