New issue
Advanced search Search tips

Issue 847264 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Remove native host dependency for reporting.

Project Member Reported by georgesak@chromium.org, May 28 2018

Issue description

Remove native host dependency for reporting.

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de7759448c34d207d1c8f098effc64f8e630e446

commit de7759448c34d207d1c8f098effc64f8e630e446
Author: Georges Khalil <georgesak@chromium.org>
Date: Tue May 29 19:15:47 2018

Remove native host dependency for reporting.

This change adds the necessary reported fields from within Chrome to remove the need for the native host.

BUG=847264

Change-Id: Id7e0489749c7e878c023d698e9f56ea0b2ef4ab9
Reviewed-on: https://chromium-review.googlesource.com/1074498
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562540}
[modify] https://crrev.com/de7759448c34d207d1c8f098effc64f8e630e446/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/de7759448c34d207d1c8f098effc64f8e630e446/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc
[modify] https://crrev.com/de7759448c34d207d1c8f098effc64f8e630e446/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc
[modify] https://crrev.com/de7759448c34d207d1c8f098effc64f8e630e446/components/policy/core/common/cloud/cloud_policy_util.cc
[modify] https://crrev.com/de7759448c34d207d1c8f098effc64f8e630e446/components/policy/core/common/cloud/cloud_policy_util.h

Labels: Merge-Request-68
Requesting this CL to be merged into 68.

It's covered by tests and verified in today's Canary.

It's also safe as it only touches a feature that's not yet released (but we want to send it to trusted testers in 68).

Project Member

Comment 3 by sheriffbot@chromium.org, Jun 2 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 5 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 5 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fd51394eab8a57cc22caef5747fa46e145fb65b

commit 8fd51394eab8a57cc22caef5747fa46e145fb65b
Author: Georges Khalil <georgesak@chromium.org>
Date: Tue Jun 05 17:51:36 2018

Merge "Remove native host dependency for reporting."

Merge the CL into 68.

This change adds the necessary reported fields from within Chrome to remove the need for the native host.

BUG=847264

Change-Id: Id7e0489749c7e878c023d698e9f56ea0b2ef4ab9
Reviewed-on: https://chromium-review.googlesource.com/1074498
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562540}(cherry picked from commit de7759448c34d207d1c8f098effc64f8e630e446)
Reviewed-on: https://chromium-review.googlesource.com/1087429
Cr-Commit-Position: refs/branch-heads/3440@{#188}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/8fd51394eab8a57cc22caef5747fa46e145fb65b/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/8fd51394eab8a57cc22caef5747fa46e145fb65b/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc
[modify] https://crrev.com/8fd51394eab8a57cc22caef5747fa46e145fb65b/chrome/browser/extensions/api/enterprise_reporting_private/enterprise_reporting_private_unittest.cc
[modify] https://crrev.com/8fd51394eab8a57cc22caef5747fa46e145fb65b/components/policy/core/common/cloud/cloud_policy_util.cc
[modify] https://crrev.com/8fd51394eab8a57cc22caef5747fa46e145fb65b/components/policy/core/common/cloud/cloud_policy_util.h

Sign in to add a comment