New issue
Advanced search Search tips

Issue 847258 link

Starred by 1 user
Status: Fixed
Owner:
samans@chromium.org
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[single_thread_proxy.cc(164)] Check failed: task_runner_provider_->IsMainThread()

Project Member Reported by samans@chromium.org, May 28 2018 
Happens on debug builds when viz is enabled.

05-28 14:29:31.590  8962  8962 F DEBUG   : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
05-28 14:29:31.592  8962  8962 F DEBUG   : Abort message: '[FATAL:single_thread_proxy.cc(164)] Check failed: task_runner_provider_->IsMainThread(). 
05-28 14:29:31.592  8962  8962 F DEBUG   : #00 0xd30ab1bd /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libbase.cr.so+0x000cd1bd
05-28 14:29:31.592  8962  8962 F DEBUG   : #01 0xd0819f2d /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libcc.cr.so+0x0014ff2d
05-28 14:29:31.592  8962  8962 F DEBUG   : #02 0xd07f2081 /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libcc.cr.so+0x00128081
05-28 14:29:31.592  8962  8962 F DEBUG   : #03 0xca34666b /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libcontent.cr.so+0x00d
05-28 14:29:31.592  8962  8962 F DEBUG   :     r0 00000000  r1 00002246  r2 00000006  r3 00000008
05-28 14:29:31.592  8962  8962 F DEBUG   :     r4 00002246  r5 00002246  r6 ff860d0c  r7 0000010c
05-28 14:29:31.592  8962  8962 F DEBUG   :     r8 00000000  r9 d312a2e0  sl ff8611c0  fp ff8611bc
05-28 14:29:31.592  8962  8962 F DEBUG   :     ip ff860d65  sp ff860cf8  lr f036cbdf  pc f03665ec  cpsr 20030030
05-28 14:29:31.601  8962  8962 F DEBUG   : 
05-28 14:29:31.601  8962  8962 F DEBUG   : backtrace:
05-28 14:29:31.601  8962  8962 F DEBUG   :     #00 pc 0001a5ec  /system/lib/libc.so (abort+63)
05-28 14:29:31.601  8962  8962 F DEBUG   :     #01 pc 0011c9f5  /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libbase.cr.so (offset 0xad000) (base::debug::BreakDebugger()+20)
05-28 14:29:31.601  8962  8962 F DEBUG   :     #02 pc 000cd3d3  /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libbase.cr.so (offset 0xad000) (logging::LogMessage::~LogMessage()+658)
05-28 14:29:31.601  8962  8962 F DEBUG   :     #03 pc 0014ff2b  /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libcc.cr.so (offset 0xce000) (cc::SingleThreadProxy::SetNeedsAnimate()+62)
05-28 14:29:31.601  8962  8962 F DEBUG   :     #04 pc 00128081  /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libcc.cr.so (offset 0xce000) (cc::LayerTreeHost::SetNeedsAnimate()+10)
05-28 14:29:31.602  8962  8962 F DEBUG   :     #05 pc 00dc5669  /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libcontent.cr.so (offset 0x824000) (content::CompositorImpl::SetNeedsComposite()+36)
05-28 14:29:31.602  8962  8962 F DEBUG   :     #06 pc 009eb8b1  /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/lib/arm/libchrome.cr.so (offset 0x5f2000)
05-28 14:29:31.602  8962  8962 F DEBUG   :     #07 pc 000684eb  /data/app/org.chromium.chrome-LtGG0Qo4brB7YMK6Cf1A2Q==/oat/arm/base.odex (offset 0x52000)
Project Member

Comment 1 by bugdroid1@chromium.org, May 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f823e1ea928226ca175f1cb094620ccc083490d

commit 6f823e1ea928226ca175f1cb094620ccc083490d
Author: Saman Sami <samans@chromium.org>
Date: Mon May 28 19:05:37 2018

viz/android: Fix DCHECK failure in SingleThreadProxy::SetNeedsAnimate

Calling DidSwapBuffers can result in a call into SetNeedsAnimate in
the same call stack. DidSubmitCompositorFrame is in a scope of a
DebugScopedSetImplThread object so calling DidSwapBuffers inside of it
triggers the DCHECK in SetNeedsAnimate that expects us to be on the
main thread, so move the DidSwapBuffers call into
DidReceiveCompositorFrameAck that doesn't have the same problem.
DidReceiveCompositorFrameAck is also a closer signal to DidSwapBuffers
than DidSubmitCompositorFrame is.

Bug:  847258 
Change-Id: Ie02c28e0063022b7f404b91067b7805b8c1efb6b
Reviewed-on: https://chromium-review.googlesource.com/1075669
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562296}
[modify] https://crrev.com/6f823e1ea928226ca175f1cb094620ccc083490d/content/browser/renderer_host/compositor_impl_android.cc

Comment 2 by samans@chromium.org, May 28 2018

Status: Fixed (was: Started)
►

Sign in to add a comment