New issue
Advanced search Search tips

Issue 847250 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Autofill Views] Compensate for rounded corners

Project Member Reported by tmartino@chromium.org, May 28 2018

Issue description

In the new Autofill dropdown, the last footer row needs to include extra height/padding at the bottom equal to the corner radius. Currently we do include some padding at the bottom of the footer, but it's outside the row, so we get some weird effects when we hover over that row.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8adc62353b5e95efa900b74471c5cfbe9f6bc1cb

commit 8adc62353b5e95efa900b74471c5cfbe9f6bc1cb
Author: Tommy Martino <tmartino@chromium.org>
Date: Wed May 30 19:47:33 2018

[Autofill Views] Compensating for rounded corners

The last footer row needs to include extra height/padding at the bottom
equal to the corner radius, to compensate visually for the rounding.
Currently we do include some padding at the bottom of the footer, but
it's outside the row, so we get some weird effects when we hover over
that row.

Screenshots (Googlers only):
https://docs.google.com/presentation/d/18jvoRnneYgYhKYCdf5u1ZN1rMrDPC129rfAej2HxJAk/edit?usp=sharing

Change-Id: I1e3541041f86a89fa8b581755d5588a16b5345c9
Bug:  847250 
Reviewed-on: https://chromium-review.googlesource.com/1075516
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562963}
[modify] https://crrev.com/8adc62353b5e95efa900b74471c5cfbe9f6bc1cb/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/8adc62353b5e95efa900b74471c5cfbe9f6bc1cb/chrome/browser/ui/views/autofill/autofill_popup_view_native_views_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment