SurfaceReference: Simplify ToString format |
||
Issue descriptionviz::SurfaceReference is a pair of surface IDs: parent and child. The ToString method is used for debugging purposes but its format differs from other types in viz/service/surfaces. Output SurfaceReference(%s, %s) where the first string is the parent surface ID and the second is the child surface ID. Also SurfaceManager::RemoveSurfaceReferenceImpl and SurfaceManager::AddSurfaceReferenceImpl should probably take in a SurfaceReference.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/197bb4564686bf80aa27c076a08fb9db14f55db9 commit 197bb4564686bf80aa27c076a08fb9db14f55db9 Author: Andre Kaba <akaba@google.com> Date: Tue May 29 03:22:48 2018 Simplify string format in SurfaceReference::ToString() Reformat the output of SurfaceReference::ToString() to SurfaceReference(%s, %s) and change SurfaceManager::AddSurfaceReferenceImpl and SurfaceManager::RemoveSurfaceReferenceImpl to use SurfaceReference instead of parent_id and child_id BUG: 847248 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I94add1880a46a079299c2776a44805f50d763021 Reviewed-on: https://chromium-review.googlesource.com/1075552 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Andre Kaba <akaba@google.com> Cr-Commit-Position: refs/heads/master@{#562321} [modify] https://crrev.com/197bb4564686bf80aa27c076a08fb9db14f55db9/components/viz/service/surfaces/surface_manager.cc [modify] https://crrev.com/197bb4564686bf80aa27c076a08fb9db14f55db9/components/viz/service/surfaces/surface_manager.h [modify] https://crrev.com/197bb4564686bf80aa27c076a08fb9db14f55db9/components/viz/service/surfaces/surface_reference.cc
,
May 29 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by fsam...@chromium.org
, May 28 2018