New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847233 link

Starred by 7 users
Status: ExternalDependency
Owner:
akihiroota@chromium.org
Cc:
pnangunoori@chromium.org
█ sandeepkumars@chromium.org
█ shreera...@samsung.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature
Team-Accessibility



Sign in to add a comment

Talkback does not announce when form fields are required or invalid

Reported by splinte...@gmail.com, May 28 2018 
Steps to reproduce the problem:
1. enable TalkBack
2. go to https://jsfiddle.net/14z67mvp/1/ 
3. navigate through the form fields
4. submit the form - the first form field (with required attribute) will show an error bubble

What is the expected behavior?
Setting focus to the various fields, TalkBack should announce not just "Edit box", but give information about the state/properties of the form fields ("required", "invalid")

What went wrong?
TalkBack does not convey required or invalid state/properties.

Did this work before? No 

Chrome version: 66.0.3359.158  Channel: stable
OS Version: 6.0.1
Flash Version: 

re-up of https://bugs.chromium.org/p/chromium/issues/detail?id=825146

Comment 1 by splinte...@gmail.com, May 28 2018

testcase847233.html
485 bytes View Download

Comment 2 by sandeepkumars@chromium.org, May 29 2018

Labels: Needs-triage-Mobile

Comment 3 by pnangunoori@chromium.org, May 29 2018

Cc: pnangunoori@chromium.org
Components: UI>Accessibility>Compatibility
Labels: -Type-Bug Triaged-Mobile Type-Feature
This could be a Feature Request and updating the issue accordingly so that the issue gets addressed.

Thanks!

Comment 4 by jamwalla@chromium.org, Sep 21

Cc: sandeepkumars@chromium.org
 Issue 825146  has been merged into this issue.

Comment 5 by jamwalla@chromium.org, Sep 21

Labels: -Pri-2 Pri-3
Status: Available (was: Unconfirmed)
Fields like aria-required and aria-invalid are not announced by talkback. 

<form>
<input required> (required)<br>
<input aria-required="true"> (aria-required="true")<br>
<input aria-invalid="true"> (aria-invalid="true")<br>
<input aria-required="true" aria-invalid="true"> (aria=required="true" aria-invalid="true")<br>
<input type="submit">
</form>

Comment 6 by akihiroota@chromium.org, Nov 5

Owner: akihiroota@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28dfa4c339b1490fddddceb02b0450b9179fadcd

commit 28dfa4c339b1490fddddceb02b0450b9179fadcd
Author: Akihiro Ota <akihiroota@chromium.org>
Date: Fri Nov 09 19:05:39 2018

Set isContentInvalid attribute of NodeAccessibilityInfo

Added functionality to set the isContentInvalid attribute of
NodeAccessibilityInfo, with the larger goal of exposing this
information to TalkBack. Added a test to check the presence of this
attribute in an invalid editText object.

R=dmazzoni@chromium.org

Bug: 847233
Change-Id: Ib5ddc3287d719dce184e57af825df5720be0c5db
Reviewed-on: https://chromium-review.googlesource.com/c/1320219
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606924}
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/app/strings/content_strings.grd
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/browser/accessibility/browser_accessibility_android.h
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatWebContentsAccessibility.java
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopWebContentsAccessibility.java
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/public/android/java/src/org/chromium/content/browser/accessibility/OWebContentsAccessibility.java
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
[modify] https://crrev.com/28dfa4c339b1490fddddceb02b0450b9179fadcd/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java

Comment 8 by akihiroota@chromium.org, Nov 9

Status: Started (was: Assigned)

Comment 9 by dmazz...@chromium.org, Dec 7 

Issue 848454 has been merged into this issue.

Comment 10 by dmazz...@chromium.org, Dec 7

Status: ExternalDependency (was: Started)
Invalid is done.

Required is blocked waiting on Android

Comment 11 by dmazz...@chromium.org, Dec 7

Cc: shreera...@samsung.com
 Issue 477015  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40e904840404ad7119eb68e88d8dea595955fb11

commit 40e904840404ad7119eb68e88d8dea595955fb11
Author: Akihiro Ota <akihiroota@chromium.org>
Date: Fri Jan 11 05:36:03 2019

Revert "Set isContentInvalid attribute of NodeAccessibilityInfo"

This reverts commit 28dfa4c339b1490fddddceb02b0450b9179fadcd.

Reason for revert:

TalkBack reports invalid content on editable elements every time a new character is entered until the content is valid. For example, if entering an email address into a form, TalkBack will report "Invalid input" for every character until the "@" symbol is detected. A future change will be implemented to report invalid content only once, possibly upon element unfocus.

See the following link for the full bug report:

https://bugs.chromium.org/p/chromium/issues/detail?id=920474

Change-Id: Ib8f541212e8ac88f4bc372e95eac53da13b367eb

Original change's description:
> Set isContentInvalid attribute of NodeAccessibilityInfo
>
> Added functionality to set the isContentInvalid attribute of
> NodeAccessibilityInfo, with the larger goal of exposing this
> information to TalkBack. Added a test to check the presence of this
> attribute in an invalid editText object.
>
> R=​dmazzoni@chromium.org
>
> Bug: 847233
> Change-Id: Ib5ddc3287d719dce184e57af825df5720be0c5db
> Reviewed-on: https://chromium-review.googlesource.com/c/1320219
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606924}

TBR=dmazzoni@chromium.org,jcivelli@chromium.org,akihiroota@chromium.org

Change-Id: Ib8f541212e8ac88f4bc372e95eac53da13b367eb
Reviewed-on: https://chromium-review.googlesource.com/c/1406079
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621918}
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/app/strings/content_strings.grd
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/browser/accessibility/browser_accessibility_android.h
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatWebContentsAccessibility.java
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopWebContentsAccessibility.java
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/public/android/java/src/org/chromium/content/browser/accessibility/OWebContentsAccessibility.java
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
[modify] https://crrev.com/40e904840404ad7119eb68e88d8dea595955fb11/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 15

Labels: merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f4128b7bf0aec9e21072a5a9a47989f60798131

commit 2f4128b7bf0aec9e21072a5a9a47989f60798131
Author: Akihiro Ota <akihiroota@chromium.org>
Date: Tue Jan 15 18:48:21 2019

Merge Revert of "Set isContentInvalid" to M72.

Revert "Set isContentInvalid attribute of NodeAccessibilityInfo"

This reverts commit 28dfa4c339b1490fddddceb02b0450b9179fadcd.

Reason for revert:

TalkBack reports invalid content on editable elements every time a new character is entered until the content is valid. For example, if entering an email address into a form, TalkBack will report "Invalid input" for every character until the "@" symbol is detected. A future change will be implemented to report invalid content only once, possibly upon element unfocus.

See the following link for the full bug report:

https://bugs.chromium.org/p/chromium/issues/detail?id=920474

Original change's description:
> Set isContentInvalid attribute of NodeAccessibilityInfo
>
> Added functionality to set the isContentInvalid attribute of
> NodeAccessibilityInfo, with the larger goal of exposing this
> information to TalkBack. Added a test to check the presence of this
> attribute in an invalid editText object.
>
> R=​dmazzoni@chromium.org
>
> Bug: 847233
> Change-Id: Ib5ddc3287d719dce184e57af825df5720be0c5db
> Reviewed-on: https://chromium-review.googlesource.com/c/1320219
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606924}

(cherry picked from commit 40e904840404ad7119eb68e88d8dea595955fb11)

TBR=jcivelli@chromium.org

Change-Id: Iad357ceaa3ceff30da9b1df691eb51afa96ad9b0
Bug: 847233, 920474
Reviewed-on: https://chromium-review.googlesource.com/c/1413053
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#692}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/app/strings/content_strings.grd
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/browser/accessibility/browser_accessibility_android.cc
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/browser/accessibility/browser_accessibility_android.h
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/browser/accessibility/web_contents_accessibility_android.cc
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/public/android/java/src/org/chromium/content/browser/accessibility/KitKatWebContentsAccessibility.java
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopWebContentsAccessibility.java
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/public/android/java/src/org/chromium/content/browser/accessibility/OWebContentsAccessibility.java
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/public/android/java/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityImpl.java
[modify] https://crrev.com/2f4128b7bf0aec9e21072a5a9a47989f60798131/content/public/android/javatests/src/org/chromium/content/browser/accessibility/WebContentsAccessibilityTest.java
Project Member

Comment 14 by cr-audit...@appspot.gserviceaccount.com, Jan 15

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/2f4128b7bf0aec9e21072a5a9a47989f60798131

Commit: 2f4128b7bf0aec9e21072a5a9a47989f60798131
Author: akihiroota@chromium.org
Commiter: dmazzoni@chromium.org
Date: 2019-01-15 18:48:21 +0000 UTC

Merge Revert of "Set isContentInvalid" to M72.

Revert "Set isContentInvalid attribute of NodeAccessibilityInfo"

This reverts commit 28dfa4c339b1490fddddceb02b0450b9179fadcd.

Reason for revert:

TalkBack reports invalid content on editable elements every time a new character is entered until the content is valid. For example, if entering an email address into a form, TalkBack will report "Invalid input" for every character until the "@" symbol is detected. A future change will be implemented to report invalid content only once, possibly upon element unfocus.

See the following link for the full bug report:

https://bugs.chromium.org/p/chromium/issues/detail?id=920474

Original change's description:
> Set isContentInvalid attribute of NodeAccessibilityInfo
>
> Added functionality to set the isContentInvalid attribute of
> NodeAccessibilityInfo, with the larger goal of exposing this
> information to TalkBack. Added a test to check the presence of this
> attribute in an invalid editText object.
>
> R=​dmazzoni@chromium.org
>
> Bug: 847233
> Change-Id: Ib5ddc3287d719dce184e57af825df5720be0c5db
> Reviewed-on: https://chromium-review.googlesource.com/c/1320219
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606924}

(cherry picked from commit 40e904840404ad7119eb68e88d8dea595955fb11)

TBR=jcivelli@chromium.org

Change-Id: Iad357ceaa3ceff30da9b1df691eb51afa96ad9b0
Bug: 847233, 920474
Reviewed-on: https://chromium-review.googlesource.com/c/1413053
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#692}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment