New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847224 link

Starred by 1 user
Status: WontFix
Owner:
█ danielpark@chromium.org
Last visit > 30 days ago
Closed: May 2018
Cc:
huangs@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

31.1 KiB regression in resource_sizes (MonochromePublic.apk) at 561789:561789

Project Member Reported by huangs@google.com, May 28 2018 
Caused by “[NTP Button] Shows IPH on cold start”

Commit: 0c8693cbffee7abfcbc81b490a9eb01f4e893fe2	

Link to size graph: hhttps://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ0eDnoQoM

Debugging size regressions is documented at: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/apk_size_regressions.md#Debugging-Apk-Size-Increase

Based on diagnose_bloat.py: +5.2 kB Java code, +6.3 kB Android resources.

It looks like this increase was probably unexpected or might be avoidable.
Please have a look and either:

Close as “Won't Fix” with a short justification, or
Land a revert / fix-up.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, May 28 2018 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=847224

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=7997785ca8cb0bf1d41418741540ae360b505462fb85ead06040efa8c3e68a9e


Bot(s) for this bug's original alert(s):

Android Builder Perf
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 28 2018 

Assigning to danielpark@chromium.org because this is the only CL in range:
[NTP Button] Shows IPH on cold start

> Displays an IPH on the NTP Button on cold start
> IPH text is based on finch config

Bug: 843639
Change-Id: Ibaf1e085d52d233b3be95b9f16d146fdf74d902c
Reviewed-on: https://chromium-review.googlesource.com/1070414
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561789}

Comment 3 by huangs@google.com, May 28 2018

Status: WontFix (was: Assigned)
Command to run:
tools/binary_size/supersize --cloud 0c8693cbffee7abfcbc81b490a9eb01f4e893fe2

But the 31.1 KiB is from extrapolating added strings to account for translation, so there's nothing much we can do, given that 6 new relatively long strings have been added:

https://chromium-review.googlesource.com/c/chromium/src/+/1070414/11/chrome/android/java/strings/android_chrome_strings.grd

Closing bug.
►

Sign in to add a comment