Issue metadata
Sign in to add a comment
|
Regression : Unnecessary page get auto scrolled after clicking on sync passphrase radio button.
Reported by
pranjali...@etouch.net,
May 28 2018
|
||||||||||||||||||||||||
Issue descriptionChrome version : 68.0.3440.6 (Official Build) Revision 5e39f7c6d67b3ec060c8e152bcbf321cdbaad168-refs/branch-heads/3440@{#10} (32/64-bit) OS : Mac(10.12.6 , 10.13.1 , 10.13.5) ,Windows(7,8,8.1,10) and and Linux(14.04 LTS) OS. Precondition: Sign into chrome with valid credentials. Steps to reproduce: 1. Launch chrome and go to 'chrome://settings/syncSetup'. 2. Now click on 'Encrypt synced data with your own sync passphrase' radio option under Encryption options and observe. Actual Result: Unnecessary page gets auto scrolled after clicking on sync passphrase radio button. Expected Result: Page should not get auto scrolled after clicking on sync passphrase radio button. This is a regression issue broken in ‘M-68’ and will soon update other bisect info. Good build: 68.0.3439.0 Bad build: 68.0.3440.0 You are probably looking for a change made after 561690 (known good), but no later than 561691 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e44b8a89d4d887f6503ade46df6312526fca4ecc..8fd1d095826d4a4e021879166bea4149b11561d2 Suspect: https://chromium.googlesource.com/chromium/src/+/8fd1d095826d4a4e021879166bea4149b11561d2 @hcarmona: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank you.
,
May 29 2018
@hcarmona: Should we revert https://chromium.googlesource.com/chromium/src/+/8fd1d095826d4a4e021879166bea4149b11561d2 ? It seems that it has also caused issue 846596 . Alos is this issue here also addressed by [1]? [1] https://chromium-review.googlesource.com/c/chromium/src/+/1074386
,
May 29 2018
,
May 29 2018
Issue 847361 has been merged into this issue.
,
May 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fba7635322a3be23675c78c01b5eb22b5dfd20cb commit fba7635322a3be23675c78c01b5eb22b5dfd20cb Author: Hector Carmona <hcarmona@chromium.org> Date: Tue May 29 23:59:10 2018 WebUI - Settings: Fix animation regression caused by focus change. Issue was caused by focusing before animation had completed therefore causing the animation to end prematurely. Fix waits until animation is done before focusing back button. Fixed related issue where focus was lost for a11y when navigating back from content settings sub pages. Bug: 846596 , 847186 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id350af115fe6b82c8044872b258ee18abaa9759c Reviewed-on: https://chromium-review.googlesource.com/1074386 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#562659} [modify] https://crrev.com/fba7635322a3be23675c78c01b5eb22b5dfd20cb/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/fba7635322a3be23675c78c01b5eb22b5dfd20cb/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
,
May 30 2018
Update : Rechecked the above issue on Windows(7,8,8.1,10),Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.5) OS with latest Canary build #69.0.3445.0 and the issue is Fixed.Kindly refer the attached screen cast for reference.
,
Jun 1 2018
@hcarmona: Should this be marked as fixed?
,
Jun 1 2018
Marking as dupe of 846596 since it's the same fix. Requested merging the fix, will continue any conversations there to avoid dupe threads.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddb57edea2419a267e743fb8619c8dc63a0fab57 commit ddb57edea2419a267e743fb8619c8dc63a0fab57 Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Jun 01 22:58:13 2018 WebUI - Settings: Fix animation regression caused by focus change. Issue was caused by focusing before animation had completed therefore causing the animation to end prematurely. Fix waits until animation is done before focusing back button. Fixed related issue where focus was lost for a11y when navigating back from content settings sub pages. Bug: 846596 , 847186 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id350af115fe6b82c8044872b258ee18abaa9759c Reviewed-on: https://chromium-review.googlesource.com/1074386 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562659}(cherry picked from commit fba7635322a3be23675c78c01b5eb22b5dfd20cb) Reviewed-on: https://chromium-review.googlesource.com/1083731 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#108} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/ddb57edea2419a267e743fb8619c8dc63a0fab57/chrome/browser/resources/settings/settings_page/settings_animated_pages.js [modify] https://crrev.com/ddb57edea2419a267e743fb8619c8dc63a0fab57/chrome/browser/resources/settings/site_settings_page/site_settings_page.js |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by pranjali...@etouch.net
, May 28 2018