chrome://settings/content/usbDevices doesn't get deleted with Site Settings |
||
Issue descriptionWhat steps will reproduce the problem? (1) Go to https://permission.site/, click USB and select a device (2) Use Clear Browsing Data with all options selected What is the expected result? All data is gone What happens instead? Data for chrome://settings/content/usbDevices doesn't get deleted when clearing browsing data. It should probably be removed with Site Settings
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ccc4fae6f48397e737e3075224688adf133746b commit 9ccc4fae6f48397e737e3075224688adf133746b Author: Christian Dullweber <dullweber@chromium.org> Date: Mon May 28 14:19:55 2018 Add WebUSB settings deletion WebUSB settings are currently not deleted when Site Settings are deleted. As they are similar to content settings, zoom levels and protocol handlers, they should be removed when deleting Site Settings from Clear Browsing Data. This CL implements the deletion of "usb-chooser-data" and fixes a test that should have caught this but failed because usb-chooser-data was the only website setting registered as REQUESTING_ORIGIN_AND_TOP_LEVEL_ORIGIN_SCOPE and this type wasn't covered correctly by the test. Bug: 847183 Change-Id: Iec5208090e89afa1a1e4da488cd37c2d1c55341e Reviewed-on: https://chromium-review.googlesource.com/1075269 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#562257} [modify] https://crrev.com/9ccc4fae6f48397e737e3075224688adf133746b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc [modify] https://crrev.com/9ccc4fae6f48397e737e3075224688adf133746b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
,
May 28 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by dullweber@chromium.org
, May 28 2018Status: Assigned (was: Untriaged)