"MultiProfileFileManagerBrowserTest.BasicDownloads" is flaky |
|||||||
Issue description"MultiProfileFileManagerBrowserTest.BasicDownloads" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyPAsSBUZsYWtlIjFNdWx0aVByb2ZpbGVGaWxlTWFuYWdlckJyb3dzZXJUZXN0LkJhc2ljRG93bmxvYWRzDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 28 2018
[9366:9366:0528/002932.642637:FATAL:chrome_app_list_model_updater.cc(508)] Check failed: chrome_item. #0 0x00000465579c base::debug::StackTrace::StackTrace() #1 0x0000045d56ab logging::LogMessage::~LogMessage() #2 0x0000076d11d7 ChromeAppListModelUpdater::OnItemUpdated() #3 0x0000076c386a AppListClientImpl::OnItemUpdated() #4 0x00000361d610 ash::mojom::AppListClientStubDispatch::Accept() #5 0x000005673576 mojo::InterfaceEndpointClient::HandleValidatedMessage() #6 0x000005673146 mojo::FilterChain::Accept() #7 0x000005674905 mojo::InterfaceEndpointClient::HandleIncomingMessage() #8 0x00000567a5fc mojo::internal::MultiplexRouter::ProcessIncomingMessage() #9 0x000005679a00 mojo::internal::MultiplexRouter::Accept() #10 0x000005673146 mojo::FilterChain::Accept() #11 0x000005671333 mojo::Connector::ReadSingleMessage() #12 0x000005671c61 mojo::Connector::ReadAllAvailableMessages() #13 0x000005671b09 mojo::Connector::OnHandleReadyInternal() #14 0x000002a1b917 mojo::SimpleWatcher::DiscardReadyState() #15 0x000004c85204 mojo::SimpleWatcher::OnHandleReady() #16 0x000004c85711 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #17 0x0000045c1fb5 base::debug::TaskAnnotator::RunTask() #18 0x00000467c9f9 base::internal::IncomingTaskQueue::RunTask() #19 0x0000045dde6b base::MessageLoop::RunTask() #20 0x0000045de1fa base::MessageLoop::DeferOrRunPendingTask() #21 0x0000045de44c base::MessageLoop::DoWork() #22 0x0000046717a9 base::MessagePumpLibevent::Run() #23 0x0000045dd854 base::MessageLoop::Run() #24 0x000004604ca9 base::RunLoop::Run() #25 0x0000014e1d64 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop() #26 0x0000014e1691 file_manager::FileManagerBrowserTestBase::StartTest() #27 0x0000014ded79 file_manager::MultiProfileFileManagerBrowserTest_BasicDownloads_Test::RunTestOnMainThread() #28 0x000004c12077 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #29 0x000004716904 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #30 0x00000471571a ChromeBrowserMainParts::PreMainMessageLoopRun() #31 0x000001b0a45a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #32 0x000002c735c1 content::BrowserMainLoop::PreMainMessageLoopRun() #33 0x0000030e1bc5 content::StartupTaskRunner::RunAllTasksNow() #34 0x000002c72002 content::BrowserMainLoop::CreateStartupTasks() #35 0x000002c75d35 content::BrowserMainRunnerImpl::Initialize() #36 0x000002c6fca5 content::BrowserMain() #37 0x00000455d043 content::RunBrowserProcessMain() #38 0x00000455dfcd content::ContentMainRunnerImpl::Run() #39 0x0000065447dc service_manager::Main() #40 0x00000455c064 content::ContentMain() #41 0x000004c11c30 content::BrowserTestBase::SetUp() #42 0x0000046d0273 InProcessBrowserTest::SetUp() #43 0x000001f8ba2d testing::Test::Run() #44 0x000001f8c650 testing::TestInfo::Run() #45 0x000001f8cb67 testing::TestCase::Run() #46 0x000001f98047 testing::internal::UnitTestImpl::RunAllTests() #47 0x000001f97bbd testing::UnitTest::Run() #48 0x0000046e4d91 base::TestSuite::Run() #49 0x0000045b7115 ChromeTestSuiteRunner::RunTestSuite() #50 0x000004c34a17 content::LaunchTests() #51 0x0000045b75d3 LaunchChromeTests() #52 0x0000045b70ae main #53 0x7f475a918f45 __libc_start_main #54 0x0000005ecfda _start
,
May 28 2018
preceding log: [8120:8120:0528/002929.200480:INFO:file_manager_browsertest_base.cc(641)] FileManagerBrowserTest::StartTest keyboardCopyDownloads [8120:8131:0528/002929.277723:ERROR:service_manager_context.cc(247)] Attempting to run unsupported native service: /b/s/w/ir/out/Release/chrome_renderer.service [8120:8131:0528/002929.277795:ERROR:service_manager_context.cc(247)] Attempting to run unsupported native service: /b/s/w/ir/out/Release/chrome_renderer.service [8120:8120:0528/002929.233161:FATAL:chrome_app_list_model_updater.cc(508)] Check failed: chrome_item.
,
May 28 2018
,
May 28 2018
Disabling: https://chromium-review.googlesource.com/c/chromium/src/+/1075273
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4f629c5446a0e1c899b1e6365842d5262073903 commit a4f629c5446a0e1c899b1e6365842d5262073903 Author: Olga Sharonova <olka@chromium.org> Date: Mon May 28 14:48:42 2018 Disabling MultiProfileFileManagerBrowserTest.BasicDownloads (flaky) Flakily crashes. TBR=fukino@chromium.org Bug: 847154 Change-Id: I57ee4c8c956742f5ce0a23bbe7f7b052f4523d39 Reviewed-on: https://chromium-review.googlesource.com/1075273 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#562262} [modify] https://crrev.com/a4f629c5446a0e1c899b1e6365842d5262073903/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 28 2018
Culprit was r562127, it re-enabled File manager browser tests for Mash browser test, but #7 disabled a test everywhere, not just on Mash. olka@ could you revert your change #7 please, and instead, add the flaking test to the Mash bot filter exclusion list. Add these two lines # https://crbug.com/847154 Flaky on Mash -MultiProfileFileManagerBrowserTest.* to the the testing/buildbot/filters/mash.browser_tests.filter file. Thanks.
,
May 28 2018
I could, but I'm not sure why can't you fix it if you know the culprit?
,
May 28 2018
(For the context of my decision: background of "Viz is not supported" part removal in r562127 was unclear to me, and I had other flakes to take care of.)
,
May 29 2018
> "I could, but I'm not sure why can't you fix it if you know the culprit?" Because it was like bed-time for me :) and I don't submit patches in my sleep. > (For the context of my decision: background of "Viz is not supported" part removal in r562127 was unclear to me, and I had other flakes to take care of.) We all have other things to do, I suppose, but the remedy for Mash seems to be add an exclusion to their bot file, rather than blanket disable everywhere. Now I am awake gain, lemme fix it.
,
May 29 2018
[9366:9366:0528/002932.642637:FATAL:chrome_app_list_model_updater.cc(508)] Check failed: chrome_item. searching crbug.com, issue 843429, and pure coincidence that the test disabled in this issue points out that issue.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61c4822171ec2c851dd714c9d894b8a9a4079a83 commit 61c4822171ec2c851dd714c9d894b8a9a4079a83 Author: Noel Gordon <noel@chromium.org> Date: Tue May 29 04:15:07 2018 Disable MultiProfileFileManagerBrowserTest.* in Mash crrev.com/562127 removed Mash exclusions for these tests. Restore the exclusions since this tests flake on Mash due to issue 843429. Bug: 847154 ,843429 Change-Id: I8e5cdd43592424fb3d2c313606059c139c6c14ea Reviewed-on: https://chromium-review.googlesource.com/1075840 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#562335} [modify] https://crrev.com/61c4822171ec2c851dd714c9d894b8a9a4079a83/testing/buildbot/filters/mash.browser_tests.filter
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc1f8994d3d915c21fa1bac0f733a6657e83ca53 commit fc1f8994d3d915c21fa1bac0f733a6657e83ca53 Author: Noel Gordon <noel@chromium.org> Date: Tue May 29 05:06:15 2018 Re-enable MultiProfileFileManagerBrowserTest.BasicDownloads all bots This test was incorrectly disabled on all bots, but only flaked in the Mash browser test suite (see issue 847154 ). A Mash bot exclusion for these tests was re-added in crrev.com/562335, now re-enable the BasicDownloads test all bots. Bug: 847154 Change-Id: I50ea1e7e3758e931df461b71c6c51965b5b9aa22 Reviewed-on: https://chromium-review.googlesource.com/1075875 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#562340} [modify] https://crrev.com/fc1f8994d3d915c21fa1bac0f733a6657e83ca53/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 29 2018
,
May 29 2018
Thanks for fixing! It was almost bed-time for me as well :)
,
May 29 2018
No worries, enjoy! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by Findit
, May 28 2018