New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847138 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Ripple effect is not seen on 'Customize fonts' arrow icon in chrome://settings.

Reported by rp...@etouch.net, May 28 2018

Issue description

Chrome version: 68.0.3440.6 (Official Build)  Revision	5e39f7c6d67b3ec060c8e152bcbf321cdbaad168-refs/branch-heads/3440@{#10}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.5)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/
2. Now press 'Tab' key to bring focus on 'Customize fonts' arrow icon 
3. Now press and hold 'Space-bar' key from keyboard and observe the ripple effect
 
Actual: Ripple effect is not seen on 'Customize fonts' arrow icon after pressing and holding 'Space-bar' key from keyboard
Expected: Ripple effect should be seen on 'Customize fonts' arrow icon after pressing and holding 'Space-bar' key from keyboard

This is regression issue, broken in ‘M 63’ and below is the bisect info :
Good build: 63.0.3221.0  (Revision: 503309).
Bad build: 63.0.3222.0 (Revision: 503582).

You are probably looking for a change made after 503557 (known good), but no later than 503558 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/43cda23b74991c6b1fc061e11ad7a0d29532c0da..39a1080f56c175f7a6792c205e9cefd5c7c5a804

Suspect : https://chromium.googlesource.com/chromium/src/+/39a1080f56c175f7a6792c205e9cefd5c7c5a804

From the CL above, assigning the issue to the concern owner 

@scottchen- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
 
Actual_video.mp4
267 KB View Download
Expected_video.mp4
294 KB View Download

Comment 1 by dpa...@chromium.org, May 29 2018

Status: WontFix (was: Assigned)
I am not able to reproduce the "expected" behavior. Either way, showing multiple ripples on the same element is not ideal anyway. The described "actual" behavior seems to be a better experience.

Comment 2 by rp...@etouch.net, May 30 2018

With response to comment #1 :
Ripple effect is seen for all the sub-page arrow icon after pressing and holding the 'Space-bar' key from keyboard on chrome://settings page but ripple effect is not seen only for 'Customize fonts' sub-page arrow icon. Kindly refer the attached screen cast for sub-page arrow icon behavior on chrome://settings page.

@dpapad : Could you please take a look at it again.

Thank you.
Sub-pages arrow icon behavior.mp4
834 KB View Download

Sign in to add a comment