New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847136 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Content of page appears to be chopped after maximizing the browser window

Reported by vku...@etouch.net, May 28 2018

Issue description

Chrome Version:68.0.3440.6 (Official Build)Revision 5e39f7c6d67b3ec060c8e152bcbf321cdbaad168-refs/branch-heads/3440@{#10} (32/64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.12.6,10.13.1,10.13.5)

What steps will reproduce the problem?
(1)Launch chrome and resize the browser window from R.H.S 
(2)Click on wrench > cast > right click on icon > click on manage cast devices option.
(3)Switch to "Google cast" tab and click on maximize button, observe the page

Actual: Content of page appears to be chopped after maximizing the browser window (i.e after step 2 &3)

Expected: Content of page should be properly displayed after maximizing the browser window.

This is a regression issue broken in 'M68' and below is the manual bisect info
Good Build: 68.0.3437.0(Revision:560454)
Bad Build:  68.0.3438.0(Revision:560883)

Note:
1.In case of Mac OS X(10.12.6,10.13.1,10.13.5)delay is seen while loading the content of page after resizing the browser window back to original.
2.Issue not seen on Linux (14.04 LTS) OS.
 
Actual_Cast.mp4
449 KB View Download
Expected_Cast.mp4
387 KB View Download

Comment 1 by vku...@etouch.net, May 28 2018

Labels: -OS-Mac Target-69 RegressedIn-68 hasbisect Target-68 FoundIn-68 FoundIn-69
Owner: cbiesin...@chromium.org
Status: Assigned (was: Unconfirmed)
(Unable to narrow down the range using per-revision and old script as the "manage cast devices" page doesn't load in chrome builds,Hence providing the CL)

CL:
https://chromium.googlesource.com/chromium/src/+log/68.0.3437.0..68.0.3438.0?pretty=fuller&n=10000

Suspecting: r560464 ?

@cbiesinger: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Correction: Issue is not seen on Mac OS X(10.12.6,10.13.1,10.13.5) 
Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required.

Comment 3 by mfo...@chromium.org, May 29 2018

Owner: mfo...@chromium.org
This is a layout problem with the Cast setup UI, which is not part of Chrome itself.

We will file a bug against the relevant Google team and close this out.

Comment 4 by mfo...@chromium.org, May 29 2018

Components: -Internals>Cast Internals>Cast>UI Blink>Layout
Owner: cbiesin...@chromium.org
Actually the fact that this is Windows specific and there was a layout change makes me believe that we should take a close look at https://crrev.com/560464 first.

cbiesinger@ can you PTAL?
Owner: ----
My change was specific to LayoutNG, which is not enabled by default.
Cc: mfo...@chromium.org
(mfoltz, see above)
Components: -Internals>Cast>UI -Blink>Layout Blink>Paint
Status: Untriaged (was: Assigned)
Blink>Paint can you PTAL?
Components: -Blink>Paint Internals>Compositing
Owner: sdy@chromium.org
Status: Assigned (was: Untriaged)
https://chromium.googlesource.com/chromium/src/+/a5d0643352de46304b2c8b8deeecdc57edc2d860 "Don't fake surface sizes on Mac." seems plausible.

Otherwise nothing jumped out at me from the 400 odd changes in the regression range. Narrowing this down would be really really helpful. Also, does it still reproduce on Canary?


Comment 9 by sdy@chromium.org, Jun 7 2018

Owner: ----
Status: Untriaged (was: Assigned)
That change only builds on Mac and it shouldn't affect Windows, unfortunately.
Cc: fsam...@chromium.org
+fsamuel, crossing this off the list, I don't think this is surface sync related. Because it looks like the page is still responding to events. If it were some issue with the renderer not getting the correct ID to use, I'd expect the page to stall. Does that sound right?
I'm investigating now to see whether this is surface sync related.
Owner: fsam...@chromium.org
Status: Assigned (was: Untriaged)
Friendly ping to get an update as it is marked as RBS.
Thanks..!

Comment 14 by zmo@chromium.org, Jun 22 2018

Cc: ligim...@chromium.org
fsamuel@chromium.org: any updates on this?

ligi@: is it still possible to do a manual bisect on this to help speeding up resolving the issue?
Labels: -hasbisect -ReleaseBlock-Stable Needs-Bisect
Owner: ----
Status: Unconfirmed (was: Assigned)
Please provide per revision bisect,  non blocker unless we have the right bisects.

nyerramilli@ to make this happen.

Owner: fsam...@chromium.org
Status: Assigned (was: Unconfirmed)
With respect to comment #15.

Using the per-revision bisect providing the bisect results,
GGood Build: 68.0.3437.0(Revision:560454)
Bad Build: 68.0.3438.0(Revision:560883)

You are probably looking for a change made after 560828 (known good), but no later than 560829 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/65421f69a6e0e69991c3d6521f98efa8647b547f..0d7d74584f957455326b334f3476be4720b70353

From the CL above, assigning the issue to the concern owner

@fsamuel: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on:https://chromium-review.googlesource.com/1055470
Labels: -Needs-Bisect hasbisect-per-revision
Labels: ReleaseBlock-Stable
This was fixed a while ago and merged back into M68:

https://chromium-review.googlesource.com/c/chromium/src/+/1099515
Status: Fixed (was: Assigned)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Already merged per #19.

Sign in to add a comment