hterm.Terminal.Tests failing tests |
|||
Issue descriptionI get a bunch of test failures locally: -dimensions fails because of some floating point rounding. -display-img-dimensions -display-img-max-dimensions These issues existed prior to the accessibility changes. I'm happy to fix the first problem but I don't know much about the second two tests.
,
May 29 2018
They fail every time for me. I'm not sure if it's actually a timeout thing in these cases?
,
May 30 2018
they still fail after https://chromium-review.googlesource.com/963901 ?
,
May 31 2018
They seem to :(
display-img-dimensions
assertEQ: hterm_terminal_tests.js:405: 4 !== 5
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/apps/libapps/+/547ea6d049806fda397381072cb40d6427a4ef31 commit 547ea6d049806fda397381072cb40d6427a4ef31 Author: Raymes Khoury <raymes@chromium.org> Date: Tue Jun 12 23:48:04 2018 hterm: Fix floating point rounding error in Terminal.dimensions tests There can apparently be floating point error with the rounding of dimensions on different platforms. Round values in these tests to avoid test failures. Bug: 847122 Change-Id: Ibc03b4351a292d1cbeea13f2dae050ed37438b3d Reviewed-on: https://chromium-review.googlesource.com/1080352 Reviewed-by: Mike Frysinger <vapier@chromium.org> Tested-by: Raymes Khoury <raymes@chromium.org> [modify] https://crrev.com/547ea6d049806fda397381072cb40d6427a4ef31/hterm/js/hterm_terminal_tests.js
,
Aug 24
is this fixed now ?
,
Aug 27
No, the image tests are still failing for me. Also the dimensions test now only seems to pass after I resize the window..
,
Aug 27
hterm.Terminal.Tests
dimensions
assertEQ: hterm_terminal_tests.js:101: 79 !== 80
display-img-dimensions
assertEQ: hterm_terminal_tests.js:512: 4 !== 5
ERROR: FAILED
,
Aug 27
I had a brief look into the dimensions test. It's seemingly related to rounding error in the round trip between creating a terminal with a specific size (80 cols) and then getting the client dimensions of the screen node, which don't exactly correspond. |
|||
►
Sign in to add a comment |
|||
Comment 1 by vapier@chromium.org
, May 28 2018