New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847122 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

hterm.Terminal.Tests failing tests

Project Member Reported by raymes@chromium.org, May 28 2018

Issue description

I get a bunch of test failures locally:
-dimensions fails because of some floating point rounding. 
-display-img-dimensions
-display-img-max-dimensions

These issues existed prior to the accessibility changes. I'm happy to fix the first problem but I don't know much about the second two tests. 
 

Comment 1 by vapier@chromium.org, May 28 2018

do they fail every time? there's a low timeout that can hit a lot. I've posted a CL for it.

Comment 2 by raymes@chromium.org, May 29 2018

They fail every time for me. I'm not sure if it's actually a timeout thing in these cases?

Comment 3 by vapier@chromium.org, May 30 2018

they still fail after https://chromium-review.googlesource.com/963901 ?

Comment 4 by raymes@chromium.org, May 31 2018

They seem to :( 
 display-img-dimensions
    assertEQ: hterm_terminal_tests.js:405: 4 !== 5
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/547ea6d049806fda397381072cb40d6427a4ef31

commit 547ea6d049806fda397381072cb40d6427a4ef31
Author: Raymes Khoury <raymes@chromium.org>
Date: Tue Jun 12 23:48:04 2018

hterm: Fix floating point rounding error in Terminal.dimensions tests

There can apparently be floating point error with the rounding of
dimensions on different platforms. Round values in these tests to
avoid test failures.

Bug: 847122
Change-Id: Ibc03b4351a292d1cbeea13f2dae050ed37438b3d
Reviewed-on: https://chromium-review.googlesource.com/1080352
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Raymes Khoury <raymes@chromium.org>

[modify] https://crrev.com/547ea6d049806fda397381072cb40d6427a4ef31/hterm/js/hterm_terminal_tests.js

Owner: raymes@chromium.org
is this fixed now ?
No, the image tests are still failing for me. Also the dimensions test now only seems to pass after I resize the window..
hterm.Terminal.Tests
  dimensions
    assertEQ: hterm_terminal_tests.js:101: 79 !== 80

 display-img-dimensions
    assertEQ: hterm_terminal_tests.js:512: 4 !== 5
    ERROR: FAILED

Cc: raymes@chromium.org
Owner: ----
I had a brief look into the dimensions test. It's seemingly related to rounding error in the round trip between creating a terminal with a specific size (80 cols) and then getting the client dimensions of the screen node, which don't exactly correspond.

Sign in to add a comment