macviews: Focus ring is not seen on More action '^' and close ('x') button in download bar .
Reported by
shruti.j...@etouch.net,
May 28 2018
|
||||||
Issue descriptionChrome version : 68.0.3440.6 (Official Build) Revision 5e39f7c6d67b3ec060c8e152bcbf321cdbaad168-refs/branch-heads/3440@{#10} (32/64-bit) OS:Mac (10.12.6, 10.13.1, 10.13.5) Pre-Condition:Enable 'Use Views browser windows instead of Cocoa' from chrome://flags. Steps to reproduce: 1.Launch chrome and Download few files. 2.Observe the focus on download bar's More action '^' and close ('x') button. Actual Result:Focus ring is not seen on More action '^' and close ('x') button. Expected Result:Focus ring should be seen on More action '^' and close ('x') button. This is a Non-regression issue seen from ‘M-67’ series(#67.0.3381.0). Note:Issue is MAC Specific only. Kindly review the attached screen-cast . Thank You!
,
May 28 2018
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed. Thank You!
,
May 31 2018
It looks like the view is highlighted as it's focused. What is the expected behavior?
,
Jun 15 2018
MacViews triage: I'll take this - I have been doing other focus ring work.
,
Aug 2
MacViews triage: I'll take this for M70.
,
Aug 2
99% sure this is because of:
ImageButton* CreateVectorImageButton(ButtonListener* listener) {
ImageButton* button = new ImageButton(listener);
button->SetInkDropMode(Button::InkDropMode::ON);
button->set_has_ink_drop_action_on_click(true);
button->SetImageAlignment(ImageButton::ALIGN_CENTER,
ImageButton::ALIGN_MIDDLE);
button->SetFocusPainter(nullptr);
button->SetBorder(CreateEmptyBorder(
LayoutProvider::Get()->GetInsetsMetric(INSETS_VECTOR_IMAGE_BUTTON)));
return button;
}
Will put up a fix on Monday.
,
Aug 6
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad6a740a4670ae50dd2c8226cb9bb4c239682b79 commit ad6a740a4670ae50dd2c8226cb9bb4c239682b79 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Aug 07 19:31:03 2018 views: use focus rings on buttons when the platform does so This change causes all buttons to use focus rings on platforms that use them. Bug: 847121 Change-Id: Ida4fba2004d03d6482fd7c4da6dd3cbb8b13a72b Reviewed-on: https://chromium-review.googlesource.com/1163315 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#581305} [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/frame/app_menu_button.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/page_action/page_action_icon_view.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/page_action/page_action_icon_view.h [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/tabs/new_tab_button.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/tabs/new_tab_button.h [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/tabs/tab_close_button.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/ui/views/accessibility/view_ax_platform_node_delegate_unittest.cc [modify] https://crrev.com/ad6a740a4670ae50dd2c8226cb9bb4c239682b79/ui/views/controls/button/button.cc
,
Aug 7
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by shruti.j...@etouch.net
, May 28 2018