New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 847111 link

Starred by 1 user
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jun 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: The font size in textfield appears smaller than rest of the text on the page

Reported by vineetha...@etouch.net, May 28 2018 
Chrome Version: 69.0.3442.0 (Official Build) Revision 562d9e7e30299e5cf807d4e5f31f271f64b8cd50-refs/branch-heads/3442@{#1}  (64-bit)
OS: Mac(10.12.6, 10.13.1, 10.13.4) OS

What steps will reproduce the problem?
(1) Launch Chrome, navigate to chrome://settings.
(2) Enable 'Show Home button' option and try entering text inside 'Enter custom web address' and observe font size.

Actual Result: The font size of the text appears smaller than the rest of the text on the page.
Expected Result: All the text on the chrome://settings should have uniform font size.

This is regression issue broken in ‘M-69’ and will soon update the bisect info,
 
Thank You!
ActualVideo.mov
1.4 MB View Download

Comment 1 by vineetha...@etouch.net, May 28 2018

Components: UI>Settings Blink>Fonts
Labels: -Type-Bug -Pri-2 hasbisect-per-revision RegressedIn-69 Target-69 FoundIn-69 Pri-1 Type-Bug-Regression
Status: Assigned (was: Unconfirmed)
This is regression issue broken in ‘M-69’ and providing the bisect using per-revision bisect,
Good build: 69.0.3441.0(Revision: 562091)
Bad build : 69.0.3442.0(Revision: 562138)

You are probably looking for a change made after 562102 (known good), but no later than 562103 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b650226722860fdc58100cc8373dafca28a13211..56c075371dba1bbc12dc3f260f7786547b29a651

Suspect: https://chromium.googlesource.com/chromium/src/+/56c075371dba1bbc12dc3f260f7786547b29a651

@scottchen: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:

1. On Windows(7,8,8.1,10) and Linux(14.04) OS the text font size in 'Enter custom web address' doesn't change even after changing the values in Settings > Appearance > 'Font size' drop down.

Thank You!
ExpectedVideo.mov
2.4 MB View Download

Comment 2 by vineetha...@etouch.net, May 28 2018

Owner: scottchen@chromium.org

Comment 3 Deleted

Comment 4 by dpa...@chromium.org, May 29 2018

Labels: Proj-MaterialDesign-Refresh-WebUI

Comment 5 by scottchen@chromium.org, May 31 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1eaa6ab420e272446f41fe9103c5390daf0fdea

commit d1eaa6ab420e272446f41fe9103c5390daf0fdea
Author: Scott Chen <scottchen@chromium.org>
Date: Fri Jun 01 18:37:38 2018

WebUI[MD-refresh]: fix cr-input font-size on Mac

Mac was imposing a 11px font on <input> elements. This CL makes sure it
inherits the font-size from parent instead.

Bug:  847111 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5537aa052bb1da787aa5f35a8499a902bab7fd8a
Reviewed-on: https://chromium-review.googlesource.com/1081178
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563732}
[modify] https://crrev.com/d1eaa6ab420e272446f41fe9103c5390daf0fdea/ui/webui/resources/cr_elements/cr_input/cr_input.html

Comment 7 by scottchen@chromium.org, Jun 4 2018

Status: Fixed (was: Started)

Comment 8 by vineetha...@etouch.net, Jun 5 2018

Labels: TE-Verified-M69 TE-Verified-69.0.3450.0
Update :
Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.6) OS with latest Canary Chrome version #69.0.3450.0 and the issue is fixed.

Kindly refer the attached screen cast.
FixedVideo_Mac.mov
2.8 MB View Download
►

Sign in to add a comment