Stop running keyboard_unittests on Windows build bots. |
||
Issue descriptionCode under ui/keyboard should be used only from Chrome OS, but keyboard_unittests runs on some Windows build bots. We sometimes had test failures only on Windows build bots. Let's stop running keyboard_unittests on them.
,
Jun 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71912fadb9da095af38a9a3bf25b77fb574038a2 commit 71912fadb9da095af38a9a3bf25b77fb574038a2 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Fri Jun 15 08:19:19 2018 Fix condition to include "ui/keyboard/keyboard_resource_util.h" //ui/keyboard is available only on Chrome OS. The code using the module is guarded by the correct conditions, so it has not caused any build error so far. Bug: 847109 Test: trybot Change-Id: I551d78e02d0b17b6d7cf6075e87189173d79844f Reviewed-on: https://chromium-review.googlesource.com/1098575 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567575} [modify] https://crrev.com/71912fadb9da095af38a9a3bf25b77fb574038a2/chrome/common/extensions/chrome_manifest_url_handlers.cc
,
Jun 15 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 12 2018