New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847109 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Stop running keyboard_unittests on Windows build bots.

Project Member Reported by yhanada@chromium.org, May 28 2018

Issue description

Code under ui/keyboard should be used only from Chrome OS, but keyboard_unittests runs on some Windows build bots.
We sometimes had test failures only on Windows build bots. Let's stop running keyboard_unittests on them.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e56d02748c6219d39af71e94be3238dcde35ac7a

commit e56d02748c6219d39af71e94be3238dcde35ac7a
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Tue Jun 12 10:18:08 2018

Build //ui/keyboard/* only on Chrome OS.

Code under ui/keyboard should be used only on Chrome OS.
This CL stop s keyboard_unittests from running on non Chrome OS buildbots.

Bug:  847109 
Test: trybots

Change-Id: I75d8c34d0ba575d45ac7bf981a167b469755ed90
Reviewed-on: https://chromium-review.googlesource.com/1006742
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566375}
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/BUILD.gn
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/chrome/browser/extensions/api/input_ime/input_ime_api.cc
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/chrome/browser/extensions/api/input_ime/input_ime_api.h
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/chrome/browser/ui/views/toolbar/browser_app_menu_button.cc
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/chrome/common/BUILD.gn
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/testing/buildbot/chromium.win.json
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/e56d02748c6219d39af71e94be3238dcde35ac7a/ui/keyboard/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71912fadb9da095af38a9a3bf25b77fb574038a2

commit 71912fadb9da095af38a9a3bf25b77fb574038a2
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Fri Jun 15 08:19:19 2018

Fix condition to include "ui/keyboard/keyboard_resource_util.h"

//ui/keyboard is available only on Chrome OS.
The code using the module is guarded by the correct conditions,
so it has not caused any build error so far.

Bug:  847109 
Test: trybot
Change-Id: I551d78e02d0b17b6d7cf6075e87189173d79844f
Reviewed-on: https://chromium-review.googlesource.com/1098575
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567575}
[modify] https://crrev.com/71912fadb9da095af38a9a3bf25b77fb574038a2/chrome/common/extensions/chrome_manifest_url_handlers.cc

Status: Fixed (was: Started)

Sign in to add a comment