New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847106 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 844647
issue 646404



Sign in to add a comment

"use_libfuzzer=true" causes some test target to fail during runtime

Project Member Reported by mmoroz@chromium.org, May 28 2018

Issue description

Comment 1 by mmoroz@chromium.org, May 28 2018

That particular test is failing because of https://cs.chromium.org/chromium/src/third_party/webrtc_overrides/rtc_base/logging.cc?q=FUZZING+file:%5Esrc/third_party/webrtc_overrides/+package:%5Echromium$&g=0&l=31


// Disable logging when fuzzing, for performance reasons.
// WEBRTC_UNSAFE_FUZZER_MODE is defined by WebRTC's BUILD.gn when
// built with use_libfuzzer or use_drfuzz.
#if defined(WEBRTC_UNSAFE_FUZZER_MODE)
#define WEBRTC_ENABLE_LOGGING false
#else
#define WEBRTC_ENABLE_LOGGING true
#endif

Comment 2 by mmoroz@chromium.org, May 28 2018

Blocking: 646404

Comment 3 by mmoroz@chromium.org, May 28 2018

Owner: mmoroz@chromium.org
Status: Started (was: Untriaged)
I think I have a solution, probably will finish it on Tuesday.


Comment 4 by mmoroz@chromium.org, May 29 2018

Blocking: 844647
Project Member

Comment 5 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b4c02961570955e40d85646feb0865bb79fe661

commit 2b4c02961570955e40d85646feb0865bb79fe661
Author: Max Moroz <mmoroz@chromium.org>
Date: Tue May 29 17:54:14 2018

Make FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION depend on optimize_for_fuzzing GN arg.

Bug:  847106 , 646404 
Change-Id: I869ece467fc4783fa4c9dbb0984e8a146b5d7a7a
Reviewed-on: https://chromium-review.googlesource.com/1074830
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562499}
[modify] https://crrev.com/2b4c02961570955e40d85646feb0865bb79fe661/build/config/compiler/BUILD.gn
[modify] https://crrev.com/2b4c02961570955e40d85646feb0865bb79fe661/build/config/sanitizers/BUILD.gn
[modify] https://crrev.com/2b4c02961570955e40d85646feb0865bb79fe661/build/config/sanitizers/sanitizers.gni

Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/a61fa6ea363ce9eefd1b02aa38ad38ed47b6f52d

commit a61fa6ea363ce9eefd1b02aa38ad38ed47b6f52d
Author: Max Moroz <mmoroz@chromium.org>
Date: Wed May 30 04:28:28 2018

Rely on use_fuzzing_engine && optimize_for_fuzzing to define WEBRTC_UNSAFE_FUZZER_MODE.

Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1074830.

Bug:  chromium:847106 ,  chromium:646404 , chromium:844647
Change-Id: I401d518646e032e24989d343c00c307563e23ddf
Reviewed-on: https://webrtc-review.googlesource.com/79187
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Henrik Lundin <henrik.lundin@webrtc.org>
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23438}
[modify] https://crrev.com/a61fa6ea363ce9eefd1b02aa38ad38ed47b6f52d/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c256b85606bf30beee3e7a00fac38ed7739d9f11

commit c256b85606bf30beee3e7a00fac38ed7739d9f11
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 30 08:39:19 2018

Roll src/third_party/webrtc 183f4d9..700fc84 (3 commits)

https://webrtc.googlesource.com/src.git/+log/183f4d9..700fc84


git log 183f4d9..700fc84 --date=short --no-merges --format='%ad %ae %s'
2018-05-29 buildbot@webrtc.org Roll chromium_revision 577ba36372..9d94097261 (562638:562745)
2018-05-28 mmoroz@chromium.org Rely on use_fuzzing_engine && optimize_for_fuzzing to define WEBRTC_UNSAFE_FUZZER_MODE.
2018-05-29 buildbot@webrtc.org Roll chromium_revision eb7233cee8..577ba36372 (562409:562638)

Created with:
  gclient setdep -r src/third_party/webrtc@700fc84

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:847106,chromium:646404,chromium:844647,chromium:None

TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8d7165af747083d3b3952b81d86d49ab7c347e6e
Reviewed-on: https://chromium-review.googlesource.com/1078073
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562764}
[modify] https://crrev.com/c256b85606bf30beee3e7a00fac38ed7739d9f11/DEPS

Comment 8 by mmoroz@chromium.org, May 30 2018

The test mentioned in c#0 should be good after the changes above. I'll wait a day or so before checking the logs. Will also look for similar failures in other tests.
Status: Fixed (was: Started)
I've inspected the log and couldn't find anything similar.

Sign in to add a comment