Fix unit tests / browser tests for UnifiedSystemTray |
|||
Issue descriptionIn order to flip the flag chrome://flags/#enable-system-tray-unified by default, we have to fix all the unit tests / browser tests that fail with the flag.
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88cb5f7e654aa55e4b6c64d4384d8b6c4b9a91a6 commit 88cb5f7e654aa55e4b6c64d4384d8b6c4b9a91a6 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Jun 01 17:55:06 2018 Fix UnifiedSliderBubbleController for unit tests. This CL makes the following change to UnifiedSliderBubbleController. * Fix wrong DCHECK. * Close widget without animation on dtor. Also, UnifiedSliderBubbleController unit tests will be added later. TEST=PowerButtonControllerTest (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I3b8d238094a5bb9b0915bd461de3c43b01820b2c Reviewed-on: https://chromium-review.googlesource.com/1082137 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#563711} [modify] https://crrev.com/88cb5f7e654aa55e4b6c64d4384d8b6c4b9a91a6/ash/system/unified/unified_slider_bubble_controller.cc
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf926e95dec30adfb13612fe161d1df955679e9d commit cf926e95dec30adfb13612fe161d1df955679e9d Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Jun 01 17:57:23 2018 Disable tests unrelated to UnifiedSystemTray. This CL disables unit tests that are testing the features that are just removed in UnifiedSystemTray. These tests crashed/failed when UnifiedSystemTray was enabled. Other crashing tests that are not removed require nontrivial fixes. TEST=ash_unittests --enable-features=SystemTrayUnified BUG= 847104 Change-Id: I9a47c731d60c3fe6245696afe3437aedb4db8c27 Reviewed-on: https://chromium-review.googlesource.com/1082135 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#563715} [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/enterprise/tray_enterprise_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/message_center/notification_tray_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/network/tray_network_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/night_light/tray_night_light_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/rotation/tray_rotation_lock_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/screen_security/screen_tray_item_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/session/tray_session_length_limit_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/supervised/tray_supervised_user_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/tray/system_tray_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/tray_accessibility_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/tray_caps_lock_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/tray_tracing_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/update/tray_update_unittest.cc [modify] https://crrev.com/cf926e95dec30adfb13612fe161d1df955679e9d/ash/system/user/tray_user_unittest.cc
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dec41df0ef3a8ad85feb685d90b2e74e8285095 commit 6dec41df0ef3a8ad85feb685d90b2e74e8285095 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 05 02:21:40 2018 Fix lock/login screen tabbing tests for UnifiedSystemTray. This CL fixes LockScreenSanityTest and LoginShelfViewTest when UnifiedSystemTray is enabled. In these cases, reference to SystemTray is not actually necessary for the tests. TEST=ash_unittests (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I0239568b4114ede67fc5a66bc2dc68a5113a1478 Reviewed-on: https://chromium-review.googlesource.com/1084398 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564349} [modify] https://crrev.com/6dec41df0ef3a8ad85feb685d90b2e74e8285095/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/6dec41df0ef3a8ad85feb685d90b2e74e8285095/ash/shelf/login_shelf_view_unittest.cc
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7caf0adb7e1d935f5730293047e593b2c20073c8 commit 7caf0adb7e1d935f5730293047e593b2c20073c8 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 05 02:37:47 2018 Fix StatusAreaWidgetTest for UnifiedSystemTray. This CL fixes StatusAreaWidgetTest crash. TEST=StatusAreaWidgetTest.Basics (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: If26ae246b348df68eeec9f32fd4042b1fb3934c7 Reviewed-on: https://chromium-review.googlesource.com/1084394 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564351} [modify] https://crrev.com/7caf0adb7e1d935f5730293047e593b2c20073c8/ash/system/status_area_widget_unittest.cc
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e66150e62b4c2d80a8f3fbe630a2990ff841b27e commit e66150e62b4c2d80a8f3fbe630a2990ff841b27e Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 05 05:34:27 2018 Fix ShelfLayoutManagerTest for UnifiedSystemTray. This CL fixes ShelfLayoutManagerTest when UnifiedSystemTray is enabled. Some tests also need https://crrev.com/c/1082140 and https://crrev.com/c/1084367 to run properly. TEST=ShelfLayoutManagerTest (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: If146b0e97a00fc78b73b5894041300fa84ebb2d3 Reviewed-on: https://chromium-review.googlesource.com/1084393 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#564366} [modify] https://crrev.com/e66150e62b4c2d80a8f3fbe630a2990ff841b27e/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/e66150e62b4c2d80a8f3fbe630a2990ff841b27e/ash/system/unified/unified_system_tray.h [modify] https://crrev.com/e66150e62b4c2d80a8f3fbe630a2990ff841b27e/ash/test/ash_test_base.cc [modify] https://crrev.com/e66150e62b4c2d80a8f3fbe630a2990ff841b27e/ash/test/ash_test_base.h
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1692852361d96186c3c508e81daa54863b9ce56 commit b1692852361d96186c3c508e81daa54863b9ce56 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 05 05:46:08 2018 Fix LoginScreenControllerTest for UnifiedSystemTray This CL fixes LoginScreenControllerTest crash with UnifiedSystemTray. TEST=LoginScreenControllerTest (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I0d4a9626bff8fecb87b9c6256eb7c016a420b3a6 Reviewed-on: https://chromium-review.googlesource.com/1084397 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564368} [modify] https://crrev.com/b1692852361d96186c3c508e81daa54863b9ce56/ash/login/login_screen_controller_unittest.cc
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f4f09f45c6c8c1e074c2efefd74ba2355dee83a commit 0f4f09f45c6c8c1e074c2efefd74ba2355dee83a Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 05 05:46:48 2018 Fix arc unit test for UnifiedSystemTray This CL fixes ArcNotificationContentViewTest crash when UnifiedSystemTray is enabled. UnifiedSystemTray replaces NotificationTray and SystemTray, so old NotificationTray instance does not exist when the flag is enabled. TEST=ArcNotificationContentViewTest.CloseButtonInMessageCenterView (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I36dbafead335e93b434bfffc07635df4bd08f6cf Reviewed-on: https://chromium-review.googlesource.com/1084411 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#564369} [modify] https://crrev.com/0f4f09f45c6c8c1e074c2efefd74ba2355dee83a/ash/system/message_center/arc/arc_notification_content_view_unittest.cc
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/add98ee1f533b4228712de0a435ebcc10a3f8810 commit add98ee1f533b4228712de0a435ebcc10a3f8810 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 05 05:52:55 2018 Fix WindowSelectorTest for UnifiedSystemTray. This CL fixes WindowSelectorTest crash when UnifiedSystemTray is enabled (--enable-features=SystemTrayUnified). UnifiedSystemTray will replace old SystemTray. TEST=WindowSelectorTest.ShowTextFilterMenu BUG= 847104 Change-Id: Ic893c83887beac01e191399c181ce5a87514dde3 Reviewed-on: https://chromium-review.googlesource.com/1084416 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564371} [modify] https://crrev.com/add98ee1f533b4228712de0a435ebcc10a3f8810/ash/wm/overview/window_selector_unittest.cc
,
Jun 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9cf9d3ccf3b0a4e3ef54f6dbc4e41e229c85157 commit e9cf9d3ccf3b0a4e3ef54f6dbc4e41e229c85157 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 05 06:00:21 2018 Fix ExtendedDesktopTest for UnifiedSystemTray. This CL fixes ExtendedDesktopTest crash on --enable-features= SystemTrayUnified. TEST=ExtendedDesktopTest.OpenSystemTray BUG= 847104 Change-Id: Ic8f814bf726171dfbd3b325251e03a069a30a2e0 Reviewed-on: https://chromium-review.googlesource.com/1084401 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#564373} [modify] https://crrev.com/e9cf9d3ccf3b0a4e3ef54f6dbc4e41e229c85157/ash/extended_desktop_unittest.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b11ce870921e1483cac76e0292fa1e646e12f2ef commit b11ce870921e1483cac76e0292fa1e646e12f2ef Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 00:04:43 2018 Close UnifiedSystemTray bubble immediately on dtor When Chrome OS is shutdown while UnifiedSystemTray is opened, it crashes, because UnifiedSystemTray bubble did not close immediately and kept reference to UnifiedSystemTrayModel during close animation. It can be problematic in some unit tests including TrayEventFilterTest. TEST=TrayEventFilterTest BUG= 847104 Change-Id: Ia6175b8663acd19d8e5e0b2f31e38e1d3ba565c6 Reviewed-on: https://chromium-review.googlesource.com/1084367 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564711} [modify] https://crrev.com/b11ce870921e1483cac76e0292fa1e646e12f2ef/ash/system/unified/unified_system_tray.cc [modify] https://crrev.com/b11ce870921e1483cac76e0292fa1e646e12f2ef/ash/system/unified/unified_system_tray.h [modify] https://crrev.com/b11ce870921e1483cac76e0292fa1e646e12f2ef/ash/system/unified/unified_system_tray_bubble.cc [modify] https://crrev.com/b11ce870921e1483cac76e0292fa1e646e12f2ef/ash/system/unified/unified_system_tray_bubble.h
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c6c00c5435e580d3ba4e84a0197413c44b131b8 commit 3c6c00c5435e580d3ba4e84a0197413c44b131b8 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 00:06:06 2018 Fix TrayEventFilterTest for UnifiedSystemTray. This CL fixes TrayEventFilterTest crash when SystemTrayUnified is enabled. This CL makes following changes: * Fix TrayEventFilterTest to use UnifiedSystemTray instance when the flag is true. * Fix vpn/network feature pod buttons not to observe NetworkHandler when it doesn't exist. It's cumbersome to mock NetworkHandler for all unit tests, and old SystemTray did the same. Also NetworkHandler will be refactored soon. TEST=TrayEventFilterTest (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I2b9b281d182d9fbbbf159e9374c53adb29a1c756 Reviewed-on: https://chromium-review.googlesource.com/1082140 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564714} [modify] https://crrev.com/3c6c00c5435e580d3ba4e84a0197413c44b131b8/ash/system/network/network_feature_pod_button.cc [modify] https://crrev.com/3c6c00c5435e580d3ba4e84a0197413c44b131b8/ash/system/network/vpn_feature_pod_controller.cc [modify] https://crrev.com/3c6c00c5435e580d3ba4e84a0197413c44b131b8/ash/system/tray/tray_event_filter_unittest.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/68be16570dd80fc92a76b00a204ddf6f4100c578 commit 68be16570dd80fc92a76b00a204ddf6f4100c578 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 00:07:13 2018 Disable remaining tests unrelated to UnifiedSystemTray. This CL disables unit tests that are testing the features that are just removed in UnifiedSystemTray. These tests crashed/failed when UnifiedSystemTray was enabled. TEST=ash_unittests --enable-features=SystemTrayUnified BUG= 847104 Change-Id: I7a8b9b0723737fc03a048d41be2f23b1e73dd8a7 Reviewed-on: https://chromium-review.googlesource.com/1086813 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564716} [modify] https://crrev.com/68be16570dd80fc92a76b00a204ddf6f4100c578/ash/system/media_security/multi_profile_media_tray_item_unittest.cc [modify] https://crrev.com/68be16570dd80fc92a76b00a204ddf6f4100c578/ash/system/tray/tray_detailed_view_unittest.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1764a0dc7928ab6fb83201bf457ac72a976282c6 commit 1764a0dc7928ab6fb83201bf457ac72a976282c6 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 00:08:20 2018 Fix Mash compatible SystemTray browser tests. This CL fixes browser tests when UnifiedSystemTray is enabled. These tests already works on Mash, so they are easier to port to UnifiedSystemTray by introducing UnifiedSystemTrayTestApi https://crrev.com/c/1086674 . Remaining SystemTray browser tests do not work with Mash, so we first have to make them work with Mash (in upcoming CLs). TEST=browser_tests --enable-features=SystemTrayUnified BUG= 847104 Change-Id: Ic6ce4ce547913240b68a32959dc86242276807e9 Reviewed-on: https://chromium-review.googlesource.com/1086683 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564718} [modify] https://crrev.com/1764a0dc7928ab6fb83201bf457ac72a976282c6/ash/system/unified/unified_system_info_view.cc [modify] https://crrev.com/1764a0dc7928ab6fb83201bf457ac72a976282c6/chrome/browser/chromeos/first_run/chromeos_first_run_browsertest.cc [modify] https://crrev.com/1764a0dc7928ab6fb83201bf457ac72a976282c6/chrome/browser/ui/ash/system_tray_client_browsertest.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36e326fda533471a7b4431ab2d57dea3b3dc20b2 commit 36e326fda533471a7b4431ab2d57dea3b3dc20b2 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 00:33:35 2018 Fix TrayBubbleView mask layer DCHECK. A mask layer should always have the same bounds as its parent's. TrayBubbleView sets a mask layer to layer()->parent(), but used the bounds of layer() for its mask layer. It caused DCHECK. Previously, https://crrev.com/c/663422 tried to fix this by using GetBubbleBounds(), but it still doesn't return the correct bounds in some cases e.g. |corner_radius| and |has_shadow| = false are set. TEST=TrayEventFilterTest BUG= 847104 , 764428 Change-Id: I677a0df7fc5342e7f722c97c30fc0b87f25b23f4 Reviewed-on: https://chromium-review.googlesource.com/1084530 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564738} [modify] https://crrev.com/36e326fda533471a7b4431ab2d57dea3b3dc20b2/ui/views/bubble/tray_bubble_view.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f18619a08c47467c27fb951adb6597502cfaaaf commit 4f18619a08c47467c27fb951adb6597502cfaaaf Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 01:19:31 2018 Add UnifiedSystemTrayTestApi. This CL adds UnifiedSystemTrayTestApi, which implements mojom::SystemTrayTestApi for UnifiedSystemTray. TEST=browser_tests --enable-features=SystemTrayUnified BUG= 847104 Change-Id: I278ec8d381aa9f7c13121088a892419dc627b655 Reviewed-on: https://chromium-review.googlesource.com/1086674 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#564759} [modify] https://crrev.com/4f18619a08c47467c27fb951adb6597502cfaaaf/ash/BUILD.gn [modify] https://crrev.com/4f18619a08c47467c27fb951adb6597502cfaaaf/ash/mojo_test_interface_factory.cc [modify] https://crrev.com/4f18619a08c47467c27fb951adb6597502cfaaaf/ash/system/unified/unified_system_tray.cc [modify] https://crrev.com/4f18619a08c47467c27fb951adb6597502cfaaaf/ash/system/unified/unified_system_tray.h [modify] https://crrev.com/4f18619a08c47467c27fb951adb6597502cfaaaf/ash/system/unified/unified_system_tray_bubble.h [add] https://crrev.com/4f18619a08c47467c27fb951adb6597502cfaaaf/ash/system/unified/unified_system_tray_test_api.cc [add] https://crrev.com/4f18619a08c47467c27fb951adb6597502cfaaaf/ash/system/unified/unified_system_tray_test_api.h
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/475be81df25c7ec82d8878badcdcaa0eb122e030 commit 475be81df25c7ec82d8878badcdcaa0eb122e030 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 15:55:03 2018 Vertical alignment support for UnifiedSystemTray. This CL adds right/left shelf alignment support for UnifiedSystemTray. TEST=PanelLayoutManagerTest.TouchHitTestPanel (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I69d2755dd18d40508c3183ae08a75eef732dcce8 Reviewed-on: https://chromium-review.googlesource.com/1086900 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564907} [modify] https://crrev.com/475be81df25c7ec82d8878badcdcaa0eb122e030/ash/system/unified/unified_system_tray.cc [modify] https://crrev.com/475be81df25c7ec82d8878badcdcaa0eb122e030/ash/system/unified/unified_system_tray.h
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6aa423cc3265e7cbffcda4cbf114a0cfe1b94c20 commit 6aa423cc3265e7cbffcda4cbf114a0cfe1b94c20 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 15:56:09 2018 Fix a11y text of enterprise managed button. Browser test requires all focusable views to have appropriate a11y texts. For EnterpriseManagedView, we manually override tooltip text, but it was not properly configured as a11y data. We can fix this by just using Button's SetTooltipText. TEST=SystemTrayClientEnterpriseTest.TrayEnterprise (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I8eb0e051446e4fcff4be691bf42e7af9fe99b8dd Reviewed-on: https://chromium-review.googlesource.com/1088328 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564909} [modify] https://crrev.com/6aa423cc3265e7cbffcda4cbf114a0cfe1b94c20/ash/system/unified/unified_system_info_view.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaa3a1ddb127e166efede5f74523f93c4f598cf6 commit aaa3a1ddb127e166efede5f74523f93c4f598cf6 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 16:41:40 2018 Fix status area focus test for UnifiedSystemTray. In the unit test, focusing in status area widget was tested using NotificationTray button and SystemTray button. As they are consolidated in UnifiedSystemTray, the test did not work with the flag enabled. This CL fixes the test to use IME tray button so it keeps working with UnifiedSystemTray. TEST=StatusAreaWidgetFocusTest.FocusOutObserver (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I8d8d3f274153daeb66ebc594d23b7ce4787a2cac Reviewed-on: https://chromium-review.googlesource.com/1088331 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564923} [modify] https://crrev.com/aaa3a1ddb127e166efede5f74523f93c4f598cf6/ash/system/status_area_widget_unittest.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9023a87c12a38478d219ab7cefd6fdc203ca5530 commit 9023a87c12a38478d219ab7cefd6fdc203ca5530 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 16:48:07 2018 Fix LoginScreenControllerNoSessionTest for Unified This CL fixes ShowSystemTrayOnPrimaryLoginScreen when UnifiedSystemTray is enabled. A system tray should not SetVisible(true) before UpdateAfterLoginStatusChange is called. TEST=LoginScreenControllerNoSessionTest.ShowSystemTrayOnPrimaryLoginScreen (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I2ca02dd55def1385e769f00604cd42281413d8b7 Reviewed-on: https://chromium-review.googlesource.com/1088266 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564924} [modify] https://crrev.com/9023a87c12a38478d219ab7cefd6fdc203ca5530/ash/system/status_area_widget.cc [modify] https://crrev.com/9023a87c12a38478d219ab7cefd6fdc203ca5530/ash/system/unified/unified_system_tray.cc [modify] https://crrev.com/9023a87c12a38478d219ab7cefd6fdc203ca5530/ash/system/unified/unified_system_tray.h
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/437a45bd0e3e2b76652a685d22cb9e1546547a22 commit 437a45bd0e3e2b76652a685d22cb9e1546547a22 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 17:13:50 2018 Fix shelf view unit test with UnifiedSystemTray. ShelfViewTest's way of triggering overflow button in Shelf sometimes didn't work depending on the width of the StatusArea. It led to test failures with a launching flag which changes Shelf width. Failing tests (with --enable-features=SystemTrayUnified): OverflowButtonActiveInkDropTest.TouchDragOut OverflowButtonActiveInkDropTest.TouchDragOutAndBack OverflowButtonInkDropTest.TouchDragOut OverflowButtonInkDropTest.TouchDragOutAndBack TEST=ash_unittests --enable-features=SystemTrayUnified BUG= 847104 Change-Id: I00f64255936ca32daba375832c0b39ccc3e27014 Reviewed-on: https://chromium-review.googlesource.com/1088532 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#564938} [modify] https://crrev.com/437a45bd0e3e2b76652a685d22cb9e1546547a22/ash/shelf/shelf_view_unittest.cc
,
Jun 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cef7c766280024fd214c625f8195263916148dac commit cef7c766280024fd214c625f8195263916148dac Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 06 17:39:54 2018 Remove reference to flags from MessageListView. This CL removes reference to runtime flags from MessageListView, and moved the option to the constructor. Direct reference to flag led to unit test failure in MessageCenterViewTest.SizeAfterUpdateOfRepositionTarget. TEST=out/Release/ash_unittests '--gtest_filter=*MessageCenter*' \ --enable-features=SystemTrayUnified BUG= 847104 Change-Id: I82d33c827d79bf5fc53d30453e8ac91b18396356 Reviewed-on: https://chromium-review.googlesource.com/1088329 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#564948} [modify] https://crrev.com/cef7c766280024fd214c625f8195263916148dac/ash/message_center/message_center_view.cc [modify] https://crrev.com/cef7c766280024fd214c625f8195263916148dac/ash/message_center/message_list_view.cc [modify] https://crrev.com/cef7c766280024fd214c625f8195263916148dac/ash/message_center/message_list_view.h [modify] https://crrev.com/cef7c766280024fd214c625f8195263916148dac/ash/message_center/message_list_view_unittest.cc
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b83e531f7182432ab3a5a5ca9ee92cf900aad06 commit 8b83e531f7182432ab3a5a5ca9ee92cf900aad06 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Jun 07 01:26:23 2018 Disable a11y SystemTray browser tests. This CL disables TrayAccessibilityTest. It's better to be fixed after AccessibilityManager is moved to ash/. TEST=browser_tests --enable-features=SystemTrayUnified BUG= 847104 , 850014 Change-Id: Idde44ac1b5aada8999c9cfca8b435c5e6d1615ab Reviewed-on: https://chromium-review.googlesource.com/1086892 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#565134} [modify] https://crrev.com/8b83e531f7182432ab3a5a5ca9ee92cf900aad06/chrome/browser/chromeos/DEPS [modify] https://crrev.com/8b83e531f7182432ab3a5a5ca9ee92cf900aad06/chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244 commit b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Jun 07 03:44:04 2018 Fix ShutdownPolicyInSessionTest with Mash. This CL fixes ShutdownPolicyInSessionTest browser test with Mash by using SystemTrayTestApi mojo interface. This also fixes the tests in UnifiedSystemTray. TEST=browser_tests '--gtest_filter=*ShutdownPolicyInSessionTest*' --enable-features=Mash BUG= 847104 Change-Id: If1cb15ebbcf35dc659142a3448ec6b2fbef29948 Reviewed-on: https://chromium-review.googlesource.com/1086821 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#565169} [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/ash/ash_view_ids.h [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/ash/public/interfaces/system_tray_test_api.mojom [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/ash/system/tiles/tiles_default_view.cc [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/ash/system/tray/system_tray_test_api.cc [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/ash/system/tray/system_tray_test_api.h [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/ash/system/unified/top_shortcuts_view.cc [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/ash/system/unified/unified_system_tray_test_api.cc [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/ash/system/unified/unified_system_tray_test_api.h [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/chrome/browser/chromeos/DEPS [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/chrome/browser/chromeos/shutdown_policy_browsertest.cc [add] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/chrome/test/data/extensions/theme/Cached Theme.pak [modify] https://crrev.com/b5c5a2a030e17b15bd8e7f31507e6d21c0c2b244/testing/buildbot/filters/mash.browser_tests.filter
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c941321669fb27866efd53646c2c391092c42a49 commit c941321669fb27866efd53646c2c391092c42a49 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Jun 07 05:31:48 2018 Fix SystemUse24HourClockPolicyTest with Mash. This CL fixes SystemUse24HourClockPolicyTest browser test with Mash by using SystemTrayTestApi mojo interface. This also fixes the tests in UnifiedSystemTray. This CL removes checking of GetHourTypeForTesting() for default view, because we consolidated the state variable to SystemTrayModel's ClockModel, so the check is no longer meaningful. TEST=browser_tests '--gtest_filter=*SystemUse24HourClockPolicyTest*' --enable-features=Mash BUG= 847104 Change-Id: I257600901bfb743d57ebb67410f345e51ced18de Reviewed-on: https://chromium-review.googlesource.com/1086896 Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#565193} [modify] https://crrev.com/c941321669fb27866efd53646c2c391092c42a49/ash/system/date/tray_system_info.cc [modify] https://crrev.com/c941321669fb27866efd53646c2c391092c42a49/ash/system/date/tray_system_info.h [modify] https://crrev.com/c941321669fb27866efd53646c2c391092c42a49/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc [modify] https://crrev.com/c941321669fb27866efd53646c2c391092c42a49/testing/buildbot/filters/mash.browser_tests.filter
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d386eb6d29cd8aada65196a1d9b8d7a789779cc commit 8d386eb6d29cd8aada65196a1d9b8d7a789779cc Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Jun 07 14:41:23 2018 Fix SystemTrayTrayCastMediaRouterChromeOSTest with Mash. This CL fixes SystemTrayTrayCastMediaRouterChromeOSTest browser test with Mash by using SystemTrayTestApi mojo interface. The CL also fixes the tests in UnifiedSystemTray. TEST=SystemTrayTrayCastMediaRouterChromeOSTest (--enable-features=Mash) BUG= 847104 Change-Id: I691371f2b4284fbc0490745b7a54b15125b67719 Reviewed-on: https://chromium-review.googlesource.com/1088348 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#565263} [modify] https://crrev.com/8d386eb6d29cd8aada65196a1d9b8d7a789779cc/ash/BUILD.gn [modify] https://crrev.com/8d386eb6d29cd8aada65196a1d9b8d7a789779cc/ash/ash_view_ids.h [modify] https://crrev.com/8d386eb6d29cd8aada65196a1d9b8d7a789779cc/ash/system/cast/cast_feature_pod_controller.cc [modify] https://crrev.com/8d386eb6d29cd8aada65196a1d9b8d7a789779cc/ash/system/cast/cast_feature_pod_controller.h [modify] https://crrev.com/8d386eb6d29cd8aada65196a1d9b8d7a789779cc/ash/system/cast/tray_cast.cc [modify] https://crrev.com/8d386eb6d29cd8aada65196a1d9b8d7a789779cc/ash/system/cast/tray_cast.h [delete] https://crrev.com/23c2a004082f767e4a5200df253c127a31fc9822/ash/system/cast/tray_cast_test_api.cc [delete] https://crrev.com/23c2a004082f767e4a5200df253c127a31fc9822/ash/system/cast/tray_cast_test_api.h [modify] https://crrev.com/8d386eb6d29cd8aada65196a1d9b8d7a789779cc/chrome/browser/ui/ash/DEPS [modify] https://crrev.com/8d386eb6d29cd8aada65196a1d9b8d7a789779cc/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be6c791b8c7d9d455e9c3bef61074f5e83646bdb commit be6c791b8c7d9d455e9c3bef61074f5e83646bdb Author: Tim Schumann <tschumann@chromium.org> Date: Mon Jun 11 11:06:50 2018 Disable flaky test ShutdownPolicyInSessionTest.PolicyChange TBR=tetsui@chromium.org Bug: 851208 , 847104 Change-Id: Iaec639e8b79485f711967f67e439c3f1fe205d93 Reviewed-on: https://chromium-review.googlesource.com/1095186 Reviewed-by: Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#565960} [modify] https://crrev.com/be6c791b8c7d9d455e9c3bef61074f5e83646bdb/chrome/browser/chromeos/shutdown_policy_browsertest.cc
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab2c725f9cca80f5c0ef80befba530e3cf85dc5a commit ab2c725f9cca80f5c0ef80befba530e3cf85dc5a Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Jun 11 22:20:09 2018 Not close UnifiedSystemTray on deactivate. UnifiedSystemTrayBubble's |close_on_deactivate| was set, but is is not necessary because the bubble is not activated by default. Old SystemTray also sets |close_on_deactivate| to be false. It caused some unit test to fail. TEST=ShelfLayoutManagerTest.ShelfFlickerOnTrayActivation (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: Ib0bd23cb4dfb5d2c024cb5fe709e1912d0a00ba1 Reviewed-on: https://chromium-review.googlesource.com/1095063 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#566171} [modify] https://crrev.com/ab2c725f9cca80f5c0ef80befba530e3cf85dc5a/ash/system/unified/unified_system_tray_bubble.cc
,
Jun 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb0879f0cf831b7a7a785fa12c66020e5434a29d commit eb0879f0cf831b7a7a785fa12c66020e5434a29d Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Jun 11 22:52:51 2018 Fix volume slider bubble request from ARC++. ARC++ might request Chrome OS to show volume slider bubble through ArcAudioBridge. This CL allows the feature to work with UnifiedSystemTray. TEST=UnifiedSystemTray.ShowVolumeSliderBubble (--enable-features=SystemTrayUnified) BUG= 847104 Change-Id: I55b298752a6d11952df85f068c4dae63d27f6a85 Reviewed-on: https://chromium-review.googlesource.com/1088455 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#566184} [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/BUILD.gn [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/public/interfaces/system_tray.mojom [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/audio/tray_audio.cc [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/audio/tray_audio.h [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/audio/tray_audio_unittest.cc [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/model/system_tray_model.cc [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/model/system_tray_model.h [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/status_area_widget.cc [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/tray/system_tray_controller.cc [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/tray/system_tray_controller.h [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/unified/unified_slider_bubble_controller.cc [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/unified/unified_slider_bubble_controller.h [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/unified/unified_system_tray.cc [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/unified/unified_system_tray.h [add] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/ash/system/unified/unified_system_tray_unittest.cc [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/components/arc/audio/DEPS [modify] https://crrev.com/eb0879f0cf831b7a7a785fa12c66020e5434a29d/components/arc/audio/arc_audio_bridge.cc
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/380e42220e8ba90f17954c48cf03a97ad6015b69 commit 380e42220e8ba90f17954c48cf03a97ad6015b69 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 12 17:01:45 2018 Unified: Fix system tray related exo_unittests. It fixes exo_unittests that references system tray. It didn't work when UnifiedSystemTray is enabled. This is a flag flip blocker of chrome://flags/#enable-system-tray-unified. This CL fixes the following test: ClientControlledShellSurfaceTest.KeyboardNavigationWithSystemTray TEST=exo_unittests --enable-features=SystemTrayUnified BUG= 847104 Change-Id: Ic205250bb4712365b441a0f630d1a71e7eb9fae3 Reviewed-on: https://chromium-review.googlesource.com/1096719 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#566470} [modify] https://crrev.com/380e42220e8ba90f17954c48cf03a97ad6015b69/ash/system/unified/unified_system_tray.cc [modify] https://crrev.com/380e42220e8ba90f17954c48cf03a97ad6015b69/ash/system/unified/unified_system_tray.h [modify] https://crrev.com/380e42220e8ba90f17954c48cf03a97ad6015b69/ash/system/unified/unified_system_tray_bubble.cc [modify] https://crrev.com/380e42220e8ba90f17954c48cf03a97ad6015b69/ash/system/unified/unified_system_tray_bubble.h [modify] https://crrev.com/380e42220e8ba90f17954c48cf03a97ad6015b69/components/exo/client_controlled_shell_surface_unittest.cc
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ca1afc05737915dfe5a6ae82cd892459a31ad08 commit 0ca1afc05737915dfe5a6ae82cd892459a31ad08 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 12 17:02:10 2018 Unified: Fix login related interactive_ui_tests. It fixes login related interactive_ui_tests when UnifiedSystemTray is enabled. This is a flag flip blocker of chrome://flags/#enable-system-tray-unified. After the flag flip, this will also be refactored to work with Mash. This fixes following tests in interactive_ui_tests: * LoginUserTest.UserPassed * LoginGuestTest.GuestIsOTR * LoginCursorTest.CursorHidden UnifiedSystemTray design doc: http://go/cros-qs-restyling TEST=interactive_ui_tests --enable-features=SystemTrayUnified BUG= 847104 Change-Id: I949753e415283c8e961a47b4af4defbcc59f3246 Reviewed-on: https://chromium-review.googlesource.com/1096588 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#566471} [modify] https://crrev.com/0ca1afc05737915dfe5a6ae82cd892459a31ad08/chrome/browser/chromeos/login/DEPS [modify] https://crrev.com/0ca1afc05737915dfe5a6ae82cd892459a31ad08/chrome/browser/chromeos/login/login_browsertest.cc
,
Jun 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/992f49cb5806a5ed615d53c302feda87406a3394 commit 992f49cb5806a5ed615d53c302feda87406a3394 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Jun 12 17:08:30 2018 Unified: Fix ChromeVox interactive_ui_tests. It fixes ChromeVox related interactive_ui_tests when UnifiedSystemTray is enabled. This is a flag flip blocker of chrome://flags/#enable-system-tray-unified. After the flag flip, this will also be refactored to work with Mash. This fixes following tests in interactive_ui_tests: StickyKeysBrowserTest.OpenTrayMenu TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/0 SelectToSpeakTest.SpeakStatusTray TestAsNormalAndGuestUser/SpokenFeedbackTest.OpenStatusTray/1 TEST=interactive_ui_tests --enable-features=SystemTrayUnified BUG= 847104 Change-Id: I9f2c821c4465b0af02812b94396b5f0a274d313c Reviewed-on: https://chromium-review.googlesource.com/1096718 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#566474} [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/ash/system/unified/top_shortcuts_view.cc [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/ash/system/unified/top_shortcuts_view.h [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/ash/system/unified/unified_system_tray.cc [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/ash/system/unified/unified_system_tray.h [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/ash/system/unified/unified_system_tray_bubble.cc [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/ash/system/unified/unified_system_tray_view.cc [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/ash/system/unified/unified_system_tray_view.h [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/chrome/browser/chromeos/accessibility/DEPS [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [modify] https://crrev.com/992f49cb5806a5ed615d53c302feda87406a3394/chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9edb615f8cb2ff001f8f0e83b391049afc1c1320 commit 9edb615f8cb2ff001f8f0e83b391049afc1c1320 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 13 04:19:04 2018 Unified: Fix FirstRunUIBrowserTest. It fixes FirstRunUIBrowserTest when UnifiedSystemTray is enabled. The test is regressed by interactive_ui_tests fix https://crrev.com/c/1096718. We only have to set initial focus when system tray bubble is activated. This is a flag flip blocker of chrome://flags/#enable-system-tray-unified. TEST=FirstRunUIBrowserTest.EscapeCancelsTutorial BUG= 847104 Change-Id: Iccb8ea92724fffc787a649e1a4fdac36507f3b71 Reviewed-on: https://chromium-review.googlesource.com/1098419 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#566718} [modify] https://crrev.com/9edb615f8cb2ff001f8f0e83b391049afc1c1320/ash/system/unified/unified_system_tray_bubble.cc [modify] https://crrev.com/9edb615f8cb2ff001f8f0e83b391049afc1c1320/ash/system/unified/unified_system_tray_bubble.h
,
Jun 14 2018
,
Jun 19 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 1 2018