New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 847103 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 849369



Sign in to add a comment

Check logs for r562144

Project Member Reported by mmoroz@chromium.org, May 28 2018

Issue description

REVISION	REPORT	LINE COVERAGE	FUNCTION COVERAGE	REGION COVERAGE	LOGS
562144	Tests and Fuzzers	 70.04% (6577014/9390877)	 73.51% (570344/775865)	 70.62% (8678859/12290111)	Link

Report link: https://chromium-coverage.appspot.com/reports/562144/linux/index.html

Logs link: https://chromium-coverage.appspot.com/reports/562144/linux/metadata/index.html

I've removed the report from the dashboard, but it's interesting to see what happened: any targets failed, or any warnings / errors happened during merging / generating.
 

Comment 1 by mmoroz@chromium.org, May 31 2018

One more: Low coverage reported for r562745 (68.99% < 70.00% threshold)

Comment 2 by mmoroz@google.com, Jun 1 2018

r563183 and r563332 also


I think our lives will be much easier after switching to Chromium builders, which provides nice UI to visualize the results of each step and we can also potentially set up monitoring and alerts.
for r563332,
search for "Retrying, attempt"
https://chromium-coverage.appspot.com/reports/563332/linux/metadata/_bot.log
you will see browser tests failed thrice!, so no data from profdata

for r563183,
also an issue with browser tests, browser_tests binary failed, so partial data
https://chromium-coverage.appspot.com/reports/563183/linux/metadata/browser_tests.log
we might need aggressive return code retry or add another one to 124 ?

We can discuss some solution next week
Blockedon: 849369
Notes for myself (probably will get to it post bug-bash).

https://chromium-coverage.appspot.com/reports/563980/linux/metadata/browser_tests.log went through (just over 70%), even though bad report. Has same issue of too many browser tests failing. "Too many badly broken tests" is common message we might rely on. Regular builders browser_tests were green (https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29/72408).

[4508/8953] ExtensionStorageMonitorTest.HostedAppTemporaryFilesystem (TIMED OUT)
[0604/085140.925167:ERROR:kill_posix.cc(83)] Unable to terminate process group 4687: No such process (3)
[0604/085140.931081:ERROR:kill_posix.cc(83)] Unable to terminate process group 4688: No such process (3)
[ RUN      ] ExtensionTabUtilBrowserTest.OpenExtensionsOptionsPage
[4509/8953] ExtensionTabUtilBrowserTest.OpenExtensionsOptionsPage (TIMED OUT)
Too many badly broken tests (879), exiting now.
Sending SIGTERM to 15 child processes... done.
Giving processes a chance to terminate cleanly... done.
Sending SIGKILL to 15 child processes... done.

So, might have to add retry logic and make it fail completely otherwise (no profdata merge at all if too bad results ??)
Labels: Coverage-v2-Blocker
Yeah, weird that it started to happen more often recently: https://pantheon.corp.google.com/errors/CPHL8Z6A9-aiBQ?time=P30D&project=chromium-coverage

we have reports with low coverage every day, but previously we haven't seen so many of them.

But we're still getting good ones as well, so should be acceptable for now.
Problem is 2 reports >70% went on the dash and didn't quarantine (https://chromium-coverage.appspot.com/reports/563980/linux/chromium/src/report.html, https://chromium-coverage.appspot.com/reports/564080/linux/chromium/src/report.html). I think https://chrome-internal-review.googlesource.com/c/chrome/tools/code-coverage/+/636127 should help. if browser tests are badly broken and can't recover, we shouldnt try profdata and hence it will be definitely <70% then.


Owner: infe...@chromium.org
Status: Started (was: Untriaged)
i have removed r564080 and r563980 from dash to avoid confusion.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/code-coverage/+/1f0c0416e434cc4fda2dfd297ca8be8cb6763dfe

commit 1f0c0416e434cc4fda2dfd297ca8be8cb6763dfe
Author: Abhishek Arya <inferno@chromium.org>
Date: Wed Jun 06 14:10:18 2018

Comment 12 by aarya@google.com, Jun 7 2018

r564730 had same issue, so removed from dash, hopefully my fix will be uptaken by all bots today.

Comment 13 by mmoroz@google.com, Jun 7 2018

All bots were updated by EOD yesterday. The most recent "low coverage" error was 11 hours ago and I'm sure it was from a non-updated bot.
Status: Fixed (was: Started)
Marking fixed for now, will reopen if we see anything on dash with low coverage.
Don't see any error in last 24 hours, but I do see 6 great reports. Awesome! Thanks, Abhishek!
No reports in quarantine for last 2 days, so looks like this fix worked.
gs://chromium-coverage/reports_quarantine

Sign in to add a comment